Sam Coe
c89d0402bb
Improved error messaging for repo sync scenario ( #6430 )
2022-10-14 09:46:12 +00:00
Sam Coe
2944f7c3ab
Create git client ( #6354 )
2022-10-14 07:47:03 +00:00
Natthakit Susanthitanon
4c3b123db6
Return empty error before starting a pager program ( #6419 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-10-13 19:08:13 +02:00
Natthakit Susanthitanon
5962bc4383
Add ssh-key delete command ( #6273 )
2022-10-12 08:22:22 +00:00
David Gardiner
f80f566ab2
Merge pull request #6358 from dmgardiner25/dmgardiner25/grpc-client
...
Implement gRPC client and `GetRunningServer` method
2022-10-11 10:45:50 -07:00
Jose Garcia
a356a1bef0
no need to ignore cancel
2022-10-11 13:15:34 -04:00
Caleb Brose
a937b278b2
Merge pull request #6404 from jungaretti/jungaretti/add-rebuild-command
...
Add cs rebuild command
2022-10-11 10:11:09 -05:00
Jose Garcia
e11b43f8f6
Fixes for handling the grpc client lifecyle
2022-10-11 08:55:14 -04:00
Ariel Deitcher
331dc24f07
show pull request merged state on search ( #6411 )
2022-10-11 14:40:16 +02:00
David Gardiner
f89b1b6a45
Create timeout context in caller
2022-10-10 14:39:12 -07:00
JP Ungaretti
982aa5ba82
Rename RPC command to RebuildContainer
2022-10-10 21:01:29 +00:00
David Gardiner
0f41ccc472
Have cilents call port connection function
2022-10-10 11:56:44 -07:00
JP Ungaretti
0e963ebd4f
Move codespace construction to its test
2022-10-09 01:11:04 +00:00
JP Ungaretti
6704f38ffc
Verify that RPC was called
2022-10-09 01:05:52 +00:00
JP Ungaretti
b373fbbe44
Remove else block
2022-10-09 01:00:14 +00:00
JP Ungaretti
30fcddeccb
Use nil instead of []string{}
2022-10-09 00:59:54 +00:00
JP Ungaretti
d05cdf5ff3
Tidy up comments and errors
2022-10-08 06:30:42 +00:00
JP Ungaretti
4c49fd3e64
Add rebuild command
2022-10-08 06:12:36 +00:00
JP Ungaretti
da91216c31
Add new Rebuild function
2022-10-08 00:04:45 +00:00
David Gardiner
a090b17e38
Ensure port is forwarded and server is shared
2022-10-07 15:37:04 -07:00
Nate Smith
99e76a709f
Merge pull request #6292 from lpessoa/lp-checks
...
feat: adding checks at GH PR view
2022-10-06 14:27:38 -05:00
lpessoa
fb6f538f88
Adding no checks message when PR has no checks
...
Including additional tests.
2022-10-05 22:10:38 -03:00
vilmibm
0660ced676
tweak wording and formatting
2022-10-05 15:59:33 -07:00
lktslionel
0b0ae1e673
feat(cmd/release): allow to delete release with its attached tag
2022-10-06 00:35:06 +02:00
Nate Smith
4a2ca15350
Merge pull request #6324 from nsmag/auth-token
...
Add `gh auth token`
2022-10-04 14:56:21 -05:00
Nate Smith
b2d1955b05
Merge pull request #6296 from heaths/issue6089
...
Add more help to "template" flags
2022-10-04 14:53:18 -05:00
Nate Smith
9e7a6ebe4e
Merge pull request #6382 from aacoakley/merge-author-email-flag
...
Add flag to pr merge allowing the selection of the merge commit email
2022-10-04 14:50:57 -05:00
Nate Smith
c13eb9e792
Merge pull request #6320 from cli/label-prompter
...
add and use ConfirmDeletion in {label,repo} delete
2022-10-04 14:49:59 -05:00
vilmibm
f7fa164792
tweak wording
2022-10-04 12:46:41 -07:00
Nate Smith
f82c6a6c87
Merge pull request #6359 from cli/mntlty/formatting_help
...
update formatting help
2022-10-04 14:04:30 -05:00
Ariel Deitcher
7a55496b87
code review feedback
2022-10-03 19:07:32 +03:00
Ariel Deitcher
6785e9fa67
update formatting help command
2022-10-03 03:23:14 -07:00
Ariel Deitcher
577d42280c
surface merge conflicts in pr status ( #5999 )
2022-10-03 09:32:48 +00:00
Austin Coakley
6d4b10edf0
Added flag to pr merge allowing the selection of the merge commit email
2022-10-01 12:16:05 -05:00
David Gardiner
766e6a2314
Use existing context
2022-09-29 09:58:44 -07:00
Anthony Fok
f6d0f82701
Fix missing text in gh-codespace-ssh.1 man page
...
Rearrange the long help text so that '--config' does not appear at the
start of a line which groff interprets as an undefined macro and skips
the content of that whole line.
To reproduce:
$ go run cmd/gen-docs/main.go --man-page --doc-path /tmp/gh-manpages
$ man --warnings -E UTF-8 -l -Tutf8 -Z /tmp/gh-manpages/gh-codespace-ssh.1 >/dev/null
troff: <standard input>:26: warning: macro '--config'' not defined
Discovered by the Debian Lintian tool.
2022-09-28 14:00:37 -06:00
David Gardiner
35d2cf30d0
Send session token
2022-09-28 11:28:35 -07:00
David Gardiner
3f34d6d95e
Make suggested gRPC client changes
2022-09-28 10:39:26 -07:00
Natthakit Susanthitanon
ed9361fc88
Add header to the gpg-key list output ( #6353 )
2022-09-28 08:26:43 +02:00
David Gardiner
93f033fe87
Address comments
2022-09-27 16:01:10 -07:00
David Gardiner
b0eb1b379a
Implement gRPC client
2022-09-27 11:34:30 -07:00
Mislav Marohnić
efe504eefc
Fix color output for non-256 color terminals
...
The function enableVirtualTerminalProcessing must return an error if
virtual terminal processing (only applicable on Windows) was not
enabled, otherwise we assume that the terminal supports both 256-color
and truecolor.
We have been erroneously assuming that all non-Windows terminals are
256-color and sending escape sequences to those that cannot intepret
them. This led to some parts of Survey prompts being invisible on old
terminals.
Regressed in be4b392530
2022-09-27 19:50:05 +02:00
Mislav Marohnić
acb61072cd
Respect GH_HOST in auth login, repo delete
...
Bonus fix: respect fallback host argument to `FromFullNameWithHost()`
2022-09-26 13:32:54 +02:00
Mislav Marohnić
465b952d85
Merge pull request #6344 from cli/yaml-dispatch
...
Recognize `.yaml` in addition to `.yml` suffix as workflow file name
2022-09-26 11:54:25 +02:00
Mislav Marohnić
6a6fd7bace
Recognize .yaml in addition to .yml suffix as workflow file name
2022-09-26 10:54:57 +02:00
Eng Zer Jun
471cbea4fa
test: use t.Setenv to set env vars in tests ( #6333 )
...
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-26 08:46:02 +00:00
Natthakit Susanthitanon
1a759ecd4b
Add header and id column to the gh ssh-key list output ( #6270 )
2022-09-22 14:07:57 +04:00
Natthakit Susanthitanon
60d8cb085a
Add gh auth token
2022-09-22 15:47:19 +07:00
Nate Smith
87a0db2a3b
Merge pull request #6317 from cli/cmbrose/local-ssh-test-fix
...
Ensure local keys don't interfere with ssh_test
2022-09-21 19:31:23 -05:00
Nate Smith
666470744d
Merge pull request #6313 from cli/context-prompter
...
use Prompter in context
2022-09-21 19:28:54 -05:00