William Martin
c8dd61d837
Feature detect v1 projects on non-interactive issue create
2025-04-17 17:51:38 +02:00
William Martin
5ec2160bc6
Avoid requesting projectCards for issue view
2025-04-17 15:37:48 +02:00
William Martin
fff0e70259
Provide better HTTP Exclude failure messages
2025-04-17 15:37:42 +02:00
William Martin
55d3b1eaa4
Document TestArgParsing
2025-04-17 15:33:44 +02:00
William Martin
cfa90a2c80
Remove old issue lookup funcs
2025-04-17 15:27:40 +02:00
William Martin
81ecbd8e1d
Issue view early arg parsing
2025-04-17 15:27:40 +02:00
William Martin
e474acc2dd
Issue comment early arg parsing
2025-04-17 15:27:40 +02:00
William Martin
455c77add8
Issue unpin early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
f55138c896
Issue transfer early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
5c67c1944b
Issue reopen early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
96699329fc
Issue pin early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
60f248458c
Issue lock early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
7744e0564f
Issue develop early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
6129b26f9f
Issue delete early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
8b615ec2e6
Issue close early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
aaddcb019d
Issue edit early arg parsing
2025-04-17 15:27:39 +02:00
Andy Feller
0ef0c42665
Merge pull request #10767 from leudz/fix-9749
...
Fix multi pages search for gh search
2025-04-16 16:57:12 -04:00
Kynan Ware
bff4db1309
Merge pull request #10773 from cli/kw/opt-into-no-spinners
...
Introduce option to opt-out of spinners
2025-04-16 14:44:45 -06:00
leudz
4a885899d6
Add comments for Total
2025-04-16 20:46:29 +02:00
Andy Feller
ba390db71f
PR feedback
...
- update local variables to communicate what they are
- added docblock explaining search results populated
2025-04-16 14:22:29 -04:00
Kynan Ware
dabb29bd36
test(factory): remove needless nil check
2025-04-16 11:21:39 -06:00
Kynan Ware
1dbb01a1d1
doc(help): add documentation for GH_SPINNER_DISABLED
2025-04-16 11:17:23 -06:00
Kynan Ware
056d292f26
doc(iostreams): comment behavior of textual progress indicator
2025-04-16 11:13:58 -06:00
Kynan Ware
290e78c904
test(iostreams): update test description
2025-04-16 11:05:36 -06:00
Andy Feller
becd936e7b
Update searcher tests
...
This commit moves the remaining searcher tests from using JSON marshaled types to using JSON responses for consistency. There appears to be a weird JSON marshaling error with search.Repository that does not map `Name` field in the process.
Additionally, the test scenarios around pulling multiple pages beneath the total results have been updated to demonstrate that the REST API returns full pages in both of these cases, which is below the total number of results.
2025-04-15 17:13:43 -04:00
William Martin
a9dbda6913
Rework ref usage when finding and creating PRs
2025-04-15 13:38:10 -06:00
Kynan Ware
028caa3823
docs(pr create): clarify BaseRepo type in submitPR
2025-04-15 13:38:10 -06:00
Kynan Ware
339e1a25f3
docs(pr create): add link for user:branch syntax
2025-04-15 13:38:10 -06:00
Kynan Ware
76de5f07ca
test(pr finder): run test in parallel
2025-04-15 13:38:10 -06:00
Kynan Ware
bf7bf99f54
fix(pr create & stubs): handle exitcode in stubs
2025-04-15 13:38:10 -06:00
Kynan Ware
81d00a36f8
fix(pr create): use existing local variables
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
15ea861b79
docs(pr create): help text, doc user:branch syntax
...
Document the user:branch syntax for the `--head`` flag in `gh pr create`.
2025-04-15 13:38:10 -06:00
Kynan Ware
7bb5d71f4c
doc(pr create): improve head repo resolution comments
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
041f02c980
docs(pr create): standard <user>:<branch> syntax
...
Standardize <user>:<branch> syntax wherever it is described in comments.
2025-04-15 13:38:10 -06:00
Kynan Ware
6dae35b442
test(finder): change assert to require
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
e9e57f3ee3
doc(pr create): fix typo in comments
...
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
d524cbddc2
docs(pr create): clarify comment on head branch syntax
2025-04-15 13:38:10 -06:00
Kynan Ware
e999976b3d
refactor(pr create): add PullRequestRefs HasHead
2025-04-15 13:38:10 -06:00
Kynan Ware
54da786bec
fix(pr create): update error handling
2025-04-15 13:38:10 -06:00
Kynan Ware
bab7dc650b
test(pr create): update repo owner names in tests
2025-04-15 13:38:10 -06:00
Kynan Ware
da235b134b
tests(pr create): remove irrelevant comments
2025-04-15 13:38:10 -06:00
Kynan Ware
9b96e6cded
doc(pr create): fix typo in test comments
...
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
911079c744
docs(pr create): add comments
2025-04-15 13:38:10 -06:00
Kynan Ware
cf58910ac0
refactor(pr create): named headRefName var
2025-04-15 13:38:10 -06:00
Kynan Ware
9f1cb0cd54
refactor(pr create): simplify head remote logic
2025-04-15 13:38:10 -06:00
Kynan Ware
f50dac53cb
docs(pr create): fix <repo_name>:<branch> desc.
2025-04-15 13:38:10 -06:00
Kynan Ware
c0c5d9123d
refactor(pr create): use GetPRHeadLabel()
...
Use PrRefs.GetPRHeadLabel() instead of headBranchLabel.
Also remove headBranchLabel from CreateContext struct.
To do this, we needed a new identifier for when the head repo should be
created via a new fork of the base repo. Previously, this was done by
checking if the head repo was nil, but if we want to call
GetPRHeadLabel(), it requires a non-nil head repo to construct the
headBranchLabel. So, instead of the head repo being nil to signal
a fork, we pass a new forkHeadRepo bool in the CreateContext struct.
This also makes the decision to fork more intentional; now the decision
is made clearly instead of if the headRepo happens to be nil.
2025-04-15 13:38:10 -06:00
Kynan Ware
178fb40515
refactor(pr create): Use PrRefs in CreateContext
...
Replace BaseRepo, HeadRepo, HeadBranch with PrRefs in CreateContext struct.
2025-04-15 13:38:10 -06:00
Kynan Ware
c3087cde99
refactor(pr create): Refactor NewCreateContext
...
- Use prRefs instead of local vars more.
- Rename variables for readability.
- Improve comments.
- Refactor tests.
2025-04-15 13:38:10 -06:00
Kynan Ware
10e3949348
refactor(pr create): use prRefs.GetPRHeadLabel()
2025-04-15 13:38:10 -06:00