vilmibm
dd877b6a34
merge fallout
2020-03-25 12:01:44 -05:00
vilmibm
f4b8851011
Merge remote-tracking branch 'origin/master' into pr-status-no-commits
2020-03-25 12:00:58 -05:00
Nate Smith
e4b8ae0ec4
Merge pull request #665 from cli/preview-default
...
switch {pr,issue} view default
2020-03-25 11:32:46 -05:00
Nate Smith
26022bc684
Merge pull request #690 from cli/repo-view-terminal
...
Add ability to view repo in terminal and do it by default
2020-03-25 11:32:26 -05:00
vilmibm
a8a57595dc
explicitly ignore readme fetching error
2020-03-25 11:26:58 -05:00
vilmibm
379ecdab54
move readme fetching to api package
2020-03-24 15:21:18 -05:00
Nate Smith
f2e5269158
Merge pull request #694 from cli/respect-b
...
respect -B when checking for existing pull requests
2020-03-24 15:14:28 -05:00
Nate Smith
537842f64f
Merge pull request #687 from cli/pr-checkout-repo-override
...
Respect base repository when passing URL argument to `pr checkout/view`
2020-03-24 14:31:38 -05:00
vilmibm
dd1e2a2dfc
add StubError to CmdStubber
2020-03-24 14:19:35 -05:00
vilmibm
88cf6ce16e
consolidate CmdStubber into test package
2020-03-23 16:36:24 -05:00
vilmibm
5187ad4431
move preparecmd and Runnable to its own package
2020-03-23 16:32:29 -05:00
vilmibm
121173c330
better error reporting + catch for empty repo
2020-03-23 15:21:58 -05:00
vilmibm
2895252e3b
respect -B when checking for existing pull requests
2020-03-23 14:26:31 -05:00
vilmibm
3459dfab95
add viewing repo in terminal
2020-03-20 16:26:49 -05:00
vilmibm
ff96f48479
add ExpectLines helper
2020-03-20 16:26:49 -05:00
Mislav Marohnić
488b47bded
Enable tests to capture spinner output
...
Explicitly assign the writer stream for the progress spinner so that
tests may override it.
The default when not in testing stays the same: the output stream is the
colorable stdout.
2020-03-20 18:18:27 +01:00
Mislav Marohnić
88c060c610
Fix broken pr view test
2020-03-20 18:15:09 +01:00
Mislav Marohnić
9786498a25
Respect base repository when passing URL argument to pr checkout/view
...
Previously, the repository owner+name component of the URL was ignored
and only the pull request number was read. Now, the URL dictates which
base repository will be used.
2020-03-20 18:06:40 +01:00
Nate Smith
51eb2cb345
Merge branch 'master' into pr-count
2020-03-18 09:26:05 -07:00
Nate Smith
3334bdd9b7
Merge pull request #668 from cli/mislav/check-if-pr-exists
...
Check for existing pull request on `pr create`
2020-03-18 08:37:28 -07:00
Nate Smith
75ebf1694f
Merge pull request #670 from cli/pr-status-branch-err
...
Allow `pr status` in cases where there is no current git branch
2020-03-18 08:34:41 -07:00
Mislav Marohnić
206844681b
Merge pull request #669 from doi-t/add-pr-status-tests
...
Add unit tests for Closed and Merged states of the current branch
2020-03-18 14:21:42 +01:00
Mislav Marohnić
a40fb04fc3
Allow pr status use when on detached HEAD
2020-03-18 14:14:45 +01:00
Mislav Marohnić
bec667964c
Allow pr status -R <repo> usage from outside of a git repo
2020-03-18 14:13:17 +01:00
Mislav Marohnić
e80c2f852d
Merge pull request #656 from sh7dm/fix-repo-not-found
...
Don't list remotes when --repo flag is set
2020-03-18 13:53:57 +01:00
Toshiya Doi
a2d3923d21
Add unit tests for Closed and Merged states of the current branch
2020-03-18 21:35:06 +09:00
Mislav Marohnić
5b76881624
Improve detecting existing PR on pr create
...
- Only check for existing PRs if `--web` wasn't given
- Fix detecting PRs from forks
- Improve order of error handling: local validation errors are handled
earlier than the ones that have to consult the API
2020-03-18 13:09:02 +01:00
Mislav Marohnić
23dfeff84f
Merge remote-tracking branch 'origin/master' into check-if-pr-exists
2020-03-18 12:04:08 +01:00
Mislav Marohnić
cb06812d19
Merge pull request #532 from mingrammer/consistent-printing
...
fix: inconsistent format between issue list and status
2020-03-18 11:59:17 +01:00
vilmibm
e4b43b08b9
update usage text
2020-03-17 17:13:48 -05:00
vilmibm
00de6b9c09
switch defaults for issue view
2020-03-17 17:06:42 -05:00
vilmibm
c30b482bf0
switch defaults for pr view
2020-03-17 17:06:42 -05:00
vilmibm
0344e9543a
humanize branch name for title
2020-03-17 16:18:32 -05:00
vilmibm
98a2281f45
more nuanced error handling
2020-03-17 16:09:40 -05:00
Dmitry Sharshakov
d755288cdf
Implement review comments
2020-03-17 20:05:53 +03:00
vilmibm
af46fcb1ff
--fill for pr create
2020-03-16 15:32:47 -05:00
vilmibm
2d90c09f48
review feedback
2020-03-16 15:32:35 -05:00
Tarasovych
d0c32e7a3d
changed error message and pr check
2020-03-16 16:01:03 +02:00
Dmitry Sharshakov
45c2a16d49
Don't list remotes when --repo flag is set
2020-03-14 23:14:38 +03:00
UmairShahzad
f51669e228
Merge remote-tracking branch 'origin/master' into pr-count
2020-03-14 19:02:51 +05:00
vilmibm
a23549001e
cleanup
2020-03-13 15:14:32 -05:00
vilmibm
1b7840326c
actually add tests for computing defaults
2020-03-13 15:14:03 -05:00
vilmibm
fba4f4d19e
InitCmdStubber
2020-03-13 15:12:23 -05:00
vilmibm
c4c967fa0f
add AskStubber
2020-03-13 15:12:17 -05:00
vilmibm
ed8aaa83e3
add CmdStubber
2020-03-13 15:12:09 -05:00
vilmibm
8769299731
titlebody prepopulation
2020-03-13 15:12:03 -05:00
Toshiya Doi
102cfdb1a2
Rearrange the order of command initialization
2020-03-13 23:59:18 +09:00
Toshiya Doi
5e3aa31cf1
Fix 'gh issue view' usage description
2020-03-13 23:58:41 +09:00
Tarasovych
f3c9406e76
fixed repo argument
2020-03-13 16:01:37 +02:00
Tarasovych
b544583b26
added check if pr already exists
2020-03-13 14:02:29 +02:00