STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8674 commits 87 branches 0 tags 160 MiB
Commit graph

4023 commits

Author SHA1 Message Date
William Martin
cc4bf0fc9f Add small wait to extension update tests 2025-01-16 14:10:42 +01:00
Andy Feller
243acaf579 Refactor test based on PR feedback 2025-01-16 00:08:45 -05:00
Andy Feller
bc8c46b0b1 Make extension update check non-blocking 
Fixes #10235

This commit updates the Cobra command logic around extension upgrade checks to be non-blocking.

Previously, we were waiting for 1 second after the extension completed to allow the update checking logic complete, however users want the GitHub CLI to run as far as possible.
 2025-01-13 20:38:03 -05:00
Meredith Lancaster
112552fec1
Merge pull request #10185 from malancas/fetch-artifact-attestation-bundles-with-sas-url 2025-01-13 08:20:33 -07:00
Andy Feller
41e99b9eab
Merge pull request #9934 from cli/andyfeller/cli-cli-8183-timeout-pt2 
Ensure extension update notices only notify once within 24 hours, provide ability to disable all extension update notices
 2025-01-13 09:12:32 -05:00
Andy Feller
3ada5af872 Enhance help docs on ext upgrade notices 
- update `gh help environment` to include that upgrade notices only happen when gh or extensions are executed
- update `gh ext --help` to include reference to upgrade notices and points to `gh help environment` for info on disabling
 2025-01-13 08:41:10 -05:00
Andy Feller
0a1c9be656 Expand docs on cleaning extension update dir 
This summarizes a conversation within cli/cli#9934 PR regarding how the new extension update directory metadata would affect gh if not cleaned up.
 2025-01-10 14:57:10 -05:00
Andy Feller
97eb8a194e Simplifying cleanExtensionUpdateDir logic 
This function was doing some unnecessary heavy lifting detecting if the directory being deleted actually existed when `os.RemoveAll()` would handle directories that exist or not.
 2025-01-10 14:29:55 -05:00
Andy Feller
20062233c8 Separate logic for checking updates 
During discussion in cli/cli#9934, we can to the conclusion that the logic around checking for core GitHub CLI updates would diverge from GitHub CLI
extension updates over time.  To that end, this commit splits that logic into a separate function with a new environment variable.
 2025-01-10 14:16:46 -05:00
nobe4
69b17272d6
fix: add back colon that I removed 2025-01-10 17:17:14 +01:00
nobe4
69ab0c9c85
fix: actually read how MaxFunc work and simplify the code 2025-01-10 16:31:13 +01:00
nobe4
1899b83509
fix: padded display 
Apply code suggestion from @andyfeller from:
- https://github.com/cli/cli/pull/10194#discussion_r1909761552
- https://github.com/cli/cli/pull/10194#discussion_r1909764278
 2025-01-10 16:28:50 +01:00
William Martin
889c4c75f3 Collapse dryrun checks in ext bin upgrade 2025-01-10 16:06:01 +01:00
Tyler McGoffin
4c8d124d37
Merge pull request #10194 from nobe4/fancier-extention-upgrade 
feat: make the extension upgrade fancier
 2025-01-09 14:59:52 -08:00
Andy Feller
954d4d5dbc
Correct help documentation around template use in gh issue create 
Relates #10202 

While we figure out how to handle consistent experience using templates for creating issues and PRs, let's correct the help usage for issue template flag use as this is the issue template name, not filename.
 2025-01-09 11:08:18 -05:00
Meredith Lancaster
8ad877b188 add check for invalid attestation 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-08 08:38:43 -07:00
Meredith Lancaster
33d0002d21 update tests to use new function name 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 15:22:02 -07:00
Meredith Lancaster
8d89dd97fd
Update pkg/cmd/attestation/api/client.go 
Co-authored-by: Phill MV <phillmv@github.com>
 2025-01-07 15:14:53 -07:00
Meredith Lancaster
51a74aed1d
Update pkg/cmd/attestation/api/client.go 
Co-authored-by: Phill MV <phillmv@github.com>
 2025-01-07 15:14:23 -07:00
Meredith Lancaster
42cb2547cd remove old comment 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 14:13:50 -07:00
Meredith Lancaster
d4f3fbce9b
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-07 12:04:12 -07:00
Meredith Lancaster
f46cccbab4 comment 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 12:03:49 -07:00
Meredith Lancaster
258c69cd26 undo more name chanages 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:56:05 -07:00
Meredith Lancaster
0a602fae07 undo other name change 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:54:02 -07:00
Meredith Lancaster
37e0969f20 remove spaces 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:51:51 -07:00
Meredith Lancaster
3c0280c4d7 undo name change for now 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:51:23 -07:00
Meredith Lancaster
7838e912b6 more mock http client cleanup 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:37:02 -07:00
Meredith Lancaster
9d88ca8cf8 simplify mock http client 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:32:49 -07:00
Meredith Lancaster
ecf55c6c16 use mock to assert number of http calls 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 10:54:17 -07:00
Meredith Lancaster
e34e188ee2 add http client test constructors 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 10:43:24 -07:00
Meredith Lancaster
9ecd90c26c setup testing struct for test cases 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 10:24:42 -07:00
nobe4
442be87acb
Merge branch 'trunk' into fancier-extention-upgrade 2025-01-07 12:04:35 +01:00
nobe4
3b69ea6fbc
feat: make the extension upgrade fancier 
This left-pad the extension names during upgrade so they all align
nicely. It makes easier to see what is happening.
 2025-01-07 12:01:02 +01:00
Andy Feller
40984d1eb6
Merge pull request #10186 from cli/wm/clear-up-fine-grained-pats-auth-login 
Clear up --with-token fine grained PAT usage
 2025-01-06 15:24:37 -05:00
Meredith Lancaster
69865117ab add mutex for test field 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 13:14:02 -07:00
Meredith Lancaster
fb4fc7e7c2 Merge branch 'fetch-artifact-attestation-bundles-with-sas-url' of github.com:malancas/cli into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 12:58:13 -07:00
Meredith Lancaster
0202ca8df5 add test case for bundle url fetch failure 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 12:58:09 -07:00
Meredith Lancaster
b1af4b0ce3
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 12:49:27 -07:00
Meredith Lancaster
e03a36ea3c add tests for bundle url fetch and fallback 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 12:12:26 -07:00
Tyler McGoffin
1f4e005562
Merge pull request #10158 from aryanbhosale/trunk 
fix(repo fork): add non-TTY output when fork is newly created
 2025-01-06 10:11:14 -08:00
Meredith Lancaster
070b67e5a4 fetch bundles in parallel 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 10:44:55 -07:00
Meredith Lancaster
311f2b2e23 return fetch attestations err directly 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 10:39:40 -07:00
Tyler McGoffin
2358fcee83
Merge pull request #10177 from cli/cmbrose/pr-create-upstream-fix 
Handle missing upstream configs for `gh pr create`
 2025-01-06 09:32:00 -08:00
Meredith Lancaster
fc984c91d0 Merge branch 'fetch-artifact-attestation-bundles-with-sas-url' of github.com:malancas/cli into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 10:21:37 -07:00
Meredith Lancaster
9051da39fc provide additional logging and fallback 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 10:19:47 -07:00
Meredith Lancaster
706314b005
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 09:57:57 -07:00
William Martin
c3b41e87b8 Panic mustParseTrackingRef if format is incorrect 2025-01-06 10:33:28 -06:00
William Martin
8b5073d617 Move trackingRef into pr create package 2025-01-06 10:33:28 -06:00
William Martin
62ecb1c84d Make tryDetermineTrackingRef tests more respective of reality 
Though it doesn't really matter, in practice upstream is always going to come before origin.
 2025-01-06 10:33:28 -06:00
William Martin
57ba5e5608 Rework tryDetermineTrackingRef tests 2025-01-06 10:33:28 -06:00