Commit graph

214 commits

Author SHA1 Message Date
Mislav Marohnić
db88ac4155 Declare -R, --repo flag on all issue and pr subcommands 2020-06-30 18:51:53 +02:00
Mislav Marohnić
15126a71c9 Merge remote-tracking branch 'origin' into remove-global-repo-flag-for-real-this-time 2020-06-30 17:39:45 +02:00
Corey Johnson
dd8cbccbd5 Add repo flag to issue commands 2020-06-22 14:26:41 -04:00
Mislav Marohnić
4662abb312 Merge remote-tracking branch 'origin' into fix-incorrect-docs 2020-06-16 17:08:10 +02:00
Mislav Marohnić
27cce8e3ca Apply the no-args handler to issue/pr status commands 2020-06-16 16:50:34 +02:00
Mislav Marohnić
3fea249d70 💅 tweak issue/pr create examples 2020-06-16 16:43:05 +02:00
Mislav Marohnić
b838ac4014 Improve no args error handler and extend it to other commands 2020-06-15 21:01:32 +02:00
Mislav Marohnić
d583f8b5fa Merge remote-tracking branch 'origin' into issue_list 2020-06-15 20:30:34 +02:00
AliabbasMerchant
84f3d46338 Better example section in issue and pr create 2020-06-14 21:53:56 +05:30
ShubhankarKG
15ec2b748e Refactor code 2020-06-12 12:00:01 +05:30
Mislav Marohnić
73ab5810ea Merge remote-tracking branch 'origin' into doc-examples-tweaks 2020-06-11 20:32:47 +02:00
Mislav Marohnić
0dfc0f733f Fix indentation of Example blocks
In HTML, `Example` blocks seem to be already injected in fenced Markdown
blocks `` ``` ``, so they don't need to be especially intented.
2020-06-11 20:31:37 +02:00
Mislav Marohnić
e6a0c3dc28 Fix EXAMPLES sections of various commands
- Code should be intented per Markdown syntax for a code block. This
  matters when this documentation is rendered to HTML

- Fix some innaccurate usage examples

- Tweak wording, formatting in a few places
2020-06-11 18:47:57 +02:00
Corey Johnson
cde76930a1
Merge pull request #1157 from bvwells/limit
Validate pr and issue limit flag
2020-06-11 09:37:05 -07:00
Ben Wells
a89f45b1ed Validate pr and issue limit flag 2020-06-10 21:42:38 +01:00
Corey Johnson
56f1315d5f Merge remote-tracking branch 'origin/trunk' into h-e-l-p 2020-06-10 09:28:40 -07:00
ShubhankarKG
2ebc5ce514 Added examples and custom error message for space separated issues 2020-06-10 18:40:12 +05:30
Mislav Marohnić
e19ea12265 Merge remote-tracking branch 'origin' into blank-issue 2020-06-10 12:35:33 +02:00
AliabbasMerchant
4749e91c53 Use cobra Example field for issue & PR create examples 2020-06-10 09:55:19 +05:30
Corey Johnson
30d1257096 Update help output 2020-06-09 13:19:00 -07:00
AliabbasMerchant
a775562379 Added Examples for Issue and PR Create 2020-06-09 23:42:24 +05:30
Corey Johnson
8979c0ce41 Update repo 2020-06-09 09:51:18 -07:00
Corey Johnson
a6948423f4 Update issue and pr help 2020-06-09 09:33:22 -07:00
Corey Johnson
0af61bee90 Set core root commands 2020-06-09 08:49:22 -07:00
Nate Smith
bc70c52676
Merge pull request #992 from AliabbasMerchant/issue-query-params
Query Params in Web mode of Issue/PR creation
2020-06-04 14:32:38 -05:00
Mislav Marohnić
2e93a065b1 Merge remote-tracking branch 'origin/master' into api-command 2020-05-27 12:56:06 +02:00
AliabbasMerchant
5b9e64b485 Fix incorrect docs in Issue&PR create 2020-05-26 08:00:51 +05:30
AliabbasMerchant
f95b8916f3 Use url package for setting query params 2020-05-26 07:45:14 +05:30
AliabbasMerchant
42edd42da1 Undo unnecessary renames 2020-05-26 07:10:28 +05:30
AliabbasMerchant
5fc722fbb8 Query Params in Web mode of Issue/PR creation 2020-05-23 14:40:49 +05:30
AliabbasMerchant
4fd051b21d Issue/PR template selection flow mirrors that of GitHub 2020-05-23 00:25:13 +05:30
AliabbasMerchant
864d74d0b1 Categorize Templates as Legacy and NonLegacy 2020-05-23 00:03:38 +05:30
Mislav Marohnić
767521c055 Stop providing AuthLogin from context
The login name of the authenticated user will be readily available only
if authentication info comes from the config file. With other upcoming
authentication modes (for example, the GITHUB_TOKEN environment
variable), the token is the only piece of information we got, so we
would need to additionally query for the login name.

Since `issue status` and `pr status` are the only commands that need the
name of the authenticated user right now, have those commands explicitly
query for the login name. This results in an additional API query, but
simplifies Context implementation and future authentication approaches.
2020-05-20 17:09:13 +02:00
Mislav Marohnić
d8146cd16e Extract cmdutil package 2020-05-20 15:21:31 +02:00
dulltz
821324c2fb cosmetic
- Align the first letter to uppercase.
- Align with no period at the end.
2020-05-19 12:03:56 +09:00
AliabbasMerchant
6effcd4261 Allow choosing a blank issue/pr template 2020-05-18 00:37:28 +05:30
vilmibm
c8c807b954 pass apiClient to determineBaseRepo
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
2020-05-15 15:29:33 -05:00
Mislav Marohnić
1ff37be361 Fix assigning multiple user reviewers
This was due to a typo. Fixes #913
2020-05-13 17:16:12 +02:00
Mislav Marohnić
386a53c34a Fix metadata resolver query 2020-05-12 16:48:30 +02:00
Mislav Marohnić
3abc2be0f7 Switch issue create to optimized resolver and update tests 2020-05-12 16:17:06 +02:00
Mislav Marohnić
00f23b8d86 Store milestones as slice for consistency with other metadata
This is for code simplicity. Only 1 milestone per issue or PR is
allowed, like before.
2020-05-12 15:48:59 +02:00
Mislav Marohnić
1128439cd1 issue/pr create: hide "Add metadata" if viewer does not have triage permission 2020-05-08 18:37:08 +02:00
Mislav Marohnić
d7e6d21766 Order projects, teams, and labels by name 2020-05-08 18:22:14 +02:00
Mislav Marohnić
716036161b Rename titleBody (now a misnomer) to something more descriptive 2020-05-08 17:55:46 +02:00
Mislav Marohnić
72e99e9530 Merge branch 'issue-pr-create-metadata' into issue-pr-create-metadata-wizard 2020-05-08 17:46:47 +02:00
Mislav Marohnić
d0f168f4c3 Merge remote-tracking branch 'origin/master' into issue-pr-create-metadata 2020-05-08 17:46:17 +02:00
Mislav Marohnić
a7242f4ca3
Merge pull request #863 from cli/close-cmd-syntax
Tweak syntax in `issue/pr close` docs
2020-05-07 16:55:13 +02:00
Mislav Marohnić
5913a72532
Merge pull request #819 from rista404/interactive-when-defaults-807
Disable interactive mode for `issue create` if all flags are passed
2020-05-07 16:29:04 +02:00
Nikola Ristic
1f9b7c0fe0
Disable interactive only if both flags are passed
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-05-05 16:34:31 +02:00
Mislav Marohnić
1834d8cfd5 Tweak syntax in issue/pr close docs
This makes it consistent with other subcommands under `issue/pr`.
2020-05-05 13:32:42 +02:00