Forrin
c572383bda
Attestation Verification - Buffer Fix ( #9198 )
...
* swap scanner to readline for attestations
* replace readLine with readBytes
2024-06-14 13:55:58 -04:00
Andy Feller
5e7ba54b56
Merge pull request #9162 from joshuajtward/chore/GH-9038
...
feat: add `-a` flag to `gh run list`
2024-06-13 11:40:08 -04:00
Andy Feller
6190e269a0
Add gh run list tests for workflow selector
...
This commit adds tests to ensure disabled workflows are outputted as expected when called by name and the appropriate flags.
2024-06-13 11:30:38 -04:00
Wing
f647131e1d
Gracefully degrade when fetching annotations fails due to 403 ( #9113 )
...
Co-authored-by: William Martin <williammartin@github.com>
2024-06-13 14:33:06 +02:00
Josh Ward
c2f2753051
add comment to call out potentially brittle use of workflowShared
2024-06-13 09:24:18 +01:00
Phill MV
e8a13cfed3
replaced deprecated --json-result flag with --format=json in the gh at docstring.
2024-06-04 15:52:54 -04:00
Josh Ward
a10e532898
feat: add -a flag to gh run list
2024-06-03 09:53:34 +01:00
Meredith Lancaster
cd5562f5ac
Add signer-repo and signer-workflow flags to gh attestation verify ( #9137 )
...
* add signer-repo and signer-workflow flags
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add check for SignerRepo option
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add helper function and comment for clarity
Signed-off-by: Meredith Lancaster <malancas@github.com>
* update flag comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
* reference correct field
Signed-off-by: Meredith Lancaster <malancas@github.com>
* move function to more relevant file
Signed-off-by: Meredith Lancaster <malancas@github.com>
* Update pkg/cmd/attestation/verify/verify.go
Co-authored-by: Zach Steindler <steiza@github.com>
* Update pkg/cmd/attestation/verify/verify.go
Co-authored-by: Zach Steindler <steiza@github.com>
* make all reusable workflow flags mutually exclusive
Signed-off-by: Meredith Lancaster <malancas@github.com>
* accept signer workflow without host
Signed-off-by: Meredith Lancaster <malancas@github.com>
* support client optionally providing host with signer workflow flag
Signed-off-by: Meredith Lancaster <malancas@github.com>
* comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add tests for parsing signer workflow
Signed-off-by: Meredith Lancaster <malancas@github.com>
---------
Signed-off-by: Meredith Lancaster <malancas@github.com>
Co-authored-by: Zach Steindler <steiza@github.com>
2024-05-30 07:40:55 -06:00
Meredith Lancaster
8d0518645f
Add integration tests for gh attestation verify shared workflow use case ( #9107 )
...
* add initial shared workflow use case tests and test data
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add more shared workflow tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
* cleanup tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
* pr feedback, replace shared with reusable
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use demo repository with reusable workflow tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
---------
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-05-28 07:13:34 -06:00
Arne Jørgensen
08a5589abe
Add a gh variable get FOO command ( #9106 )
...
Closes #9103 .
---------
Co-authored-by: William Martin <williammartin@github.com>
2024-05-23 17:11:53 +02:00
William Martin
a66a646ca5
Add comment to pr diff regex
2024-05-23 11:59:56 +02:00
Katsuhiko Anda
e5e5c4fc43
Update regex in changedFilesNames to handle quoted paths
2024-05-23 03:13:16 +00:00
cawfeecake
105bafd2ec
fix: rename the Attempts field to Attempt; expose in gh run view and gh run ls ( #8905 )
...
Co-authored-by: William Martin <williammartin@github.com>
2024-05-22 14:39:13 +02:00
William Martin
7dc7b9838d
Merge pull request #9052 from jasonodonnell/trunk
...
Fix doc bug for gh run watch
2024-05-21 18:04:24 +02:00
Andy Feller
ff3a59802d
Merge pull request #9088 from leevic31/8535-remove-message-when-checking-for-extension-upgrades
...
Removed tty message when checking for extension upgrades
2024-05-20 08:55:52 -04:00
gabemontero
39e4cbd973
update generated content for man pages and website
2024-05-17 09:30:53 -04:00
gabemontero
77f964aa12
williammartin simplifications
2024-05-17 09:30:53 -04:00
gabemontero
c265753275
remove no-op if clause that returns 'No Aliases'
2024-05-17 09:30:53 -04:00
Andy Feller
7dd35e7470
Conditionalize references, remove redundant alias
...
This commit adds conditional logic in `gh reference` to only show aliases if
there are aliases to see. Additionally, this removes the unaliased command
name from being shown under aliases.
2024-05-17 09:30:53 -04:00
gabemontero
dd7ea5adff
list the various alias permutations for the command and subcommands
...
this occurs from either utlizing the help function for a specific command/subcommand
combination or when 'gh reference' lists the command tree
2024-05-17 09:30:53 -04:00
William Martin
3b9f9a8f59
Merge pull request #9095 from cli/wm/rework-auth-tests-with-new-credential-abstractions
...
Rework first auth tests with new gitcredential abstractions
2024-05-17 15:26:49 +02:00
William Martin
a37253746e
Remove TODO and add comment on LoginFlow tests
2024-05-17 14:51:02 +02:00
William Martin
3fe555b0bb
Comment the purpose of the helper config contract
2024-05-17 14:33:19 +02:00
William Martin
540bda1a6b
Test git credentials are configured in LoginFlow
2024-05-17 14:31:21 +02:00
William Martin
ba1afa2c5d
Add HelperConfig contract test and FakeHelperConfig
2024-05-17 14:16:14 +02:00
William Martin
3ea937d903
Inject GitCredentialFlow to LoginFlow as test seam
2024-05-17 13:26:23 +02:00
Victor Lee
6c3a461aa5
Merge branch 'trunk' into 8535-remove-message-when-checking-for-extension-upgrades
2024-05-16 15:54:46 -04:00
leevic31
222d6c8e65
Removed unused param flagDryRun from upgradeFunc
2024-05-16 15:41:47 -04:00
leevic31
e3d5c063ef
Added summary TTY message to tests
2024-05-16 15:38:49 -04:00
leevic31
1dfcaab102
Added TTY message to summarize checking extension upgrades
2024-05-16 15:31:56 -04:00
Andy Feller
e14f0d79bd
Merge pull request #9079 from cli/pr_checks_json
...
feat: add json output for `gh pr checks`
2024-05-16 13:14:16 -04:00
William Martin
3803fd04b9
Add Helper test for Windows
2024-05-16 17:01:41 +02:00
William Martin
64d50e6fbc
Add tests for gitcredentials Updater
2024-05-16 15:37:18 +02:00
William Martin
37abb3ec96
Fix mistaken git installation error check
2024-05-16 14:38:51 +02:00
William Martin
e07a26d81c
Move gitcredentials HelperConfig and add tests
2024-05-16 14:34:28 +02:00
William Martin
d75548a630
Comment the new gitcredentials package
2024-05-16 13:48:53 +02:00
William Martin
187c5016f0
Comment the git credential flow
2024-05-16 13:39:42 +02:00
William Martin
818d4ba5b8
Remove unnecessary credential setup private method
2024-05-16 13:39:42 +02:00
William Martin
c16836bcf7
Use tighter interface in setup-git
2024-05-16 13:39:42 +02:00
William Martin
177cf7d35b
Rename gitcredentials Configure to ConfigureOurs
2024-05-16 13:15:26 +02:00
William Martin
bd4ba5c39a
Make gitcredential helper smarter
2024-05-16 13:15:26 +02:00
William Martin
af589aa2f3
Move fetching configured helper into gitcredentials
2024-05-16 12:39:11 +02:00
William Martin
a3d65e0dce
Extract units for configuring and updating git credential helpers
2024-05-16 12:32:55 +02:00
leevic31
a6c0d3b0b3
removed tty message
2024-05-15 15:29:12 -04:00
Andy Feller
ac5510362b
Implement ExportData to filter json fields
...
In order to filter json fields, the `ExportData` interface needed to be implemented with logic that iterated on the selected fields.
2024-05-14 09:49:07 -04:00
nobe4
8a1995c98d
fix: rename fields list
2024-05-14 08:06:54 +02:00
nobe4
178fc2e51e
feat: add json output for PR checks
2024-05-14 07:57:38 +02:00
Andy Feller
af0288910c
Merge pull request #8987 from kuzdogan/patch-1
...
Add --latest=false to `gh release create` docs
2024-05-10 13:03:01 -04:00
William Martin
88631d13d4
Remove unnecessary config list variable
2024-05-10 10:49:07 +02:00
William Martin
07e0ff7127
Fix repo fork to use remote protocol if none configured
2024-05-10 10:48:36 +02:00
