Dylan Ancel
1eee56ec00
Add accurate context when run rerun fails ( #10774 )
...
* Add accurate context when run rerun fails
* Update tests to verify behaviour for API errors
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Use the new `httpmock.JSONErrorResponse` helper
Signed-off-by: Babak K. Shandiz <babakks@github.com>
---------
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-06-11 15:28:03 +01:00
William Martin
8baf5cc3e4
Merge pull request #11065 from cli/andyfeller/gh-pr-edit-assignees
...
Fix assignees being dropped from `gh pr edit`
2025-06-11 15:44:42 +02:00
Babak K. Shandiz
bde303dab2
test: fix test data const
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-06-10 13:57:31 +01:00
Kynan Ware
ed4b90104f
test(pr): Add tests for actor assignees
2025-06-03 14:30:19 +01:00
Andy Feller
a24d39ac87
Fix test, remove partial standalone test
2025-06-03 13:48:01 +01:00
Andy Feller
cde860be88
Iterate on pr edit problems with existing assignees
...
This commit is a handful of changes around `gh pr edit --add-assignee` behavior. Most notably, fixing a bug where the assigned actors weren't being dropped.
In addition to this, I was refactoring the testing setup to allow for individual test table scenarios could be contained.
2025-06-03 13:33:52 +01:00
William Martin
c13f2f1232
Merge pull request #11057 from cli/wm/fix-pr-edit
...
Fix pr edit when URL is provided
2025-06-02 17:44:30 +02:00
Tim Rogers
9a8031151c
Document support for @copilot in gh [pr|issue] edit --add-assignee and --remove-assignee ( #11056 )
...
* Document support for `@copilot` in `gh [pr|issue] edit --add-assignee` and `--remove-assignee`
Following up on #10991 , this updates the help text for
`issue edit` and `pr edit`'s `--add-assignee` and
`--remove-assignee` options to mention that you can use
`@copilot`.
This is already mentioned in the command-level help text, but
not at the argument level, whereas the `@me` macro is.
* Apply suggestion from @babakks
Co-authored-by: Babak K. Shandiz <babakks@github.com>
* Apply suggestion from @babakks
Co-authored-by: Babak K. Shandiz <babakks@github.com>
---------
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-06-02 16:29:35 +01:00
William Martin
793a7ff459
Fix pr edit when URL is provided
2025-06-02 15:07:55 +02:00
Andy Feller
79fc854814
Merge pull request #11030 from cli/bdehamer/release-asset-digest
...
Add Digest to ReleaseAsset struct
2025-05-29 15:11:16 -04:00
Brian DeHamer
fc6ac59bbc
fixup release asset digest tests
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-05-29 12:00:40 -07:00
Brian DeHamer
0d6b9f89a4
remove nolint comment for release header
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-05-29 11:54:44 -07:00
Brian DeHamer
7b33da981e
Update pkg/cmd/release/view/view.go
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-29 11:53:33 -07:00
Meredith Lancaster
23382f498e
Merge branch 'trunk' into gh-attestation-tuf-client-retry
2025-05-28 10:24:32 -06:00
Babak K. Shandiz
d1b82d19f9
Merge pull request #10980 from cli/babakks/improve-pr-create-docs
...
Mention `pr create` will print the created PR's URL
2025-05-28 16:43:04 +01:00
phanium
19e1178a32
fix: gh gist edit panic when no file in a gist ( #10627 )
...
* fix: `gh gist edit` panic when no file in a gist
* fix: improve error message
Signed-off-by: Babak K. Shandiz <babakks@github.com>
---------
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-05-28 14:40:14 +01:00
Babak K. Shandiz
c927ea40c3
Merge pull request #10979 from cli/babakks/improve-pr-list-docs
...
Add example usage of `--head` option to `pr list` docs
2025-05-28 14:38:17 +01:00
Babak K. Shandiz
01a1859d40
Merge pull request #11013 from cli/babakks/add-run-presentation-tests
...
Add tests for `RenderJobs` and `RenderJobsCompact`
2025-05-28 13:10:44 +01:00
Babak K. Shandiz
aa64bb5708
docs(pr list): mention --head does not support <owner>:<branch> syntax
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-28 12:55:11 +01:00
Brian DeHamer
bc93b54137
add Digest to ReleaseAsset struct
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-05-27 12:47:16 -07:00
Meredith Lancaster
f2f769c23a
Merge branch 'trunk' into gh-attestation-tuf-client-retry
2025-05-27 10:14:35 -06:00
Meredith Lancaster
a154ff5cfa
replace deprecated func
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-05-27 09:38:46 -06:00
Meredith Lancaster
dcca4b2940
replace deprecated type
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-05-27 09:34:35 -06:00
Babak K. Shandiz
bb5e10d41f
test(run): add tests for RenderJobs and RenderJobsCompact
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-23 11:00:09 +01:00
Azeem Sajid
1e6a2b1aff
Add --compact flag to run watch ( #10629 )
...
* [gh run watch] Support `--compact` flag
* [gh run watch] Support `--compact` flag
* Add changes for updated AC
* Incorporate review changes
* docs(run watch): fill up the line to 80 chars
Signed-off-by: Babak K. Shandiz <babakks@github.com>
---------
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-05-23 10:55:41 +01:00
Kynan Ware
ca46b56456
Merge pull request #11003 from cli/kw-bks/enclose-config-options-in-code-blocks
...
Fix formatting in allowed values for `gh config --help`
2025-05-22 10:14:14 -06:00
Kynan Ware
ace4dc6c72
Merge pull request #11004 from cli/revert-10371-10348-escape-pipe-in-long-description-for-website-manual
...
Revert "[gh config] Escape pipe symbol in Long desc for website manual"
2025-05-22 10:12:21 -06:00
Babak K. Shandiz
960aadf2b9
test: improve test case naming
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-22 17:04:04 +01:00
Babak K. Shandiz
53d589223b
test: ensure proper usage of pipes in docs
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-21 12:17:05 +01:00
Kynan Ware
a04dc73e5d
Merge pull request #10745 from cli/kw/preview-prompter-command
...
Add `preview prompter` command
2025-05-20 13:13:42 -06:00
Kynan Ware
944543863a
Revert "[gh config] Escape pipe symbol in Long desc for website manual"
2025-05-20 08:54:30 -06:00
Kynan Ware
b639d6d514
doc(pr): format allowed values and defaults in help
2025-05-20 08:37:01 -06:00
Kynan Ware
53d0d5d192
fix(editable): include DefaultLogins in EditableAssignees clone
2025-05-16 12:54:01 -06:00
Kynan Ware
6f1906073f
doc(params): incorrect func name in comment
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-05-16 12:51:09 -06:00
Kynan Ware
d932934119
Merge branch 'trunk' into kw/gh-cli-epic-900-actors-are-assignable
2025-05-16 12:49:52 -06:00
Kynan Ware
a28e2d8784
refactor(api): use constant for Copilot login
2025-05-16 12:28:46 -06:00
Kynan Ware
3a8cdda148
Merge pull request #10991 from cli/kw/gh-cli-917-special-actor-assignee-names-noninteractive
...
`issue edit`, `pr edit`: Support special non-interactive (flags) assignee name `@copilot`
2025-05-16 12:19:43 -06:00
Kynan Ware
748afb6e85
doc(issue/pr edit): clarify @copilot usage
2025-05-16 12:18:23 -06:00
Kynan Ware
475163a126
Merge pull request #10990 from cli/kw/gh-cli-916-special-actor-assignee-names
...
`issue edit`, `pr edit`: handle display names in interactive assignee editing
2025-05-16 10:16:08 -06:00
Kynan Ware
532aa1c32a
doc(issue/pr edit): doc @copilot assignee
2025-05-16 09:55:17 -06:00
Kynan Ware
debf0bbaf2
test(params): enhance Copilot replacer tests for edge cases
...
- Added tests for handling nil and empty slices in the Copilot replacer.
- Simplified test structure by removing unnecessary wantErr field.
2025-05-16 09:50:24 -06:00
Kynan Ware
871671be52
fix(params): remove needless err return
2025-05-16 09:40:29 -06:00
Kynan Ware
c5f2d7bde7
doc(editable): remove needless comment
2025-05-16 09:37:20 -06:00
Kynan Ware
a22a1bbde4
test(editable): prompts use assignee display names
2025-05-16 09:20:58 -06:00
Kynan Ware
ec7c8ed844
test(pr edit): fix typo in test name
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-15 13:41:38 -06:00
Kynan Ware
f6bb1ca756
refactor(pr edit): move httpclient initialization
2025-05-15 13:40:23 -06:00
Kynan Ware
375c6cd28f
feat(issue/pr edit): support @copilot in assignee flags
...
- Introduced CopilotReplacer to handle `@copilot` mentions in assignee lists.
2025-05-15 12:50:03 -06:00
Kynan Ware
51b1e6cd6f
Merge branch 'kw/gh-cli-909-911-assign-actors-to-prs' into kw/gh-cli-916-special-actor-assignee-names
2025-05-15 11:27:14 -06:00
Kynan Ware
52b6ebff9c
doc(pr edit): Add comments describing the use of DefaultLogins
2025-05-15 10:52:31 -06:00
Kynan Ware
9a5ea87d75
fix(issues): fix non-interactive assignee matching to logins&IDs
2025-05-15 09:56:35 -06:00