Mislav Marohnić
70412ef06a
Add trailing newline
2020-10-02 17:48:40 +02:00
Mislav Marohnić
2376c81460
Fix scoop-gen
2020-10-02 17:48:34 +02:00
Mislav Marohnić
7663acdc29
Improve HTTP caching layer
...
- make thread-safe
- only cache GET, HEAD, and GraphQL requests
- only cache non-5xx, non-403 responses
- include `Accept` and `Authorization` headers in cache key
2020-10-02 15:19:40 +02:00
Mislav Marohnić
f7a82a216b
Avoid error from cache file being prematurely closed
...
I have no idea what's going on there, so I'll just give up the streaming
approach and read the entire contents of the cache file to memory.
https://github.com/cli/cli/pull/2035/checks?check_run_id=1194798056
2020-10-01 22:06:15 +02:00
Mislav Marohnić
49909b5123
Tweak gh auth login examples
2020-10-01 19:56:56 +02:00
Mislav Marohnić
cc2b86f3a6
Specify minimum required token scopes in gh help auth login
2020-10-01 19:56:33 +02:00
Mislav Marohnić
1d435a3e2e
Ensure that cache file is closed after reading
2020-10-01 19:18:11 +02:00
Mislav Marohnić
419566345b
Fix bumping the Homebrew formula
...
The gh formula in homebrew-core went back and forth between git-style
and tarball-style. Now that it's back to tarball, update the action to
reflect that.
2020-10-01 19:10:30 +02:00
Mislav Marohnić
4bf2e513c7
Use default token for Goreleaser action
...
Now that Goreleaser doesn't need to update any external repositories, we
can use the default generated GITHUB_TOKEN for releases.
2020-10-01 19:09:46 +02:00
Mislav Marohnić
0a17259e3c
Bump scoop bucket manually on release
...
Goreleaser can no longer do this for us since we're always creating a
draft release initially.
2020-10-01 19:09:14 +02:00
Mislav Marohnić
61609db9ef
Cover HTTP 402 in oauth tests
2020-10-01 17:21:35 +02:00
Mislav Marohnić
93642529da
Enforce correct content-type in Device Flow detection
2020-10-01 17:09:47 +02:00
Mislav Marohnić
5f8648159d
Fix handling of HTTP 403 in Device Flow detection
2020-10-01 17:09:14 +02:00
Mislav Marohnić
93c8fc1e98
Add tests for GraphQL introspection
2020-10-01 16:33:56 +02:00
Nate Smith
72eeae9d1d
Update CONTRIBUTING.md
2020-09-30 17:17:58 -05:00
Mislav Marohnić
0ef2863ede
Cache GHE responses for schema queries
...
This speeds up `pr`-related commands for GHE by caching schema
introspection queries for 24h.
2020-09-30 19:09:15 +02:00
Mislav Marohnić
ff925fb480
Resolve @me to current username on GHE
...
It looks like GHE v2.20 does not support `@me` in search yet.
2020-09-30 19:05:06 +02:00
Mislav Marohnić
bed9d11f7a
Avoid querying statusCheckRollup or reviewDecision on unsupported GHE
...
We first ask the GHE server for whether it supports these fields.
2020-09-30 19:04:09 +02:00
Martín Montes
2a166d1dd7
Using TrimPrefix for getting current branch and improved tests
2020-09-30 18:26:22 +02:00
Nate Smith
a358bb73db
Merge pull request #1969 from buck10/trunk
...
Fix links to files in the docs directory
2020-09-30 11:09:20 -05:00
Cristian Dominguez
c6b9e8454f
Update gist edit tests
2020-09-30 12:35:22 -03:00
Cristian Dominguez
67c0a1a409
Check gist ownership before editing
2020-09-30 12:35:04 -03:00
Harsh Shandilya
0107b00043
Don't override user provided title and body when --fill is used ( #1994 )
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-30 16:15:30 +02:00
Martín Montes
3ef1693881
Using symbolic-ref for getting branch and parsing its output
2020-09-30 13:44:16 +02:00
Sam
091d550cde
Merge pull request #2005 from cli/small-refactors
...
Small readability and code organization refactors
2020-09-30 13:05:17 +02:00
Sam Coe
74d6eb96be
Address PR comments
2020-09-30 12:55:05 +02:00
Sam Coe
bda27a46ae
Extract version command
2020-09-30 12:49:17 +02:00
Sam Coe
1a1a6303cd
Move disable auth check to bottom
2020-09-30 12:49:17 +02:00
Sam Coe
53a97c3414
Extract rootFlagErrrorFunc into root help
2020-09-30 12:49:17 +02:00
Sam Coe
f00a0f2854
Move completion command out of root package
2020-09-30 12:49:17 +02:00
Sam Coe
c52fc72291
Extract bareHTTPClient function
2020-09-30 12:49:14 +02:00
Mislav Marohnić
ab863adae3
Merge pull request #2021 from tgyurci/cat-pager
...
Disable pager when set to "cat"
2020-09-30 11:09:10 +02:00
Teubel György
9b2fe1ee30
Disable pager when set to "cat"
2020-09-29 23:21:59 +02:00
Martín Montes
0e2e97af68
Using git branch --show-current for getting the current branch. Fallback to symbolic-ref
2020-09-29 22:45:32 +02:00
Nate Smith
e24035681d
Merge pull request #2003 from cristiand391/refactor-gist-create
...
Refactor gist create to reuse existing structs
2020-09-29 15:27:31 -05:00
Nate Smith
127d0b8717
Merge pull request #2020 from tgyurci/gh-pager-env
...
Add support for GH_PAGER
2020-09-29 14:52:58 -05:00
Nate Smith
b987cfb39e
Merge pull request #1955 from thealamu/trunk
...
Avoid interface for collecting file descriptors
2020-09-29 11:37:33 -05:00
Nate Smith
aa72881baa
Merge pull request #1962 from ricardoseriani/change-default-answer-after-delete-branch
...
Set default answer to "no" for "deleting branch after merge" question
2020-09-29 11:29:41 -05:00
Nate Smith
cc6a7887ab
Merge pull request #2022 from cli/contrib
...
mention new core label in contributing docs
2020-09-29 11:00:28 -05:00
vilmibm
91fcfa548f
Sentence Case.
2020-09-29 11:00:12 -05:00
vilmibm
746ab7354a
mention new core label in contributing docs
2020-09-29 10:47:51 -05:00
Teubel György
b71261219c
Add support for GH_PAGER
2020-09-29 17:42:25 +02:00
Nate Smith
3c6e355a1c
Merge pull request #1967 from aldahick/fix/repo-garden-few-commits
...
Fix some bugs in `repo garden` in repositories with few commits
2020-09-29 10:27:10 -05:00
Pranjal Mittal
3a9b9de940
Modification of help text for usage of gh pr checks ( #1915 )
2020-09-29 11:25:02 +02:00
Mislav Marohnić
c11ff0005a
Merge pull request #1926 from cli/pr-create-branch-pushed-fix
...
Fix `pr create` when branch was already pushed to a non-base remote
2020-09-28 19:12:38 +02:00
Sam
1b029c766d
Merge pull request #1917 from cli/fix-pager-glamour-bug
...
Check for terminal background color before starting pager
2020-09-28 11:05:39 +02:00
Sam Coe
f132161cc4
Upgrade termenv
2020-09-28 10:57:25 +02:00
Cristian Dominguez
b71e6494ab
Update gist create tests
2020-09-28 02:37:41 -03:00
Cristian Dominguez
ef8f61c61d
Refactor gist create
2020-09-28 02:36:01 -03:00
Jeremy Coghill
123f469e58
Fix links to files in the docs directory
2020-09-25 20:49:53 -04:00