Commit graph

3192 commits

Author SHA1 Message Date
Mislav Marohnić
eb4439d781
Merge pull request #5698 from cli/deprecation-stderr
Write Cobra deprecation messages to stderr
2022-05-24 12:36:18 +02:00
Heath Stewart
b54ff58382
Parallelize label clone (#5687) 2022-05-24 10:04:05 +02:00
Heath Stewart
be4b392530 Use alternate screen buffer for watching runs
Resolves #5679
2022-05-23 22:18:11 -07:00
Mislav Marohnić
2139e763fb Write Cobra deprecation messages to stderr
We used to do the equivalent of `rootCmd.SetOut(os.Stdout)` because we
thought that Cobra's "Out" stream represents standard output. However,
upon closer inspection it turns out that this is Cobra's stream for
usage errors and deprecation warnings, and those we want written to
stderr as well. It is not clear to me why Cobra maintains a distinction
between "Out" and "Err" streams since both seem to go to sdterr by
default.

This change also ceases our usage of `command.Print()` functions in
favor of explicitly writing to `IOStreams.Out/ErrOut`.
2022-05-23 20:23:42 +02:00
Josh Soref
7d99a98f02 Clarify that ShowResponseHeaders includes status line 2022-05-23 10:18:50 -04:00
Sam Coe
ebbf2ac096
Fix owner qualifier for search queries (#5693) 2022-05-23 13:00:32 +00:00
ffalor
3fb8579419
Add --pattern field to run download (#5539) 2022-05-23 08:57:57 +00:00
ffalor
2918c538b3
add include-all-branches flag to repo create (#5537) 2022-05-23 10:11:55 +02:00
Andrew Senetar
ff8aa8a555
Add ability to set title for ssh key in auth login (#5524) 2022-05-23 08:06:42 +00:00
Heath Stewart
3574240fa7
Always clear screen when watching PR checks (#5678) 2022-05-23 08:38:50 +02:00
Heath Stewart
f834b2a510
Fix label clone to pass orderBy (#5675) 2022-05-23 08:32:11 +02:00
Mislav Marohnić
4d9a6ecb25 pr create: ensure clear error when --body is missing in nonTTY mode 2022-05-18 19:13:59 +02:00
Sam Coe
63a3adf212
Use strings.Cut 2022-05-18 08:42:14 +02:00
Sam Coe
c89d8cb759
Backport strings.Cut 2022-05-18 08:40:30 +02:00
Sam Coe
22a5d2abf8
Refactor code to live inside default pkg 2022-05-18 08:40:30 +02:00
bchadwic
9060b44e6d
default lint fix 2022-05-18 08:40:30 +02:00
bchadwic
e5ebbcb66a
lint test update 2022-05-18 08:40:29 +02:00
bchadwic
66a69bdec5
fixing lint and formatting 2022-05-18 08:40:29 +02:00
bchadwic
86658513b1
Created more test cases, added in env section 2022-05-18 08:40:29 +02:00
bchadwic
08b02da3fc
beginning testing 2022-05-18 08:40:29 +02:00
Benjamin Chadwick
a140bea9bf
deleted scratch pad of commit 2022-05-18 08:40:29 +02:00
bchadwic
ca5e9a49b5
thinking of a better solution, wip. BaseRepo() might be better split up 2022-05-18 08:40:29 +02:00
bchadwic
a98395f4e8
headed in the right direction. Needs tests and to be cleaned up. This is a working example of the teams design combined with https://github.com/cli/cli/pull/4859#issuecomment-1012776582 2022-05-18 08:40:29 +02:00
bchadwic
38097e8cad
created gh config base a way to configure the base repo 2022-05-18 08:40:28 +02:00
Heath Stewart
00e97121ec
Allow passing full extension name (#5464) 2022-05-18 08:35:47 +02:00
Curtis Tarr
bec49152cf
Fixing #5624 - Removing unneeded hint and additional new line (#5642) 2022-05-18 08:32:00 +02:00
Sam Coe
539b150833
Extract feature detection package (#5494) 2022-05-17 19:07:44 +00:00
Mark Phelps
669b0fa981 dont need assignment 2022-05-17 13:36:15 +00:00
Mark Phelps
48bb894277 filter out internal ports from gh cs ports list 2022-05-16 12:40:24 -07:00
Mislav Marohnić
c9503df123
Allow nil to truncate template function (#5656)
Fixes #5643
2022-05-16 19:05:17 +02:00
Josh Gross
b00bfce9cc
Support rerunning Actions runs with debug logging (#5594) 2022-05-16 19:01:53 +02:00
Heath Stewart
d9323c6d56 Allow nil to truncate template function
Fixes #5643
2022-05-16 08:58:20 -07:00
Josh Soref
104d7655d7
Support and favor delete for secrets (#5617)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-16 12:24:05 +00:00
Sam Coe
60ea13b39e
Fix whitespace in search prs examples (#5650) 2022-05-16 10:35:27 +02:00
Sam Coe
74f0feec8b
Fix struct field tag (#5649) 2022-05-16 10:14:19 +02:00
Sam Coe
d244346960
Replace uses of strings.Title (#5623) 2022-05-12 13:52:21 +00:00
colby thomas
02357c0063
Removing confusing user search text (#5620) 2022-05-12 08:48:22 +00:00
Greggory Rothmeier
a0a9099037
Hide retention-period flag (#5607)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-10 19:49:55 +02:00
Greggory Rothmeier
06153770a9
Merge pull request #5504 from greggroth/gregg/retention-period
Add support for setting codespace retention-period
2022-05-10 18:21:55 +02:00
Dan Halbert
51d18d95f1
repo clone: document the upstream remote (#5466)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-10 18:12:59 +02:00
Mislav Marohnić
c26ff6ac9a
Merge pull request #5605 from cannist/cannist/fix-npe
Fix nil pointer exception in codespace selection
2022-05-10 18:11:10 +02:00
Mislav Marohnić
8c5103aefa
Merge pull request #5595 from ffalor/exclude_drafts
Add `exclude-drafts` flag to `gh release list`
2022-05-10 18:10:15 +02:00
Hirad Pourtahmasbi
bbaf010303
repo list: add --visibility internal filter (#5564)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-10 15:39:53 +00:00
Thomas Horstmeyer
d9d3d7ba8e Fix nil pointer exception in codespace selection 2022-05-10 16:27:25 +01:00
Mislav Marohnić
5cb4e4d862
Merge pull request #5570 from koskeller/submit-as-draft-option-pr-create
pr create: add "Submit as draft" interactive option
2022-05-10 17:17:07 +02:00
Mislav Marohnić
cf92705d4c pr create: default to "Submit as draft" when --draft was used 2022-05-10 17:09:40 +02:00
Mislav Marohnić
c8baec74c0 Ensure stable presentation of FORBIDDEN errors 2022-05-10 16:07:57 +02:00
Mislav Marohnić
d103ba251a 💅 optimize fetches 2022-05-10 15:44:55 +02:00
Heath Stewart
fc4cd12cbf Ignore FORBIDDEN errors for gh status
Fixes #5587
2022-05-10 15:44:55 +02:00
Mislav Marohnić
78ae6f85c6
Merge pull request #5583 from ffalor/gh_status
status: exclude results from archived repositories
2022-05-10 11:51:20 +02:00