Commit graph

1137 commits

Author SHA1 Message Date
vilmibm
35f18b6c02 gh auth login 2020-08-06 12:43:35 -05:00
Mislav Marohnić
a73584db72 Merge remote-tracking branch 'origin' into pr-commands-isolate 2020-08-04 15:01:30 +02:00
Mislav Marohnić
2ab06ab4d6
Merge pull request #1415 from cli/ghe-api
Add GHE compatibility to the API adapter
2020-08-03 17:19:20 +02:00
Shubhankar Kanchan Gupta
bb6851c88b
Add "open" qualifier when listing open issues/PRs (#1457) 2020-07-31 18:22:08 +02:00
Mislav Marohnić
604799735c 🔥 unused errorStub struct 2020-07-29 22:54:37 +02:00
Mislav Marohnić
487dd06bf3 Isolate pr checkout command 2020-07-29 22:50:34 +02:00
Mislav Marohnić
af68a749f0 Isolate pr diff command 2020-07-29 22:49:50 +02:00
Mislav Marohnić
12637d02d6 Isolate pr review command 2020-07-29 19:35:54 +02:00
Mislav Marohnić
3c32a8441a Extract PR lookup into shared package 2020-07-29 19:35:03 +02:00
Mislav Marohnić
da2292723b Merge remote-tracking branch 'origin' into ghe-api 2020-07-29 16:49:16 +02:00
Nate Smith
43318fd8e8
Merge pull request #1436 from cli/move-ask-stubber
move survey helper and test helpers to prompt pkg
2020-07-28 11:49:19 -05:00
Mislav Marohnić
c0b116b511 Merge remote-tracking branch 'origin' into ghe-api 2020-07-28 18:12:47 +02:00
Nate Smith
f486cc4823
Merge pull request #1435 from cli/repo-cleanup
final isolation repo cleanup
2020-07-28 10:54:09 -05:00
Mislav Marohnić
07eb1e7592 Document GLAMOUR_STYLE support 2020-07-28 15:24:41 +02:00
vilmibm
245c3c7425 move survey helper and test helpers to prompt pkg 2020-07-27 17:00:09 -05:00
vilmibm
29f4453e07 final repo command cleanup 2020-07-27 14:09:07 -05:00
vilmibm
9359dcaf80 isolate credits 2020-07-27 13:56:15 -05:00
Mislav Marohnić
dd0d236629 Merge remote-tracking branch 'origin' into ghe-api 2020-07-27 20:13:54 +02:00
vilmibm
f3eb092d7e isolate repo fork command and tweak usage
This commit is another isolation refactor, this time for repo fork.
However, I got fed up with the --remote="true|false|prompt" style of
flags and took this opportunity to switch to a set of bool flags:

--remote and --clone
--no-remote and --no-clone

the string args were really non standard and confusing; with only two
bools it was impossible to tell when to prompt.
2020-07-27 13:04:31 -05:00
vilmibm
dadcf4ba96 add prompt.StubConfirm 2020-07-27 10:00:19 -05:00
Mislav Marohnić
0cbcf8a7fa Merge remote-tracking branch 'origin' into ghe-api 2020-07-27 16:30:20 +02:00
vilmibm
c34054bdc8 isolate repo create command 2020-07-24 12:26:27 -05:00
vilmibm
cc862d03e7 remove dead code 2020-07-23 16:43:16 -05:00
vilmibm
1831d95433 isolated clone command
This commit hacks the existing repo clone tests into something usable by
the new isolated command. It went ok and was less effort than trying to
introduce the same kind of test format as repo view and gist create.
2020-07-23 16:40:31 -05:00
Mislav Marohnić
288d01318b Respect the hostname of current repository in queries 2020-07-23 22:31:08 +02:00
vilmibm
b9ce1a1daf pass resolving baserepo into newcmdview 2020-07-23 15:13:23 -05:00
vilmibm
d92c80b560 just swap BaseRepo implementation 2020-07-23 11:58:22 -05:00
vilmibm
086fb48d31 move displayURL 2020-07-23 11:25:31 -05:00
vilmibm
70c948a751 move isURL 2020-07-23 11:23:45 -05:00
vilmibm
dc02366128 move generateRepoURL to ghrepo 2020-07-23 11:16:47 -05:00
vilmibm
2a99ed9afb add ResolvedBaseRepo 2020-07-23 11:01:29 -05:00
vilmibm
a27c8a9c21 isolate repo view cmd 2020-07-22 15:54:11 -05:00
Mislav Marohnić
97350e87a1 Merge remote-tracking branch 'origin' into migrate-gist 2020-07-22 16:17:30 +02:00
vilmibm
c06eacf4ee remove obsolete ensureScopes 2020-07-21 17:42:52 -05:00
vilmibm
eb204c0dee scriptability improvements for repo commands 2020-07-21 14:17:25 -05:00
Nate Smith
71bebd3f54
Merge pull request #1403 from cli/readme-markdown
Report HTTP and Markdown errors in `repo view`
2020-07-21 11:53:29 -05:00
Nate Smith
739d66b2d2
Merge pull request #1373 from cli/pr-scriptability
pr command scriptability improvements
2020-07-21 11:51:39 -05:00
vilmibm
1137e40a1f use colorableErr 2020-07-21 11:46:51 -05:00
Mislav Marohnić
e373195817 WIP migrate gist create to separate package 2020-07-21 18:13:16 +02:00
Mislav Marohnić
71b13a81d0 Correctly report HTTP and Markdown errors in repo view
Any errors from fetching and rendering the README were silenced and
ignored in `repo view`. This change:

- Tolerates HTTP 404, but will raise exceptions for any other error;
- Moves markdown rendering from `api` package to command implementation;
- Ensures markdown rendering errors are correctly reported.
2020-07-21 13:47:27 +02:00
Mislav Marohnić
6a48a604f0
Merge pull request #1383 from cli/gist-create-stdin
Fix creating gists from stdin with argument
2020-07-21 11:37:35 +02:00
vilmibm
fa928489b6 collapse open/draft state 2020-07-20 15:55:40 -05:00
vilmibm
f30f931695 fix tests 2020-07-20 15:55:37 -05:00
vilmibm
bffcbce716 restore nontty + web but suppress informational prints 2020-07-20 13:04:17 -05:00
vilmibm
168bd33bc9 pr command scriptability improvements
This commit improves behavior and error handling for pr commands when
run unattached to a tty.

- error if pr create and no -t/-f
- error if pr create and -w
- machine readable pr list
- machine readable pr view
- various cleanup of informational messages
2020-07-20 13:04:17 -05:00
vilmibm
2dd42eb9aa minor alias scriptability changes 2020-07-20 11:10:34 -05:00
vilmibm
b7765591b7 remove package level terminal check state 2020-07-17 15:02:05 -05:00
Mislav Marohnić
1545674d5c 💅 Tweak --public flag description
Trying to generally avoid "when true" in descriptions of boolean flags
2020-07-17 19:13:14 +02:00
Mislav Marohnić
a1a3e2d7bf Pass FlagError by reference 2020-07-17 19:11:53 +02:00
Mislav Marohnić
d90c387e04 Update gist create test
- use testify
- verify that the HTTP request is a POST to `/gists`
- more precise POST params matching in assertion
2020-07-17 18:24:34 +02:00