Commit graph

263 commits

Author SHA1 Message Date
Jose Garcia
da58313358 Remove redudant type def 2021-09-17 14:03:31 -04:00
Jose Garcia
9f84015bd0 Avoid append 2021-09-17 14:00:16 -04:00
Jose Garcia
65e1c6f789 More test cases 2021-09-17 13:56:38 -04:00
Jose Garcia
76037ee753 Update docs, simplify loop to append to command 2021-09-17 13:54:00 -04:00
Jose Garcia
54265afda0 PR Feedback
- use named returns
- handle command flags + test case
- simplify tests
2021-09-17 13:43:23 -04:00
Jose Garcia
60d066f0a6 PR Feedback
- return nil for slices
- handle `-L -l` case
- document `parseSSHArgs`
2021-09-17 11:51:37 -04:00
Jose Garcia
42e47a98d7 add docs, simplify map, error on invalid args 2021-09-16 15:22:47 -04:00
Jose Garcia
8a0f8b6d1c parse ssh args and command 2021-09-16 10:32:27 -04:00
Jose Garcia
514448dde8 Merge branch 'main' of github.com:github/ghcs into jg/ssh-cmd-flags 2021-09-15 15:45:53 -04:00
Jose Garcia
10ad85486f Merge pull request #154 from github/jg/fix-ctx-error
ghcs create/ssh: fix ctx cancellation errors & fix todo for X11 forwarding
2021-09-15 15:45:35 -04:00
Jose Garcia
45a9715e9f Merge pull request #158 from github/jg/go-liveshare-0.16.0
upgrade to go-liveshare 0.16.0
2021-09-15 15:40:58 -04:00
Jose Garcia
b2234969e4 update logs 2021-09-15 15:40:07 -04:00
Alan Donovan
eafadd3757 Merge pull request #156 from github/api-internal
move api to internal/api
2021-09-15 15:38:11 -04:00
Jose Garcia
c5bd8c4127 initial spike to accept args 2021-09-15 15:37:37 -04:00
Jose Garcia
26d3199082 add back codespaces.Shell 2021-09-15 15:18:54 -04:00
Jose Garcia
ecd0c70567 upgrade to go-liveshare 0.16.0 2021-09-15 15:15:28 -04:00
Jose Garcia
0f72e3d886 defer stopPolling and docs 2021-09-15 14:29:16 -04:00
Alan Donovan
06719866c9 move api to internal/ 2021-09-15 13:13:10 -04:00
Jose Garcia
547c629220 fix ctx cancellation errors & fix todo for X11 forwarding 2021-09-15 10:38:19 -04:00
Jose Garcia
3abde5f0c5 Merge pull request #148 from github/jg/remove-deprecation-msg
remove all deprecation messages and deprecated functionality
2021-09-13 14:44:40 -04:00
Jose Garcia
f5adc9e3a7 remove all deprecation messages and deprecated functionality 2021-09-13 10:58:00 -04:00
Alan Donovan
a5b985523c Merge pull request #147 from github/tty-windows
Don't assume stdin/stdout fds are 0/1 on windows
2021-09-13 09:30:39 -04:00
Alan Donovan
c4be0a0e28 this time without compile errors 2021-09-13 09:29:46 -04:00
Issy Long
74a4afcd77 Merge pull request #139 from github/fix-version-string
goreleaser: Fix version string replacement
2021-09-13 10:32:19 +01:00
Alan Donovan
1526ab5bff fix URL 2021-09-10 18:08:48 -04:00
Alan Donovan
af301bfff1 stdin/stdout fds are not 0/1 on windows 2021-09-10 17:36:20 -04:00
Jose Garcia
3ca3dd05a1 Merge pull request #143 from github/jg/ssh-flags
ghcs ssh: make flag description consistent
2021-09-10 16:04:09 -04:00
Jose Garcia
ad600d22ed merge upstream 2021-09-10 16:03:09 -04:00
Alan Donovan
8b06ffe2bd Merge pull request #145 from github/remove-script
Remove go-ghcs-crypto vendor script
2021-09-10 15:48:40 -04:00
Jose Garcia
6c907869ff Merge pull request #144 from github/jg/remove-terminal
ghcs ssh: remove terminal, bash_profile setup
2021-09-10 15:06:18 -04:00
Jose Garcia
798075045e remove terminal, bash_profile setup 2021-09-10 14:58:47 -04:00
Jose Garcia
31e1d974aa Merge pull request #142 from github/jg/delete-flags
ghcs delete: deprecate argument/subcommands & introduce flags
2021-09-10 14:17:44 -04:00
Alan Donovan
2fe71e3576 Merge pull request #138 from github/sigint-delay
Wait forever for SIGINT delivery
2021-09-10 14:15:36 -04:00
Jose Garcia
34e52ba24a deprecate subcommands 2021-09-10 14:11:50 -04:00
Alan Donovan
9b1ed00ae3 Merge pull request #140 from github/crypto
fork go-ghcs-crypto repo into internal module
2021-09-10 14:11:27 -04:00
Jose Garcia
28ab023b07 Merge pull request #133 from github/jg/ports-flags
ghcs ports: deprecate codespace arg, introduce global flag
2021-09-10 13:33:26 -04:00
Jose Garcia
9b9e533cb9 add comment for special handling 2021-09-10 13:32:30 -04:00
Alan Donovan
efb2569d2b move vendored go-ghcs-crypto to internal module 2021-09-10 12:29:25 -04:00
Issy Long
810c127608 goreleaser: Fix version string replacement
- The `Version` variable casing changed in 6a4950cf7a (diff-d897a31624bae4fe935e8dc2243f41626c68639be6643535297c06935277ffb4), so we need to update our version setting code.
- Otherwise, for `ghcs 0.11.0`, `ghcs --version` would print "DEV".
2021-09-10 16:17:37 +01:00
Alan Donovan
4f6cab195a wait for sigint delivery 2021-09-10 10:08:54 -04:00
Jose Garcia
219a22ef12 Merge pull request #137 from github/jg/liveshare-0.15.0
go-liveshare 0.15.0
2021-09-10 08:35:15 -04:00
Alan Donovan
c06d56fa20 Merge pull request #136 from github/sigint
deliver SIGINT to self after Ctrl-C in survey
2021-09-09 18:10:09 -04:00
Jose Garcia
fe2d5ebf37 merge upstream + pr feedback 2021-09-09 17:22:07 -04:00
Alan Donovan
0afdcdec84 Merge pull request #126 from github/lightstep
ghcs: add --lightstep flag for tracing
2021-09-09 16:41:38 -04:00
Alan Donovan
2cbe120774 return err, don"t fatal 2021-09-09 16:39:41 -04:00
Alan Donovan
22f9824ec8 deliver SIGINT to self after Ctrl-C in survey 2021-09-09 16:33:39 -04:00
Alan Donovan
ee44ecc944 include span context in HTTP request 2021-09-09 13:42:44 -04:00
Alan Donovan
af541ad5f2 Merge pull request #132 from github/ask-tty
consolidate survey functions
2021-09-09 12:43:00 -04:00
Jose Garcia
81f08e7baf start converting to flags 2021-09-09 12:08:07 -04:00
Alan Donovan
b96341a5f9 Merge branch 'main' into ask-tty 2021-09-09 12:01:55 -04:00