Commit graph

1434 commits

Author SHA1 Message Date
vilmibm
da95cbd1bf use gh if available when cloning site 2020-05-18 14:05:50 -05:00
vilmibm
296062b869 configure author on site commits 2020-05-18 14:01:35 -05:00
Mislav Marohnić
4d11732a47
Merge pull request #943 from cli/reauth-bug
pass apiClient to determineBaseRepo
2020-05-18 13:16:07 +02:00
Kevin Bluer
d440a95aed
Improved error message when "owner/repo" format not provided (#919)
Fixes #882
2020-05-18 11:13:48 +02:00
vilmibm
c8c807b954 pass apiClient to determineBaseRepo
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
2020-05-15 15:29:33 -05:00
Nate Smith
c115d32b74
Merge pull request #923 from cli/install-source
Change source installation docs to avoid suggesting to change PATH
2020-05-14 13:36:05 -05:00
Mislav Marohnić
e3676c3a95 Change source installation docs to avoid suggesting to change PATH 2020-05-14 18:32:57 +02:00
Mislav Marohnić
e28e6097ce
Merge pull request #891 from victorhsn/master
add description default private for repo create
2020-05-13 21:03:59 +02:00
Mislav Marohnić
9acaca90e2
Merge pull request #908 from cli/issue-metadata-resolve-ids
Faster resolve assignees, reviewers, labels on create via flags
2020-05-13 17:28:55 +02:00
Mislav Marohnić
57e60ab8a1 Merge remote-tracking branch 'origin/master' into issue-metadata-resolve-ids 2020-05-13 17:20:37 +02:00
Mislav Marohnić
1ff37be361 Fix assigning multiple user reviewers
This was due to a typo. Fixes #913
2020-05-13 17:16:12 +02:00
Nate Smith
3552bca596
Merge pull request #912 from cli/pr-create-codeowners-fix
Preserve CODEOWNERS reviewers in `pr create`
2020-05-13 10:05:10 -05:00
Mislav Marohnić
c225d379a9 Preserve CODEOWNERS reviewers in pr create
When reviewers were requested on a PR, they would apparently
overwrite the current set of reviewers. A fresh PR will already have
reviewers if it was assigned some by CODEOWNERS rules.

The fix is to only ever add additional reviewers and not overwrite the
entire set.
2020-05-13 12:09:59 +02:00
Corey Johnson
ad3a5903b2
Merge pull request #873 from cli/the-merge-dubai
Add support for `gh pr merge`
2020-05-12 10:18:54 -07:00
Mislav Marohnić
b75c4a812d Guard against leaked parameters in issue/pr create tests 2020-05-12 16:54:54 +02:00
Mislav Marohnić
386a53c34a Fix metadata resolver query 2020-05-12 16:48:30 +02:00
Mislav Marohnić
3abc2be0f7 Switch issue create to optimized resolver and update tests 2020-05-12 16:17:06 +02:00
Mislav Marohnić
00f23b8d86 Store milestones as slice for consistency with other metadata
This is for code simplicity. Only 1 milestone per issue or PR is
allowed, like before.
2020-05-12 15:48:59 +02:00
Mislav Marohnić
6d57f2a91e Faster resolve GraphQL node IDs for assignees, reviewers, and labels 2020-05-12 15:33:51 +02:00
Nate Smith
37fd2a7fc1
Merge pull request #903 from cli/huh
tyop fix + stricter switch
2020-05-11 17:46:49 -05:00
vilmibm
79ad1ed5d3 tyop fix + stricter switch 2020-05-11 17:39:52 -05:00
Nate Smith
a7bcfffdd3
Merge pull request #885 from cli/survey-review
light interactive pr review
2020-05-11 17:18:16 -05:00
vilmibm
7009321314 review feedback 2020-05-11 17:06:18 -05:00
vilmibm
c8e9768bf5 slopwip on interactive review 2020-05-11 15:28:12 -05:00
Nate Smith
aac9947a51
Merge pull request #897 from vilmibm/hide-review
hide stuff
2020-05-11 12:58:45 -05:00
vilmibm
569595894f skip review tests for now 2020-05-11 12:09:21 -05:00
vilmibm
1675a677d6 hide credits from main help 2020-05-11 12:04:24 -05:00
vilmibm
9f0a19911a de-register review until it's ready to ship 2020-05-11 12:04:05 -05:00
Corey Johnson
fe49c2d8b7
Merge pull request #862 from cli/cli-syntax
Add command line syntax doc
2020-05-11 09:54:04 -07:00
Corey Johnson
a7cef60aae
Merge pull request #889 from cli/hacky-help
Fix the help docs on subcommands
2020-05-11 09:39:53 -07:00
Mislav Marohnić
1f0db96f2a Avoid relying on Cobra help internals 2020-05-11 12:38:22 +02:00
Nate Smith
c7f7bfc328
Merge pull request #787 from cli/issue-pr-create-metadata
Add flags to add additional metadata to `issue/pr create`
2020-05-08 15:04:15 -05:00
Nate Smith
5ba3baa3c8
Merge pull request #762 from doi-t/reviewers-in-pr-view
Add Reviewers to pr view in CLI
2020-05-08 14:46:08 -05:00
Nate Smith
07dc617566
Merge pull request #840 from cli/credits
hackday: gh credits
2020-05-08 14:37:35 -05:00
vilmibm
b15692fab3 review feedback 2020-05-08 14:29:50 -05:00
Nate Smith
77ed118022
Merge pull request #880 from cli/pr-status-crash
Fix `pr status -R` crash with closed PR on the default branch
2020-05-08 14:23:51 -05:00
Nate Smith
27de1fdc36
Merge pull request #881 from cli/go1.14
Upgrade to Go 1.14 in CI
2020-05-08 14:15:04 -05:00
Victor Hugo
8f67ad44e0 add description default private for repo create 2020-05-08 15:04:02 -04:00
Corey Johnson
a46e7cab2f Update docs 2020-05-08 11:54:13 -07:00
Corey Johnson
9267804ef3 Update docs 2020-05-08 11:44:30 -07:00
Corey Johnson
43e15130f1 Use a var 2020-05-08 11:37:45 -07:00
Mislav Marohnić
c682d90466 Add tests for issue/pr create with metadata 2020-05-08 20:32:46 +02:00
Corey Johnson
b9c4a76687 Update usage docs 2020-05-08 11:20:00 -07:00
Mislav Marohnić
4a3588d611
Merge pull request #839 from cli/issue-pr-create-metadata-wizard
Prompt for additional metadata during `issue/pr create`
2020-05-08 18:55:12 +02:00
Mislav Marohnić
8c84d6881e Avoid aborting survey if reviewers/assignees/labels/projects/milestones are empty 2020-05-08 18:49:43 +02:00
Mislav Marohnić
1128439cd1 issue/pr create: hide "Add metadata" if viewer does not have triage permission 2020-05-08 18:37:08 +02:00
Corey Johnson
ba1b3424c1 Remove unused funcs
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-05-08 09:22:50 -07:00
Mislav Marohnić
d7e6d21766 Order projects, teams, and labels by name 2020-05-08 18:22:14 +02:00
Corey Johnson
70223d1e32 Don't always use the root command help
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-05-08 09:19:19 -07:00
Mislav Marohnić
1f774b4158 Add spinner while loading metadata 2020-05-08 18:11:57 +02:00