Kevin Bluer
d440a95aed
Improved error message when "owner/repo" format not provided ( #919 )
...
Fixes #882
2020-05-18 11:13:48 +02:00
Mislav Marohnić
57e60ab8a1
Merge remote-tracking branch 'origin/master' into issue-metadata-resolve-ids
2020-05-13 17:20:37 +02:00
Mislav Marohnić
c225d379a9
Preserve CODEOWNERS reviewers in pr create
...
When reviewers were requested on a PR, they would apparently
overwrite the current set of reviewers. A fresh PR will already have
reviewers if it was assigned some by CODEOWNERS rules.
The fix is to only ever add additional reviewers and not overwrite the
entire set.
2020-05-13 12:09:59 +02:00
Corey Johnson
ad3a5903b2
Merge pull request #873 from cli/the-merge-dubai
...
Add support for `gh pr merge`
2020-05-12 10:18:54 -07:00
Mislav Marohnić
386a53c34a
Fix metadata resolver query
2020-05-12 16:48:30 +02:00
Mislav Marohnić
3abc2be0f7
Switch issue create to optimized resolver and update tests
2020-05-12 16:17:06 +02:00
Mislav Marohnić
6d57f2a91e
Faster resolve GraphQL node IDs for assignees, reviewers, and labels
2020-05-12 15:33:51 +02:00
Nate Smith
c7f7bfc328
Merge pull request #787 from cli/issue-pr-create-metadata
...
Add flags to add additional metadata to `issue/pr create`
2020-05-08 15:04:15 -05:00
Nate Smith
5ba3baa3c8
Merge pull request #762 from doi-t/reviewers-in-pr-view
...
Add Reviewers to pr view in CLI
2020-05-08 14:46:08 -05:00
Nate Smith
77ed118022
Merge pull request #880 from cli/pr-status-crash
...
Fix `pr status -R` crash with closed PR on the default branch
2020-05-08 14:23:51 -05:00
Corey Johnson
43e15130f1
Use a var
2020-05-08 11:37:45 -07:00
Mislav Marohnić
1128439cd1
issue/pr create: hide "Add metadata" if viewer does not have triage permission
2020-05-08 18:37:08 +02:00
Mislav Marohnić
d7e6d21766
Order projects, teams, and labels by name
2020-05-08 18:22:14 +02:00
Mislav Marohnić
d0f168f4c3
Merge remote-tracking branch 'origin/master' into issue-pr-create-metadata
2020-05-08 17:46:17 +02:00
Mislav Marohnić
3000847bb2
Merge pull request #874 from cli/httpmock
...
Parallelism-safe mechanism for stubbing HTTP responses
2020-05-08 17:34:57 +02:00
vilmibm
c40f064baa
sigh
2020-05-07 14:58:00 -05:00
Mislav Marohnić
93c61a83b2
Fix pr status -R crash with closed PR on the default branch
...
At the time we have a reference to `baseRepo`, we might still not have
contacted the API nor obtained any information about the default branch
for the repository. This expands the `PullRequests()` query to always
report the default branch so we may choose how to render entries that
belong on the current branch.
2020-05-07 20:53:03 +02:00
vilmibm
d81e622700
lightest weight reviewing
...
this commit add very basic non-interactive PR reviewing. You can either
review the "current" or a passed PR (number or URL) as approved, changes
requested, or commented via CLI flags.
2020-05-07 13:30:34 -05:00
Corey Johnson
5810acf6ac
Use correct struct
2020-05-07 10:29:56 -07:00
Mislav Marohnić
0a4d4ee007
Replace FakeHTTP with httpmock which is now compatible
2020-05-07 15:19:14 +02:00
Mislav Marohnić
256d31950a
Migrate a single test over to httpmock to demonstrate its use
2020-05-06 22:06:37 +02:00
Corey Johnson
8c85e14bac
Make it work without a PR number
2020-05-06 11:19:00 -07:00
Corey Johnson
8681e7a7b6
Make squash and rebase work
2020-05-05 15:09:02 -07:00
Corey Johnson
c0831d4c4f
Add merge api call
2020-05-05 11:56:45 -07:00
Nate Smith
1a1fc64fe4
Merge pull request #842 from foad/df-805-hide-closed-default
...
Hide closed/merged PRs from default branch
2020-05-04 20:17:53 -05:00
Corey Johnson
5cc60c669e
Take in a pointer
2020-05-04 10:19:54 -07:00
Mislav Marohnić
b59407dd7d
Merge remote-tracking branch 'origin/master' into issue-pr-create-metadata
2020-05-04 17:09:41 +02:00
Mislav Marohnić
2089b15e6a
Fix pagination when fetching metadata
2020-05-04 17:09:11 +02:00
Corey Johnson
0bb1d2018a
Add code to reopen
2020-05-01 12:00:13 -07:00
Corey Johnson
19f6c69854
Actually make it work
2020-04-30 11:27:11 -07:00
Corey Johnson
f9a55f4d8e
Add close pull request code
2020-04-30 11:24:43 -07:00
Corey Johnson
e2aab30836
just return the err
...
Co-authored-by: Nate Smith <vilmibm@github.com>
2020-04-30 08:59:14 -07:00
Corey Johnson
23c072b39d
Add api call
2020-04-29 14:14:50 -07:00
Corey Johnson
28b35aa333
Merge pull request #843 from cli/when-god-closes-an-issue-he-opens-a-pull-request
...
Add `gh issue close <urlOrNumber>`
2020-04-29 11:54:48 -07:00
Toshiya Doi
d2d0b47ecc
Merge branch 'master' into reviewers-in-pr-view
2020-04-30 00:31:04 +09:00
Corey Johnson
660cce7790
Take a URL
2020-04-28 12:15:33 -07:00
Corey Johnson
f22f584e8d
Handle closed issues
2020-04-28 11:53:25 -07:00
Corey Johnson
bf94a31619
not on issues disabled
...
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 10:05:56 -07:00
Corey Johnson
a2f0cc6de7
Issue close works
...
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 09:31:19 -07:00
Corey Johnson
ad48d8b3c3
Add issue close
...
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 09:13:08 -07:00
Daniel Foad
09157f1fc7
unit tests
2020-04-28 00:03:21 +01:00
Mislav Marohnić
c6d8a4c151
Fix mutations
2020-04-27 16:42:53 +02:00
Mislav Marohnić
42baf4c8c5
Support org projects and team reviewers
2020-04-27 14:09:05 +02:00
Mislav Marohnić
3aaa231cc5
Guide user through re-authorization flow if read:org scope is missing
...
How this works for people with existing OAuth tokens:
$ gh issue list -L1
Notice: additional authorization required
Press Enter to open github.com in your browser...
[auth flow in the browser...]
Authentication complete. Press Enter to continue...
Showing 1 of 132 issues in cli/cli
...
Users of Personal Access Tokens get a different notice:
Warning: gh now requires the `read:org` OAuth scope.
Visit https://github.com/settings/tokens and edit your token to enable `read:org`
or generate a new token and paste it via `gh config set -h github.com oauth_token MYTOKEN`
2020-04-23 18:20:21 +02:00
Mislav Marohnić
6ed50c66ea
Prefetch metadata in parallel
2020-04-22 19:15:44 +02:00
Toshiya Doi
1ce09ff758
Merge branch 'master' into reviewers-in-pr-view
2020-04-22 22:00:02 +09:00
Toshiya Doi
d70358ea34
Support GitHub Team in requested reviewers
2020-04-22 21:58:01 +09:00
Mislav Marohnić
a7d061709d
Add ability to prefetch granulated repository metadata
2020-04-21 19:14:57 +02:00
Mislav Marohnić
39c4a5bc1b
Remove unnecessary nil check
2020-04-17 20:29:18 +02:00
Mislav Marohnić
d3a89b8744
Expand issue create metadata flags to pr create
...
- Includes support `pr create --reviewer <login>`
- Hide "Preview in browser" menu option when any metadata are set
2020-04-17 20:23:57 +02:00