vilmibm
dadcf4ba96
add prompt.StubConfirm
2020-07-27 10:00:19 -05:00
vilmibm
c34054bdc8
isolate repo create command
2020-07-24 12:26:27 -05:00
vilmibm
cc862d03e7
remove dead code
2020-07-23 16:43:16 -05:00
vilmibm
1831d95433
isolated clone command
...
This commit hacks the existing repo clone tests into something usable by
the new isolated command. It went ok and was less effort than trying to
introduce the same kind of test format as repo view and gist create.
2020-07-23 16:40:31 -05:00
vilmibm
b9ce1a1daf
pass resolving baserepo into newcmdview
2020-07-23 15:13:23 -05:00
vilmibm
d92c80b560
just swap BaseRepo implementation
2020-07-23 11:58:22 -05:00
vilmibm
086fb48d31
move displayURL
2020-07-23 11:25:31 -05:00
vilmibm
70c948a751
move isURL
2020-07-23 11:23:45 -05:00
vilmibm
dc02366128
move generateRepoURL to ghrepo
2020-07-23 11:16:47 -05:00
vilmibm
2a99ed9afb
add ResolvedBaseRepo
2020-07-23 11:01:29 -05:00
vilmibm
a27c8a9c21
isolate repo view cmd
2020-07-22 15:54:11 -05:00
Mislav Marohnić
97350e87a1
Merge remote-tracking branch 'origin' into migrate-gist
2020-07-22 16:17:30 +02:00
vilmibm
c06eacf4ee
remove obsolete ensureScopes
2020-07-21 17:42:52 -05:00
vilmibm
eb204c0dee
scriptability improvements for repo commands
2020-07-21 14:17:25 -05:00
Nate Smith
71bebd3f54
Merge pull request #1403 from cli/readme-markdown
...
Report HTTP and Markdown errors in `repo view`
2020-07-21 11:53:29 -05:00
Nate Smith
739d66b2d2
Merge pull request #1373 from cli/pr-scriptability
...
pr command scriptability improvements
2020-07-21 11:51:39 -05:00
vilmibm
1137e40a1f
use colorableErr
2020-07-21 11:46:51 -05:00
Mislav Marohnić
e373195817
WIP migrate gist create to separate package
2020-07-21 18:13:16 +02:00
Mislav Marohnić
71b13a81d0
Correctly report HTTP and Markdown errors in repo view
...
Any errors from fetching and rendering the README were silenced and
ignored in `repo view`. This change:
- Tolerates HTTP 404, but will raise exceptions for any other error;
- Moves markdown rendering from `api` package to command implementation;
- Ensures markdown rendering errors are correctly reported.
2020-07-21 13:47:27 +02:00
Mislav Marohnić
6a48a604f0
Merge pull request #1383 from cli/gist-create-stdin
...
Fix creating gists from stdin with argument
2020-07-21 11:37:35 +02:00
vilmibm
fa928489b6
collapse open/draft state
2020-07-20 15:55:40 -05:00
vilmibm
f30f931695
fix tests
2020-07-20 15:55:37 -05:00
vilmibm
bffcbce716
restore nontty + web but suppress informational prints
2020-07-20 13:04:17 -05:00
vilmibm
168bd33bc9
pr command scriptability improvements
...
This commit improves behavior and error handling for pr commands when
run unattached to a tty.
- error if pr create and no -t/-f
- error if pr create and -w
- machine readable pr list
- machine readable pr view
- various cleanup of informational messages
2020-07-20 13:04:17 -05:00
vilmibm
2dd42eb9aa
minor alias scriptability changes
2020-07-20 11:10:34 -05:00
vilmibm
b7765591b7
remove package level terminal check state
2020-07-17 15:02:05 -05:00
Mislav Marohnić
1545674d5c
💅 Tweak --public flag description
...
Trying to generally avoid "when true" in descriptions of boolean flags
2020-07-17 19:13:14 +02:00
Mislav Marohnić
a1a3e2d7bf
Pass FlagError by reference
2020-07-17 19:11:53 +02:00
Mislav Marohnić
d90c387e04
Update gist create test
...
- use testify
- verify that the HTTP request is a POST to `/gists`
- more precise POST params matching in assertion
2020-07-17 18:24:34 +02:00
Mislav Marohnić
449fccf811
Enable passing stdin to gh gist create -
...
Goals:
- print command usage information on `gh gist create` when no args nor stdin
- disallow passing `-` as argument multiple times
- utilize Cobra's Args to do argument validation
2020-07-17 18:24:34 +02:00
Mislav Marohnić
9e4af479da
Add command line docs for supported environment variables
2020-07-16 17:46:09 +02:00
Mislav Marohnić
89adc83194
Merge pull request #1363 from shihanng/feature/issue-1361__help
...
Dedent help texts based on shortest indent
2020-07-16 16:44:52 +02:00
Mislav Marohnić
e6083605c5
Fix spacing around gh help sections
2020-07-16 16:41:40 +02:00
Mislav Marohnić
065496781e
Add indent helper function
2020-07-16 16:24:25 +02:00
Mislav Marohnić
4e15982046
Fix crash in dedent when blank lines are passed
2020-07-16 16:10:39 +02:00
Mislav Marohnić
0528145159
Allow filter values with spaces in issue/pr list --web
2020-07-16 15:21:50 +02:00
Shi Han NG
3db8bc654a
dedent flags in rootUsageFunc
2020-07-16 22:04:40 +09:00
Shi Han NG
3fb90b43ba
dedent based on shortest indent
2020-07-16 22:04:10 +09:00
Mislav Marohnić
8626befd3f
Merge remote-tracking branch 'origin' into webInList
2020-07-16 14:51:34 +02:00
Mislav Marohnić
b0fede93c9
Merge pull request #1365 from cli/pr-checkout-fixes
...
pr checkout fixes for branch names
2020-07-16 14:31:04 +02:00
Shi Han NG
7120b95731
add TestStripIndent
2020-07-16 08:33:00 +09:00
Nate Smith
619ef43f76
Merge pull request #1191 from cli/shell-alias
...
shell aliases
2020-07-15 12:24:36 -05:00
vilmibm
86912b31b2
stub sh lookup
2020-07-15 12:17:36 -05:00
vilmibm
cf3af450eb
minor docs
2020-07-15 11:40:35 -05:00
vilmibm
cfb8eebf30
quietly return exit code of external command
2020-07-15 11:39:48 -05:00
vilmibm
acaaa28fd7
helper function for finding sh
2020-07-15 11:30:20 -05:00
Mislav Marohnić
dfb774cd38
Verify HTTP stubs in pr checkout tests
2020-07-15 16:18:36 +02:00
Mislav Marohnić
c232c8872c
Abort pr checkout when PR has an invalid head branch name
2020-07-15 16:16:38 +02:00
Mislav Marohnić
305cd290ee
Fix pr checkout <owner>:<branch> when it matches the default branch
...
First, consolidate the functionality between `pr merge` and `pr
checkout` that resolves the default branch name of the base repo. With
an added bonus, the new approach avoids an API request when one isn't
necessary.
Then, ensure that checking out 3rd-party PRs will result in local branch
name such as `<owner>/<branch>` when the head branch of the repository
matches the default branch of the base repository. We already have had
code in place to take care of this, but it only took effect in the `pr
checkout <number>`-style invocation.
2020-07-15 15:35:42 +02:00
Mislav Marohnić
6825944cad
Reference named queries in pr checkout HTTP stubs
2020-07-15 14:54:30 +02:00