Commit graph

1275 commits

Author SHA1 Message Date
Des Preston
dafd0bfbd1 feat(4248): add support for line range w/ browse
Allow using a range of lines when browsing files. For example:

`gh browse test.go:10-20`

Closes #4248
2021-08-31 16:32:37 -04:00
Mislav Marohnić
4fa984a333
Merge pull request #4003 from despreston/3381-release-discussions
add --discussion-category flag to release cmd
2021-08-10 15:54:03 +02:00
Des Preston
bdc5b55f55 pr comments
Only add discussion category to request if there is one. This eliminates
the need to update old tests.

Renaming the variable to something shorter.
2021-08-10 09:47:49 -04:00
Sam
c5371d5303
Merge pull request #3813 from cli/repo-sync
Add repo sync command
2021-08-05 19:39:40 -07:00
Mislav Marohnić
9a485ddfa2 💅 Cleanup local branch handling during pr checkout 2021-08-05 20:44:34 +02:00
Des Preston
294a029e70 add --branch flag to pr checkout
Allows renaming the checked out branch.
2021-08-05 20:44:20 +02:00
Sam Coe
174e26ecac
Fix tests 2021-08-04 18:26:30 -07:00
Sam Coe
2c4a662660
Rework git client interface 2021-08-04 18:13:58 -07:00
Sam Coe
00d67e3e5a
Remove unnecessary + 2021-08-04 17:10:50 -07:00
Sam Coe
86f16dbaf5
Use more idiomatic pattern 2021-08-04 17:00:20 -07:00
Sam Coe
c0756c2d1c
Clean up UX 2021-08-04 16:42:27 -07:00
Mislav Marohnić
95a515ecf0
Merge pull request #4087 from cli/graphql-error-fix
Fix unmarshalling GraphQL error type
2021-08-04 15:43:00 +02:00
Mislav Marohnić
90b7886142 Fix unmarshalling GraphQL error type
The "path" field of a GraphQL error object contains a mix of strings and
numbers and cannot be deserialized into `[]string`. Fortunately, we
don't need to rely on the "path" field and instead have the final error
message be constructed by aggregating human-readable "message" fields.
2021-08-04 15:34:53 +02:00
Mislav Marohnić
1007c1a3ae
Merge pull request #4079 from cli/no-label-colors
Disable colorizing labels in `issue list` output
2021-08-04 15:23:36 +02:00
Marc Khouzam
549caf29b5 Enable completion descriptions for powershell
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
2021-08-04 07:45:30 -04:00
Mislav Marohnić
930ee60ac5 Disable colorizing labels in issue list output
- Labels with dark color are not visible on a dark background
- "Raw" `issue view` output should never output color, not even with
  CLICOLOR_FORCE=1
2021-08-03 16:02:16 +02:00
Mislav Marohnić
5d1d967c43 💅 Clean up pr merge admin logic 2021-08-03 15:49:55 +02:00
rsteube
baa18c164d pr merge: added --admin flag 2021-08-02 13:02:32 +02:00
Sam
92ed42c54a
Merge pull request #4029 from cli/extensions-upgrade-force
Add --force flag for extensions upgrade
2021-07-27 08:07:14 -07:00
Mislav Marohnić
f3a7d0076e
Merge pull request #4028 from cli/bump-cobra
Upgrade Cobra for improved shell completion support
2021-07-27 16:34:20 +02:00
Mislav Marohnić
fdad37e248
Merge pull request #4019 from cli/enterprise-env
Fix error message when using GH_ENTERPRISE_TOKEN but host is ambiguous
2021-07-27 15:29:14 +02:00
Mislav Marohnić
82c6fb7d1a Add a note about the dummy GHE hostname 2021-07-26 18:59:53 +02:00
Sam Coe
340a1fdc93
Add --force flag for extensions upgrade 2021-07-21 11:06:22 -07:00
Mislav Marohnić
2801206663 Switch to Cobra's bash completion V2 2021-07-21 16:32:39 +02:00
Mislav Marohnić
6ed2e8f7f8 Add completion support to repo create --gitignore and --license 2021-07-21 16:12:38 +02:00
Mislav Marohnić
db8204dc56 Allow space to be added after completing issue/pr list --state values
The "nospace" directive instructs the shell completion logic to avoid
adding a space after completing the word. However, this feature was
broken in an older Cobra, and users still saw a space character added.
In most case we want the space because we anticipate that the user might
want to add extra arguments to the command.
2021-07-21 16:12:38 +02:00
Sam Coe
e70bdbf7a9
Add update checking to extensions list 2021-07-20 13:13:20 -07:00
Mislav Marohnić
a83c2924c5 Never prompt to delete branch if --auto was given 2021-07-20 19:49:19 +02:00
Mislav Marohnić
6e026412df Add "UNSTABLE" to immediately mergeable statuses
This status describes a state where the head branch is mergeable and
technically not blocked per base branch requirements, but it does have
non-passing checks.
2021-07-20 19:42:53 +02:00
Mislav Marohnić
6f2dfd7eea Adjust conditions for switching between regular and auto merge
Conditions prohibiting a regular merge: BLOCKED, BEHIND, DIRTY.

Conditions triggering a regular merge even if `--auto` was set: CLEAN,
HAS_HOOKS.

Note that UNKNOWN status does not trigger either of the conditions.
2021-07-20 19:34:32 +02:00
Mislav Marohnić
0ab9c70c3f Merge remote-tracking branch 'origin' into improve-automerge 2021-07-20 18:45:47 +02:00
Mislav Marohnić
25ef11198f
Merge pull request #4020 from cli/xdg-docs
Clean up GH_CONFIG_DIR docs
2021-07-20 18:02:23 +02:00
Mislav Marohnić
1121ec6669
Merge pull request #4013 from chemotaxis/docs/alias-quotes-windows
Add documentation about double quoting on Windows
2021-07-20 18:01:36 +02:00
Mislav Marohnić
75c7fc1536
Merge pull request #3972 from g14a/fix/private-repo-create
fix private repo creation in case of ignore templates & repo description bugs in case of template repos
2021-07-20 16:39:36 +02:00
Mislav Marohnić
1de756f6f3 💅 address review comments 2021-07-20 16:34:11 +02:00
Mislav Marohnić
c598a1edc2 Fix detecting cases when cfg.Hosts() is empty 2021-07-20 15:50:58 +02:00
Mislav Marohnić
efa4d43cf4 Simplify alias set documentation 2021-07-20 15:32:51 +02:00
Mislav Marohnić
9033258f5f Clean up GH_CONFIG_DIR docs
This removes the false equivalence between GH_CONFIG_DIR and
XDG_CONFIG_HOME. These settings do not have the same effect and should
not be used for the same purposes.

Also remove the documentation about what `XDG_*` settings do. We simply
conform to the XDG Base Directory Specification, but will not document
it. It's likely that users of these environment variables already know
what they do.
2021-07-20 14:24:11 +02:00
Mislav Marohnić
aec0f10041 Fix error message when using GH_ENTERPRISE_TOKEN but host is ambiguous
Before:

    $ GH_ENTERPRISE_TOKEN="..." gh pr create
    could not find hosts config: not found

Now:

    $ GH_ENTERPRISE_TOKEN="..." gh pr create
    set the GH_HOST environment variable to specify which GitHub host to use

Also amends `gh help environment` documentation to suggest the use of
GH_HOST when scripting operations with GitHub Enterprise repositories.
2021-07-20 14:11:07 +02:00
chemotaxis
1e4e536bcb Revise Windows note 2021-07-19 15:50:27 -04:00
chemotaxis
2c52819c1a Remove note about using Git for Windows
As discussed in pull request #4013.
2021-07-19 15:50:12 -04:00
Sam
97a52f74cd
Merge pull request #3933 from cli/extensions-upgrade
Skip trying to upgrade local extensions
2021-07-19 10:55:16 -07:00
Sam Coe
b71735d0d7
Address PR comments 2021-07-19 10:48:09 -07:00
chemotaxis
23ffca45f7 Unify use of single quotes to mark shell arguments and variables
The first paragraph uses single quotes when referring to shell arguments
and variables, but the rest of the docs use double quotes.  This commit
switches to using single quotes throughout the docs.

I prefer to use single quotes inside string literals because Go uses
double quotes to define a string literal.
2021-07-19 00:46:06 -04:00
chemotaxis
5314e7c398 Add note about double quotes on non-Unix-like shells
On non-Unix-like shells like Windows Command Prompt, single quotes are
handled differently.  You need to define aliases using double quotes
instead of single quotes.

I added an inline example to illustrate the quotes.  The example is
formatted as inline code blocks in Markdown.  Unfortunately, because Go
uses backticks for raw string literals, I needed to do some rather ugly
string concatenation in order to get the backticks included in the doc
string.

This also rearranges the notes so that the platform specific notes are
at the end of the documentation.
2021-07-19 00:36:07 -04:00
Mislav Marohnić
882f6d33cb Merge remote-tracking branch 'origin' into extensions-remove-notice 2021-07-16 15:12:56 +02:00
Mislav Marohnić
d68df4a9d8 Do not output error messages for nontty 2021-07-16 15:10:36 +02:00
Mislav Marohnić
30beb67cb3
Merge pull request #3941 from cli/extension-install-check
Extension install check
2021-07-16 14:58:52 +02:00
Mislav Marohnić
d6b0749ea2 Tweak error messages and add more tests for extension install name check 2021-07-16 14:52:05 +02:00
Des Preston
45a4257612 add --discussion-category flag to release cmd
Flag for signaling that a discussion should be created with the given
category for the release. Discussions are not supported for draft
releases. If a discussion category is given for a draft, an err will be
shown.

Closes #3381
2021-07-15 10:07:21 -04:00