Commit graph

9907 commits

Author SHA1 Message Date
Andy Feller
db24646e70 Run Lint and Tests on push to trunk branch
This change causes the "Lint" and "Unit and Integration Tests" workflows to only run on `push` events on the default branch (`trunk`).

This should avoid running redundant set of jobs on pull requests.
2025-07-17 15:18:31 -04:00
Andy Feller
08303d91e6
Merge pull request #11299 from cli/kw/feature-request-comment
Add automated feature request response workflow
2025-07-17 14:20:10 -04:00
Kynan Ware
e35a974892
Update .github/workflows/feature-request-comment.yml 2025-07-17 12:11:30 -06:00
Kynan Ware
5ea34d80de
Merge pull request #11211 from samcoe/fix-web-code-search-filename-extension-flags
Transform `extension` and `filename` qualifiers into `path` qualifier for web code search
2025-07-17 12:09:58 -06:00
Kynan Ware
0bcb9bf818
Merge pull request #11322 from cli/kw/alert-autofix-169
Potential fix for code scanning alert no. 169: Workflow does not contain permissions
2025-07-17 12:08:12 -06:00
Kynan Ware
7f97bcfcd6
doc: remove codenames from code comments 2025-07-17 12:00:17 -06:00
Kynan Ware
f06c46de95 Potential fix for code scanning alert no. 169: Workflow does not contain permissions
Co-Authored-By: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-07-17 11:02:20 -06:00
Kynan Ware
73cb3ec8a8
Merge pull request #11312 from cli/babakks/avoid-fetching-logs-for-skipped-jobs
Avoid fetching logs for skipped jobs
2025-07-17 09:48:41 -06:00
Sam Coe
e2b444452d
Add additional test case for when extension is prefixed with a dot 2025-07-17 17:32:48 +02:00
Andy Feller
47f24b9228
Merge pull request #11251 from cli/bdehamer/immutable-release-field
Display immutable field in `release view` command
2025-07-17 10:53:04 -04:00
Sam Coe
723d0e861b
Merge branch 'trunk' into fix-web-code-search-filename-extension-flags 2025-07-17 10:21:46 +02:00
Andy Feller
260519dc69
Merge pull request #11279 from cli/andyfeller/issue-create-assign-copilot
Assign Copilot during `gh issue create`
2025-07-16 17:01:32 -04:00
Andy Feller
973718712a Fix failing tests for Copilot replacement 2025-07-16 15:36:53 -04:00
Andy Feller
b433792a44 Fix copilot replace test names
In refactoring how this parameter works, I forgot to update the related tests to match.
2025-07-16 15:09:13 -04:00
Andy Feller
5cf3d3b9a5 Use constant for Copilot name
Based on PR feedback from @bagtoad, this commit creates a new constant for the Copilot bot name, which is used in the assignee / reviewer selection as well as replacing `@copilot` when going to GitHub.com UI
2025-07-16 15:06:43 -04:00
Andy Feller
4f0a5807bf Refactor CopilotReplacer logic based on PR feedback
Thanks to @bagtoad, this commit refactors the argument to `NewCopilotReplacer(bool)` from being where this is used to what it effect is has.

Because there is already precedence for display name being `<login> (<name>)`, I worried there would be confusion for `Copilot (AI)` being display name for assignees and reviewers but `Copilot` when going to GitHub.com UI.  Instead, I renamed the argument based on whether the login is returned / replaced.
2025-07-16 14:42:11 -04:00
Andy Feller
e2bed653df Implement actor and user assignee tests 2025-07-16 14:10:26 -04:00
Babak K. Shandiz
f67bd9a7d1
test(run view): assert a skipped job does not cause error
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-16 14:19:57 +01:00
Babak K. Shandiz
64d5d6c6c8
fix(run view): avoid looking for job log if its been skipped
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-16 14:19:56 +01:00
Babak K. Shandiz
2ce3279ebc
fix(run): add IsSkipped function
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-16 14:19:45 +01:00
Andy Feller
21202ff992 Improve comments from PR feedback 2025-07-16 08:47:12 -04:00
Andy Feller
dbff7c5655
Merge pull request #11300 from cli/revert-10547-dan/fix-title-and-body-pr-create-priority
Revert "Fix: `gh pr create` prioritize `--title` and `--body` over `--fill` when `--web` is present"
2025-07-14 17:34:58 -04:00
Andy Feller
1eeb797975
Revert "Fix: gh pr create prioritize --title and --body over --fill w…"
This reverts commit b31f38c946.
2025-07-14 17:23:09 -04:00
Kynan Ware
7a691e4c44 feat(comment): add automated feature request response 2025-07-14 15:14:48 -06:00
Andy Feller
3a53b47c39
Merge pull request #11295 from cli/andyfeller/11294-fix-hostname-brackets
Ensure hostnames are visible in CLI website
2025-07-14 14:49:48 -04:00
Andy Feller
798d903ca0
Merge pull request #11275 from cli/dependabot/go_modules/golang.org/x/crypto-0.40.0
chore(deps): bump golang.org/x/crypto from 0.39.0 to 0.40.0
2025-07-14 10:01:12 -04:00
Andy Feller
a83db41a58 Merge branch 'trunk' into dependabot/go_modules/golang.org/x/crypto-0.40.0 2025-07-14 09:48:27 -04:00
Andy Feller
70602f7e79
Merge pull request #11265 from cli/dependabot/go_modules/golang.org/x/text-0.27.0
chore(deps): bump golang.org/x/text from 0.26.0 to 0.27.0
2025-07-14 09:42:58 -04:00
Andy Feller
d963506bdf Updated license files 2025-07-14 09:33:00 -04:00
Andy Feller
83b1bbeff9 Merge branch 'trunk' into dependabot/go_modules/golang.org/x/text-0.27.0 2025-07-14 09:31:12 -04:00
Andy Feller
c487c438f2
Merge pull request #11264 from cli/dependabot/go_modules/golang.org/x/sync-0.16.0
chore(deps): bump golang.org/x/sync from 0.15.0 to 0.16.0
2025-07-14 09:28:47 -04:00
Andy Feller
daa307e5fa Merge branch 'trunk' into dependabot/go_modules/golang.org/x/sync-0.16.0 2025-07-14 09:01:33 -04:00
Andy Feller
4007da9e27
Merge pull request #11293 from cli/andyfeller/exclude-3rd-party-from-golangcilint
Exclude `third-party` source from golangci-lint
2025-07-14 08:52:33 -04:00
Andy Feller
29a94ab9b1 Reformat non-documentation hostnames
Outside of the hostnames previously fixed, I talked with @williammartin about what to do with the remaining references and the concern about the mixed format.

One suggestion for the error / test use case was to remove the extraneous text all together.
2025-07-14 08:43:15 -04:00
Andy Feller
313d20ba83 Ensure hostnames are visible in CLI website
This commit changes <github.com> and <ghe.com> references to `github.com` and `ghe.com` so they are visible on the GitHub CLI marketing website.

GitHub Pages will render URLs with a protocol as clickable links, however hostnames are treated as HTML elements and not rendered.
2025-07-14 08:33:20 -04:00
Andy Feller
17f4273a74 Exclude third-party source from golangci-lint 2025-07-14 07:30:15 -04:00
Kynan Ware
6049cce249
Merge pull request #11278 from cli/kw/filter-third-party-from-codeql-analysis
Filter the `third-party/` folder out of CodeQL results
2025-07-12 09:57:28 -06:00
Kynan Ware
030bf8a68f Improve CodeQL workflow with SARIF filtering
Adds SARIF filtering for Go analysis to exclude third-party code from results and updates the workflow to upload filtered SARIF files. This enhances the accuracy of security reports by ignoring irrelevant files.
2025-07-11 13:39:20 -06:00
Andy Feller
fd1c31de59 Fix gh pr create tests from metadata change
These are the minimum fixes necessary to repair `gh pr create` tests after refactoring the underlying metadata resolution logic.
2025-07-11 15:32:17 -04:00
Andy Feller
554fe0f51f Fix gh issue create tests, copilot web assign
This commit is primarily focused on fixing the existing `gh issue create` tests with the changes to the underlying queries retrieving the data for resolving metadata.

Additionally, a new test case for `gh issue create --web --assignee @copilot` was added to mirror existing tests.  While exercising this capability, I found out the web UI apparently wants `copilot` instead of the `copilot-swe-agent` login, so changes to address that were a part of this commit.
2025-07-11 12:19:36 -04:00
Andy Feller
59196a4ce2 Update third-party license reports 2025-07-11 10:43:09 -04:00
dependabot[bot]
f7576f02a5
chore(deps): bump golang.org/x/crypto from 0.39.0 to 0.40.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.39.0 to 0.40.0.
- [Commits](https://github.com/golang/crypto/compare/v0.39.0...v0.40.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-11 14:21:23 +00:00
Andy Feller
a8053d19a9 Resolve issue and PR metadata consistently
This commit refactors how `gh issue create` and `gh pr create` retrieve information needed to resolve metadata to be more in line with the approach used in `gh issue edit` and `gh pr edit`.

Previously, both commands used `prshared.fillMetadata(...)` function to retrieve assignees, reviewers, labels, and teams outside of `api.RepoMetadata(..)`.  Now, these commands will consistently use the same logic and data for resolving metadata.
2025-07-11 10:21:17 -04:00
William Martin
64191577e4
Merge pull request #11266 from cli/dependabot/go_modules/golang.org/x/term-0.33.0
chore(deps): bump golang.org/x/term from 0.32.0 to 0.33.0
2025-07-11 11:41:51 +02:00
William Martin
fee5f611d2 Fixed licenses for bump golang.org/x/term from 0.32.0 to 0.33.0 2025-07-11 11:18:48 +02:00
dependabot[bot]
a21d32fe16 chore(deps): bump golang.org/x/term from 0.32.0 to 0.33.0
Bumps [golang.org/x/term](https://github.com/golang/term) from 0.32.0 to 0.33.0.
- [Commits](https://github.com/golang/term/compare/v0.32.0...v0.33.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-version: 0.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-11 11:18:48 +02:00
Andy Feller
921205efee
Merge pull request #11263 from cli/dependabot/go_modules/github.com/sigstore/protobuf-specs-0.5.0
chore(deps): bump github.com/sigstore/protobuf-specs from 0.4.3 to 0.5.0
2025-07-10 15:57:38 -04:00
Brian DeHamer
c335c5e25f
include immutable field in release view
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-07-10 11:46:09 -07:00
Babak K. Shandiz
d3c4297070
Merge pull request #11268 from cli/babakks/automate-stale-issue-closing
Automate closing of stale issues
2025-07-10 18:09:30 +01:00
William Martin
1d0f8963e4 Fixed licenses for bump github.com/sigstore/protobuf-specs from 0.4.3 to 0.5.0 2025-07-10 18:43:36 +02:00