Commit graph

5265 commits

Author SHA1 Message Date
Mark Phelps
dd5feda00a Update wording after consulting product 2022-02-25 17:32:08 -05:00
Mark Phelps
71f32376d0 Fix tests 2022-02-22 20:20:52 -05:00
Mark Phelps
707220a9b1 PR updates 2022-02-22 14:16:03 -05:00
Mark Phelps
1ea26f33d8 Add create test 2022-02-22 09:50:43 -05:00
Mark Phelps
e7c2f973ae Support opting out of permissions 2022-02-17 15:11:12 -05:00
Mark Phelps
84aad52b22
Merge branch 'cli:trunk' into codespaces-accept-perms 2022-02-16 10:08:49 -05:00
Mark Phelps
590acaa1d6 WIP 2022-02-15 19:35:53 -05:00
Josh Gross
c2a9c5a74b
Support filtering pull requests authored by GitHub Apps (#5180) 2022-02-15 19:36:06 +01:00
Mislav Marohnić
95b1e7f74e
Merge pull request #5019 from k-jun/fix/release-discussion-category
fix(release): discussion category with assets
2022-02-15 18:37:41 +01:00
Mislav Marohnić
5d36bcc4de Merge remote-tracking branch 'origin' into fix/release-discussion-category 2022-02-15 18:28:08 +01:00
Mislav Marohnić
72340076ae tests 2022-02-15 18:27:58 +01:00
Breno Silva
6e14426dfb
docs: improve repo edit docs (#5165)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-02-15 17:35:30 +01:00
Mislav Marohnić
3e0db567e8
Rotate our Windows signing certificates (#5196)
- The certificate pfx file is now read from WINDOWS_CERT_PFX
- The password to decode the pfx is in WINDOWS_CERT_PASSWORD
- Quit reading from desktop-secrets repo
- Switch osslsigncode to take in pfx instead of individual certs
- 🔥 obsolete setup scripts
2022-02-15 17:23:39 +01:00
Sam Coe
28d2b52769
release create: warn about unpushed local git tag (#5104)
If `gh release create <TAG>` was called and TAG exists locally but not on the remote, this warns about the unpushed tag to avoid recreating it on the remote. The user can pass a value for `--target` to silence the warning.
2022-02-15 16:36:37 +01:00
Nate Smith
fc5cbe8f1f
Merge pull request #5205 from cli/revert-4998
Revert changing the location of GPG key file
2022-02-14 14:48:05 -06:00
nate smith
32dada90ba revert PR 4998 2022-02-14 10:35:09 -06:00
Mislav Marohnić
bf83c660a1
Merge pull request #5143 from cli/pager-epipe-ignore
Ignore EPIPE errors when writing to a closed pager
2022-02-14 17:09:17 +01:00
Mislav Marohnić
0a5e220231 Ignore EPIPE errors when writing to a closed pager
While a gh command is writing stdout to a pager, the user may choose to
close the pager program before the pager has read all the data on its
standard input. In that case, the parent gh process will receive an
EPIPE error, which would bubble up its error handling and cause it to
print something like:

    write |1: broken pipe

Since this was caused by an explicit user action of closing the pager,
and since the user probably doesn't want to see this uninformative
error, this informs our global error handling of this error and causes
it to be ignored.
2022-02-10 16:42:00 +01:00
Mislav Marohnić
c9f44ffda9
Merge pull request #5186 from cli/credential-helper-fix
Fix authenticating git operations after `auth login --with-token`
2022-02-10 15:59:41 +01:00
Patrick Veverka
f6f8ba8b7b
Add display name for codespaces (#5044) 2022-02-09 16:15:03 +01:00
Mislav Marohnić
6701b526d1 Fix authenticating git operations after auth login --with-token
After completing the interactive `gh auth login` flow, the `hosts.yml`
config file will have been populated with both `oauth_token` and `user`
properties for the GitHub host. However, after `auth login --with-token`
only the `oauth_token` is persisted but no username.

This fixes `auth git-credential` behavior so it allows authentication
even if the `user` property is missing. It's entirely optional to send a
proper username for git authentication, since GitHub seems to ignore the
actual value sent and just focuses on the token itself.
2022-02-09 00:10:10 +01:00
dependabot[bot]
c3d451b9b6
Bump github.com/briandowns/spinner from 1.18.0 to 1.18.1 (#5182)
Bumps [github.com/briandowns/spinner](https://github.com/briandowns/spinner) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/briandowns/spinner/releases)
- [Commits](https://github.com/briandowns/spinner/compare/v1.18.0...v1.18.1)

---
updated-dependencies:
- dependency-name: github.com/briandowns/spinner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-08 19:19:43 +01:00
endorama
825328031f
Add watch functionality to pr checks command (#4519)
* pr-checks: extract webMode

* pr-checks: extract checks information collection

* pr-checks: extract output utilities

* pr-checks: implement watch flag

* pr-checks: remove SIGINT interceptor

* pr-checks: exit with error if some task has failed

* update flags help text

* update default interval to 10s

* move interval flag parse to RunE

* refactor checksRunWatchMode to use infinite loop

* Refactor printTable function

* Refactor collect function

* Set up checksRun to use new refactored functions and simplify logic a bit

* Add tests

* Always set interval in opts

* use Duration flag

* Revert back to using int flag for consistency with run watch

* Use run watch screen clearing mechanism

* Re-add pager support

Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2022-02-08 08:33:42 +01:00
Mislav Marohnić
b59cd63700
Merge pull request #5173 from joshmgross/joshmgross/gist-path-handling
Correctly handle Windows paths when creating gists
2022-02-07 20:06:32 +01:00
Josh Gross
f43574bfe0
Correctly handle Windows paths when creating gists 2022-02-06 23:21:20 +00:00
Yuki Hirasawa
4f0264e37b
spelling: possible (#5157) 2022-02-02 16:54:09 +01:00
Mislav Marohnić
6a4f374caf
Enable repo override for repo deploy-key delete (#5152) 2022-02-01 11:40:34 +00:00
Mislav Marohnić
4a3ef50d2d
Standardize pager output across commands (#5141)
Add pager functionality to the following commands:
- gist list
- pr checks
- release list
- run list
- run view
- secret list
- workflow list
- workflow view

Additionally, normalize error handling when starting the pager has
failed: only print a non-fatal notice to stderr instead of aborting the
whole command.
2022-02-01 08:36:51 +01:00
Audree Steinberg
1ec2c0807e
Add new line after error (#5124)
* Add new line

* Fix syntax for adding new line

* Add `\n` to another error
2022-02-01 08:35:46 +01:00
Nate Smith
6cdb268005
Merge pull request #5130 from TheGejr/patch-1
Added install instructions for Void Linux
2022-01-31 10:53:12 -06:00
Kevin Lee
0d143ca89c
Consistent punctuation in command usages (#5139)
* Fix spelling and grammatical errors in command docs
* Add periods for consistency across the long command descriptions
* Format imports
2022-01-31 10:56:12 +00:00
Mislav Marohnić
a5dddbc1bf Fix lint error 2022-01-31 11:45:00 +01:00
Caleb Brose
eeeb73a3e3
Repo name suggestions for cs create (#5108)
Co-authored-by: Alan Donovan <alan@alandonovan.net>
2022-01-31 10:20:49 +00:00
Malte Gejr
5fe7ee3f86
Added install instructions for Void Linux
The package is added to the unofficial/community maintained list.
2022-01-30 14:53:26 +01:00
Sam Coe
f0b60e3530
Add non-local PR template support (#5097)
* Add non-local PR template support

* Consolidate template support functions

* Change back query name
2022-01-29 07:41:24 +00:00
Sam Coe
ba8c41a6ed
Add GH_HOST to hosts list if it has corresponding auth token (#5087)
* Add GH_HOST to hosts list if it has coresponding auth token

* Keep default host at front of hosts list

* Always add GH_HOST to hosts list
2022-01-29 07:37:24 +00:00
Sam Coe
3be4b9951d
Trim leading and trailing whitespace when setting secrets from stdin (#5086)
* Trim leading and trailing whitespace when setting secrets from stdin

* Only trim newline at end of string
2022-01-29 09:32:14 +02:00
Sam Coe
e68aa12564
Dont execute jq filters or templates when api requests are not successful (#5088) 2022-01-29 09:32:01 +02:00
Marwan Sulaiman
22c5269606
Fix flaky liveshare session test (#5111)
* Fix flaky liveshare session test

* typo

* PR comments
2022-01-27 11:20:50 -05:00
yasudanaoya
b77c37df0f
feat: add job id, into run view suggest command (#5105)
* feat: add job id, into run view suggest command

* fix: dry

* fix: run id to job id

* Change "a" to "the" when referencing a single job

Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2022-01-27 08:19:37 +00:00
Nate Smith
3a088e4df5
Merge pull request #5069 from hirasawayuki/fix-pr-checks-cmd
Fix duplicates check results returned by `gh pr checks`
2022-01-26 16:46:32 -06:00
Nate Smith
e17964cf03
Merge pull request #5092 from cli/repo-fork-proto
prefer configured git protocol when forking
2022-01-26 11:33:47 -06:00
Anton Baklanov
e28fa3c112
Add branch and actor filters to run list (#4100)
* Add branch and actor filters to `run list`

* Simplify what FilterOptions can do

* Check not only limit in TestNewCmdList

* Verify that branch/actor params are parsed properly

* Verify that API requests have proper query parameters

* Change flag name from actor to user

Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2022-01-26 08:14:56 +02:00
Nate Smith
a564909f03
Merge pull request #4886 from g14a/feature/target-repo-fork-name
Feature/target repo fork name
2022-01-25 15:57:16 -06:00
nate smith
667671f048 fix race condition, increase clarity 2022-01-25 15:36:41 -06:00
Nate Smith
13b3c7c1a4
Merge pull request #4998 from SubOptimal/patch-1
Amend location of GPG key file
2022-01-25 14:09:57 -06:00
nate smith
bd6e50a08a Merge remote-tracking branch 'origin/trunk' into feature/target-repo-fork-name 2022-01-25 14:08:27 -06:00
Nate Smith
e4f1a676f0
Merge pull request #4954 from ajhalili2006/patch-1
Add Alpine Linux install docs
2022-01-25 13:58:35 -06:00
nate smith
e51a4b5562 that did not work 2022-01-25 13:50:11 -06:00
nate smith
f2e76bea5d minor wording, arrangement 2022-01-25 13:49:38 -06:00