STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9036 commits 87 branches 0 tags 160 MiB
Commit graph

9036 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kynan Ware
439cfa08bb Exit on pr merge with -d and merge queue 
When running `gh pr merge -d` on a repo with a merge queue policy, exit before attempting to merge.
 2024-12-12 14:49:38 -07:00
Phill MV
94943eac10 Merge branch 'phillmv/improve-gh-at-inspect' of github.com:cli/cli into phillmv/improve-gh-at-inspect 2024-12-12 16:47:11 -05:00
Phill MV
94525f83f6 Addressed PR review feedback; expanded Long command help string, used ghrepo, clarified some abbreviations 2024-12-12 16:46:58 -05:00
Phill MV
e7f3d739ba
Update pkg/cmd/attestation/inspect/inspect.go 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2024-12-12 16:20:56 -05:00
Andy Feller
5e9283c70c
Merge pull request #10026 from ankddev/better-document-auth-scopes 
docs: better document auth scopes
 2024-12-12 11:16:14 -05:00
Andy Feller
4f32282f93 Update gh auth commands to point to GitHub Docs 
After initial discussion with core maintainers, it didn't seem prudent to duplicate the GitHub Docs information on OAuth scopes within the GitHub CLI codebase.

Instead, this commit updates help usage information in relevant commands on the page within GitHub Docs for more information.
 2024-12-12 11:03:57 -05:00
Kynan Ware
e2422b7e7e
Merge pull request #9933 from cli/kw/improve-ext-installation-no-executable-error 
Improve documentation and error messaging for local extension installations without executables
 2024-12-12 07:08:16 -07:00
William Martin
46862f96d9 Reformat ext install long 2024-12-12 14:57:34 +01:00
Kynan Ware
32abca8c38 Mention Windows quirk in ext install help text 2024-12-12 06:42:34 -07:00
Kynan Ware
3b93e28910 Fix error mishandling in local ext install 2024-12-12 06:40:37 -07:00
Kynan Ware
ec4b2dfe1b Assert on err msg directly in ext install tests 2024-12-12 06:38:04 -07:00
Kynan Ware
b9b60637b9 Clarify hosts in ext install help text 2024-12-12 06:35:13 -07:00
William Martin
9bdfa8367d
Merge pull request #10070 from cli/dependabot/go_modules/golang.org/x/crypto-0.31.0 
Bump golang.org/x/crypto from 0.29.0 to 0.31.0
 2024-12-12 13:41:16 +01:00
William Martin
a6dc0f2d8a
Merge pull request #10056 from cli/dependabot/github_actions/actions/attest-build-provenance-2.1.0 
Bump actions/attest-build-provenance from 1.4.4 to 2.1.0
 2024-12-12 13:39:44 +01:00
dependabot[bot]
1af421012e
Bump golang.org/x/crypto from 0.29.0 to 0.31.0 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.29.0 to 0.31.0.
- [Commits](https://github.com/golang/crypto/compare/v0.29.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-12-12 12:30:56 +00:00
Andy Feller
c8501d82f2
Add build constraint for non-Windows systems 2024-12-11 22:27:59 -05:00
Andy Feller
56841d9cee
Add build constraint for non-Windows systems 2024-12-11 22:25:08 -05:00
Phill MV
19bc3cd886 Removed now redundant file 2024-12-11 17:07:56 -05:00
Phill MV
82a849742e minor tweak to language 2024-12-11 16:58:37 -05:00
Phill MV
bbc47fbac7 go mod tidy 2024-12-11 16:52:40 -05:00
Phill MV
7bd59e091f Deleted no-longer-used code. 2024-12-11 16:51:23 -05:00
Phill MV
ac93417c29
Merge branch 'trunk' into phillmv/improve-gh-at-inspect 2024-12-11 16:50:01 -05:00
Phill MV
465b6ff889 deleted now-invalid tests, added a tiny patina of new testing. 2024-12-11 16:48:29 -05:00
Phill MV
bc236db9e5 Tightened up docs, deleted dead code, improved printing 2024-12-11 16:26:08 -05:00
Meredith Lancaster
6574327d79
Merge branch 'trunk' into gh-attestation-download-windows-bug 2024-12-11 09:20:35 -07:00
Meredith Lancaster
2418eda1cb fix file name creation on windows 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-11 08:55:11 -07:00
Meredith Lancaster
d42b076a48 wording 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-11 08:13:40 -07:00
Meredith Lancaster
2393725469 hard code expected digest 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-11 08:13:30 -07:00
Meredith Lancaster
35b5606937 fix download test 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-11 08:04:02 -07:00
Meredith Lancaster
5ebfa26487 use bash shell with integration tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-11 08:03:42 -07:00
Meredith Lancaster
91edde1acb simplify var creation 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-11 07:42:18 -07:00
Meredith Lancaster
2ced59fba3 update integration test scripts 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-11 07:42:05 -07:00
Andy Feller
52b845bcad Refactor local installation manager test by OS 
- Local extensions on Windows are not symlinks but files whose contents is the path to the local extension directory
- Local extensions elsewhere are symlinks
 2024-12-10 22:13:48 -05:00
Kynan Ware
2abe675246
Merge pull request #10043 from uday-rana/issue-10038 
fix: list branches in square brackets in `gh run` and `gh codespace`
 2024-12-10 15:25:57 -07:00
Kynan Ware
e8e30dab6a
Merge branch 'trunk' into issue-10038 2024-12-10 14:17:11 -07:00
Kynan Ware
9d53b86436
Merge pull request #10044 from cli/kw/cli-10034-repo-rename-docs-and-prompt-updates 
`gh repo rename` help text clarifies new repo name should not include owner
 2024-12-10 14:07:08 -07:00
Uday R
40beb82e0c fix: list branches in square brackets in gh codespace 2024-12-10 15:19:30 -05:00
Meredith Lancaster
b6c2b4ff2a try nesting scripts 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-10 11:58:23 -07:00
Meredith Lancaster
050f295b37 run all tests in a single script 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-10 11:41:15 -07:00
Meredith Lancaster
0e15557000 windows for loop syntax 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-10 10:18:15 -07:00
Meredith Lancaster
9ff3370ff7 use replaceAll 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-10 09:52:56 -07:00
Meredith Lancaster
98a81ffe0f update expected file path on windows 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-10 09:47:15 -07:00
Meredith Lancaster
9f6d18c70e run integration tests with windows specific syntax 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-10 08:37:32 -07:00
Meredith Lancaster
fb7f2bfea2 Merge branch 'trunk' into gh-attestation-download-windows-bug 2024-12-10 08:25:31 -07:00
Meredith Lancaster
351592d90f run all attestation cmd integration tests automatically 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-10 08:24:01 -07:00
dependabot[bot]
4c5a92aa11
Bump actions/attest-build-provenance from 1.4.4 to 2.1.0 
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.4.4 to 2.1.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](ef244123eb...7668571508)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-12-10 14:57:58 +00:00
Meredith Lancaster
23a3c18d56
Merge pull request #10020 from malancas/attestation-fetch-integration-tests 2024-12-10 07:56:57 -07:00
Jonas Grabber
881a2a374c
Improve error handling in apt setup script 
`wget -qO- ... | sudo tee` causes any errors from `wget` to be swallowed up, causing an empty keyring file to be configured.

For us, the local Ubuntu setup did not have `ca-certificates` installed, which caused `wget` to error out because of a authentication errors (untrusted certificate). However, the `-q` flag and the pipe into `tee` prevented the error from showing up or halting the script.

This PR turns on non-verbose output for `wget` and adds a proper short-circuit on the return code of it by storing the keyring in a temporary file first.
 2024-12-10 15:49:55 +01:00
Meredith Lancaster
e97d01f265 use different file name for attestation files on windows 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-09 17:32:55 -07:00
Uday R
8afb434e59 test(gh run): assert branch names are enclosed in square brackets 2024-12-09 12:45:36 -05:00