STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4776 commits 87 branches 0 tags 160 MiB
Commit graph

42 commits

Author SHA1 Message Date
Mislav Marohnić
78443964d4
Merge pull request #4513 from cli/missing-oauth-scopes 
Warn about missing OAuth scopes when reporting HTTP 4xx errors
 2021-10-14 20:21:13 +02:00
Mislav Marohnić
693193fe84 Consistent error handling in codespaces API operations 
Using HandleHTTPError ensures that hints regarding insufficient OAuth
scopes will be properly reported on stderr.
 2021-10-14 18:16:04 +02:00
Jose Garcia
b0905a415f
Merge pull request #4508 from cli/jg/codespace-stop 
codespace stop: new command to stop a running codespace
 2021-10-14 11:22:25 -04:00
Alan Donovan
675ee316e9
Merge pull request #4504 from cli/show-http-status 
cs create: include HTTP status code in error from /user/codespaces/*/start
 2021-10-13 09:00:37 -04:00
Jose Garcia
77a86e8611 Fix for API response body change 
- Connection is now embedded within the top level of the Codespace
  payload instead of inside the environment.
 2021-10-13 08:07:59 -04:00
Jose Garcia
ea0d0a543f Initial StopCodespace implementation 
- API
- Command
 2021-10-13 07:45:54 -04:00
Alan Donovan
9302e68c92 Include HTTP status code in error 2021-10-13 07:00:55 -04:00
Mateusz Urbanek
cedbbe3c2a
Add limit flag to codespace list (#4453) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2021-10-11 18:32:40 +00:00
Jose Garcia
400749d560 Fix regression returning nil codespace 2021-10-07 11:01:24 -04:00
Jose Garcia
bdc9ad30e7 Revert other rename changes 2021-10-06 13:46:04 -04:00
Jose Garcia
811d841fae Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt 2021-10-06 13:40:01 -04:00
Gabriel Ramírez
3d0d95ce2b
Merge pull request #4439 from geramirez/geramirez/codespaces-pagination 
Adding pagination to list codespaces
 2021-10-06 12:38:50 -05:00
Jose Garcia
a509c2d884 Remove unused guid 2021-10-06 11:45:43 -04:00
Jose Garcia
3a28643630 Keep codespace struct in API for now 
- Use a private codespace structure in the cmd pkg to encapsulate common
  behavior
 2021-10-06 11:44:26 -04:00
Gabriel Ramírez
20ae9d305d
Fetch 100 codespaces by default 2021-10-06 14:53:55 +00:00
Gabriel Ramírez
e29a0ac7c4
Merge branch 'geramirez/codespaces-pagination' of https://github.com/geramirez/cli into geramirez/codespaces-pagination 2021-10-06 14:18:57 +00:00
Gabriel Ramírez
34f9c0a67c
Updating docs and interation exit condition to not check the final page 2021-10-06 14:18:44 +00:00
Gabriel Ramírez
237fdd40c8
Update internal/codespaces/api/api.go 
Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-10-06 09:03:49 -05:00
Jose Garcia
017632d63d Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt 2021-10-06 09:57:39 -04:00
Jose Garcia
b2ff4c321a Remove unused structs 2021-10-06 09:25:39 -04:00
Jose Garcia
8135fdbd99 Switch GetCodespace to new API endpoint 
- Drop GetCodespaceToken as it is no longer necessary
- Introduces new behavior with the API to optionally include connection
  details in the GET request. Ommitting to do so results in a faster
  response
 2021-10-06 08:50:42 -04:00
Gabriel Ramírez
aa49a3a557
Adding a second condition just in case 2021-10-05 21:43:28 +00:00
Gabriel Ramírez
61b0fe36b2
Adding additional tests for mid-flight deletions and additions 2021-10-05 21:31:47 +00:00
Gabriel Ramírez
02145cc4fd
Updated PR with suggestions 
- created a new method  to avoid defer pileup issue
- removed extra api call at the end of the sequence
 2021-10-05 21:15:24 +00:00
Gabriel Ramírez
c6dc50983d
Update internal/codespaces/api/api.go 
Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-10-05 15:33:22 -05:00
Gabriel Ramírez
4314f734e3
Update internal/codespaces/api/api.go 
Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-10-05 15:33:16 -05:00
Gabriel Ramírez
e793a5961d
Add strconv 2021-10-05 19:00:21 +00:00
Gabriel Ramírez
fd5894d28d
Merge remote-tracking branch 'upstream/trunk' into geramirez/codespaces-pagination 2021-10-05 18:58:23 +00:00
Gabriel Ramírez
409cd9c388
Fixing Has() issue due to go version 2021-10-05 18:49:41 +00:00
Jose Garcia
7fe8357d40 Better short name 2021-10-05 13:30:17 -04:00
Jose Garcia
a8d1718f21 Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt 2021-10-05 12:57:11 -04:00
Gabriel Ramírez
777978644c
Adding pagination to list codespaces 2021-10-05 16:49:40 +00:00
Jose Garcia
616d6c2db1
Merge pull request #4431 from cli/jg/get-skus-public 
codespace machine: switch `API.GetCodespacesMachines` to use new API
 2021-10-05 12:44:38 -04:00
Jose Garcia
975bd7c08a Change choose codespace prompt 
- Repo + branch is favored
- Codespace name is included to disambiguate between two codespaces
- Move Codespace model out of out API into its own package
- Update call sites and group behavior under codespace.Codespace
 2021-10-05 11:23:12 -04:00
Jose Garcia
3652307cf3
Merge pull request #4429 from cli/jg/start-codespace-public 
codespace create: update `API.StartCodespace` to use new API endpoint
 2021-10-05 09:20:33 -04:00
Jose Garcia
e0db10e4dd Switch API.GetCodespacesMachines to use new API 
- The SKU terminology is also dropped in favor of "machine" which
  matches the nomenclature of the rest of the product.
 2021-10-04 13:40:18 -04:00
Jose Garcia
a3efb53c44 Update API.StartCodespace to use new API endpoint 
- Switch to using name instead of GUID
- Remove GUID from the code since it is not used anywhere else
- Add docs to the api client methods
- Re-gen mocked client
 2021-10-04 08:32:02 -04:00
Jose Garcia
61af29bb96 Update telemetry path 2021-10-01 13:02:29 -04:00
Jose Garcia
6b1876161d Update DeleteCodespaces to new API endpoint 
- Drop the need for the user argument
- Update mocks
- Remove no longer applicable TODO comment
- Show message for successful deletion (this regressed)
 2021-10-01 12:53:35 -04:00
Jose Garcia
86a4706ed2 Update startCreate to use new API endpoint 
- Updates the signature of startCreate
- Can't update API.CreateCodespace just yet until we support expanded
  access on the GET codespace endpoint which is used for polling
 2021-10-01 11:29:16 -04:00
Jose Garcia
05297b8c8d Update ListCodespaces to use new API endpoint 
- Removes the need for a User to list codespaces which should result in
  a slight speed improvement.
 2021-10-01 10:37:15 -04:00
Jose Garcia
b5bbb442fd Move internal/api to internal/codespaces/api 2021-09-30 11:06:43 -04:00