Mislav Marohnić
e53d02b680
Add back isolated tests for issue/PR lookup by argument
2021-03-22 12:55:04 +01:00
Mislav Marohnić
111e8dbcf2
Pass web browser to each individual command
...
This removes sensitivity to the BROWSER environment variable in tests
and makes it easier to verify the URL that the browser was invoked with
without having to stub sub-processes.
2021-03-19 21:22:37 +01:00
Nate Smith
2ab073d599
Refactor use of glamour to allow style overrides ( #3243 )
...
* Refactor use of glamour to allow style overrides
* leave the things the way they were and just expose the ability to set overrides
2021-03-19 16:29:32 +00:00
Mislav Marohnić
d5fb817dfc
Remove unnecessary BodyFile field
2021-03-15 15:12:41 +01:00
Cristian Dominguez
8bfe64d593
Accept --body-file flag if --body is supported
2021-03-15 15:12:41 +01:00
Mislav Marohnić
e96d974331
Merge pull request #3023 from cli/cancel-error-status
...
Issue/pr create: exit with nonzero status code when "Cancel" was chosen
2021-03-04 13:45:11 +01:00
Mislav Marohnić
2ebdde1ddd
Exit with status code "2" on user cancellation errors
...
This also stops printing "interrupt" after Ctrl-C is pressed.
2021-03-02 13:48:44 +01:00
Mislav Marohnić
3efa764305
Avoid the issue/pr recovery mechanism handling Ctrl-C keypress in prompts
...
Either InterruptErr or SilentErr will be present when the user has
chosen "Cancel" or pressed Ctrl-C in prompts. We don't want the recovery
mechanism to kick in these cases because the cancellation was likely
willingly initiated by the user.
2021-02-23 20:09:03 +01:00
Mislav Marohnić
fff051468e
Avoid triggering recovery mechanism when cancelling issue/pr create
2021-02-23 19:42:41 +01:00
Mislav Marohnić
b0b90afa87
issue/pr create: exit with nonzero status code when "Cancel" was chosen
...
This is to indicate that the command had not finished successfully.
2021-02-23 17:06:29 +01:00
Mislav Marohnić
fee7adf9ba
Add issue create -F <file> flag and tests
2021-02-23 14:25:32 +01:00
Mislav Marohnić
3b117e6c3c
Merge pull request #2539 from divyaramanathan/issue-create-template
...
Implementing issue template GraphQL API call
2021-02-17 17:59:42 +01:00
Mislav Marohnić
0cd5744398
Un-export HasAPI leaky abstraction
2021-02-17 17:08:50 +01:00
Sam Coe
4fdf28d8a4
Change behavior of slice flags for issue edit and pr edit commands
2021-02-12 14:42:21 -08:00
Sam Coe
a47ee660a7
Pr edit command
2021-02-12 10:08:44 -08:00
Mislav Marohnić
3ddd93793c
Port issue create to using templates API
2021-02-10 17:32:00 +01:00
Sam Coe
cd9f211826
Remove unused code
2021-02-09 09:48:58 -08:00
Sam Coe
4ed94c2a06
Fix up flag descriptions
2021-02-08 09:59:30 -08:00
Sam Coe
68f71d82a0
Remove webmode
2021-02-08 09:17:04 -08:00
Sam Coe
b366802aa1
Edit issue command
2021-02-04 10:54:34 -08:00
Mislav Marohnić
051fbbc1e1
Merge remote-tracking branch 'origin' into dpromanko/remove-set-cmd-prepare
2021-01-28 22:00:08 +01:00
Nate Smith
d91b3121c8
Merge pull request #2839 from kevinmbeaulieu/kb/delete-issue-cmd
...
Add `issue delete` command
2021-01-27 16:41:30 -08:00
Kevin Beaulieu
4b036f6675
Skip confirmation for non-interactive contexts
2021-01-27 16:31:23 -08:00
Devon Romanko
2964895a77
fix test behavior changes from migration to run.Stub
2021-01-27 18:46:29 -05:00
Sam Coe
52bdcad8ea
Do not display minimized comments
2021-01-27 08:14:46 -08:00
Devon Romanko
9dcd3fbacf
use Stub instead of SetPrepareCmd in 'issue create' tests
2021-01-26 08:24:22 -05:00
Devon Romanko
3068d80a27
use Stub instead of SetPrepareCmd in 'issue view' tests
2021-01-26 08:15:43 -05:00
Devon Romanko
877cbbb5dc
use Stub instead of SetPrepareCmd in 'issue list' tests
2021-01-26 08:14:29 -05:00
Kevin Beaulieu
4468a5c950
Update tests to handle confirmation
2021-01-25 18:24:52 -08:00
Kevin Beaulieu
e7df220b01
Add confirmation prompt
2021-01-25 18:03:45 -08:00
vilmibm
d0fe1ce61b
Merge remote-tracking branch 'origin/trunk' into kb/delete-issue-cmd
2021-01-25 10:16:18 -08:00
Mislav Marohnić
70c4cbf240
Merge remote-tracking branch 'origin' into success-icon-consistency
2021-01-25 14:57:04 +01:00
Mislav Marohnić
f46bab256c
Rename to SuccessIconWithColor
2021-01-25 14:56:39 +01:00
Mislav Marohnić
d465b7f5d5
Freeze time in issue view test
2021-01-25 13:46:30 +01:00
Kevin Beaulieu
57d5470df9
Add issue delete command
...
Similar to `issue close`, but for deleting an issue rather than
just closing it.
Resolves cli/cli#2820 .
2021-01-24 15:08:19 -08:00
Mislav Marohnić
96fa6e7830
Merge remote-tracking branch 'origin' into success-icon-consistency
2021-01-22 23:56:54 +01:00
Mislav Marohnić
23d68705bc
Match color of the success icon with the end state of the record
2021-01-22 23:55:33 +01:00
AliabbasMerchant
1c54db4919
fix: Project Argument working along with --web flag
2021-01-22 23:07:00 +01:00
Mislav Marohnić
e334a1f10c
Add docs for using @me to reference self
2021-01-22 22:14:47 +01:00
Mislav Marohnić
28c2d042e7
Extend @me replacing behavior to issue list
2021-01-22 22:05:33 +01:00
Marc Lopez
6ad0c57a31
issue/pr create: add "@me" syntax to self-assign
...
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
2021-01-22 20:41:17 +01:00
Mislav Marohnić
06cf2c9f81
Merge remote-tracking branch 'origin' into cmd-stub-new
2021-01-22 16:31:29 +01:00
Sam Coe
a26fba7800
Comment on pull requests
2021-01-21 09:47:38 -08:00
Mislav Marohnić
4158209d50
Merge pull request #2811 from cli/utils-spinner-buh-bye
...
Retire utils.Spinner in favor of IOStreams.StartProgressIndicator
2021-01-21 17:34:39 +01:00
Sam Coe
b9b1079493
Display reviews when viewing pull requests
2021-01-20 12:15:25 -08:00
Mislav Marohnić
a2bee1fad3
🔥 utils.Spinner
2021-01-20 14:48:14 +01:00
Mislav Marohnić
75ebb863e3
Use testify assertions for error matching
2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087
Equal: flip arguments position
2021-01-18 21:00:59 -03:00
Mislav Marohnić
fc77cbc964
Deprecate test.ExpectLines
...
For asserting command output, exact string matches are preferred in most cases. In cases when a pattern match is needed, the test can use regexp ad hoc.
2021-01-18 23:25:45 +01:00
Mislav Marohnić
c308f1cd91
Prevent further use of SetPrepareCmd and InitCmdStubber
2021-01-18 22:44:53 +01:00
