Commit graph

602 commits

Author SHA1 Message Date
Victor Martinez
c0658b7ab4
feat: support dry-run in gh pr create (#8376) 2024-03-14 16:28:53 +01:00
Andy Feller
2b2571eb23 Fix breaking test for PR/issue # change 2024-03-01 16:04:24 -05:00
Andy Feller
bcdc917f08 Enhance 2nd round of issue and PR number output 2024-03-01 15:42:43 -05:00
Andy Feller
3bb5f54073 Apply first round of owner/repo#number consistency
This commit expands on @nobe4 initial work by bringing the owner and repository name to the most obvious issue and PR number output use cases before making a second pass for any edge cases.
2024-03-01 14:03:18 -05:00
nobe4
a5b7c6122d
fix: format files 2024-03-01 13:35:09 +01:00
nobe4
db93444ba9
feat(merge): add owner/repo in prompt
Various places during the `gh pr merge` flow show the PR number and
title. Those places are updated to also show the owner/repo.

E.g.
Before:
  Pull request #123 (title) is ready to be merged
After:
  Pull request owner/repo#123 (title) is ready to be merged

There are other places, where only the number is displayed. Those were
intentionally left as is. It made sense to show the owner/repo only when
the extra context of the title was present.

It also fixes the related tests.

cc #8777
2024-03-01 13:26:20 +01:00
William Martin
2ee6737053 Use regex to split apart the git client Commit logs
Theoretically this should be clearer and more robust than the previous
version which had some custom loop logic while trying to parse newlines
and determine whether it had reached a new commit entry by trying to parse
a git sha. This would not have worked correctly if a commit body contained
a sha on a new line.
2024-02-27 20:49:00 +01:00
William Martin
2b0484f5aa Use null byte separators when fetching comments from git 2024-02-27 18:00:40 +01:00
William Martin
658e7ac889 Ensure PRs with one commit have title and body prefilled 2024-02-16 16:30:44 +01:00
William Martin
14617e59e9 Update test to run against trunk 2024-02-16 16:30:00 +01:00
William Martin
237f6e3435 Test PR create uses commit title and body when only one commit 2024-02-16 16:19:02 +01:00
Zack Sloane
f70bcba779 switch to [] characters for default info in usage strings 2024-02-01 21:35:31 +00:00
Zack Sloane
15166f485a
Merge branch 'cli:trunk' into trunk 2024-02-01 16:27:12 -05:00
Federico Guerinoni
3409d068d4 Make commit title in bold 2024-02-01 09:12:06 +01:00
Federico Guerinoni
42613172bd pr: Add flag fillverbose
This is used to fill the body of PR with all commits msg + body
of every commits because there can be lot of useful information.

Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com>
2024-02-01 09:12:04 +01:00
Arun
e623f70a47
Specify refspec to push to the correct branch in the event of a conflicting tag 2024-01-24 11:14:35 -08:00
Zack Sloane
3339e62666
Merge branch 'cli:trunk' into trunk 2024-01-24 12:42:25 -05:00
Florian Forster
7164f6e225
fix: Prevent nil dereference in pr view. (#8566)
The API may return a `null` project, maybe related to "legacy projects". This
is translated to a nil pointer in Go. When accessing `project.Column`, the nil
pointer was dereferenced, causing a segmentation fault.
2024-01-17 22:12:22 +00:00
Zack Sloane
b6dadfa7fb test update, more consistent default value display 2024-01-08 23:23:24 -05:00
Andy Feller
c7c74dd422
Merge pull request #8342 from muzimuzhi/docs/unify-markup
Unify doc mark-ups
2023-12-01 09:31:36 -05:00
Andy Feller
8ab2f50e3e
Merge branch 'trunk' into prmerge 2023-12-01 08:00:31 -05:00
ffalor
74e5e84d71
Update pkg/cmd/pr/merge/merge.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2023-11-30 18:51:09 -06:00
William Martin
e775bc64b8 Fix PR and Issue list
Separate the GQL and JSON decoded types that we use for queries.
2023-11-27 17:00:10 +01:00
William Martin
7aeccdb7a0
Update pkg/cmd/pr/shared/finder_test.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2023-11-27 15:18:13 +01:00
William Martin
b96a8e3c01 Add PR Finder test to cover projectItems 2023-11-27 10:40:09 +01:00
ffalor
ed68930c64 print info about merge when interactive 2023-11-26 18:44:52 -06:00
Yukai Chou
b14da6c63f Wrap scopes 2023-11-23 07:22:57 +08:00
Yukai Chou
afbdb945bc Small docs tweaks 2023-11-23 07:14:38 +08:00
Yukai Chou
b70c28ba20 Misc docs improvements 2023-11-17 01:32:28 +08:00
Yukai Chou
896101678f Wrap cli commands in backticks uniformly 2023-11-17 01:32:00 +08:00
Yukai Chou
17d336e005 Wrap cli flags in backticks uniformly 2023-11-16 22:54:27 +08:00
Sam Coe
7924878315
Fix git protocol and refactor Config interface (#8246) 2023-10-27 15:42:05 +02:00
Sam Coe
5023b61909
Remove uses of FuzzyAgoAbbr in tables (#8222) 2023-10-22 17:33:49 +02:00
Heath Stewart
7738b6187c
Add headers to all tables (#8157) 2023-10-20 11:20:02 +02:00
William Martin
6dc04bb1e2 Remove GetOrDefault uses in favour of GitProtocol 2023-10-19 12:57:19 +02:00
Carl Walsh
3443a752a9
docs: fix typo in pr create (#8115)
https://cli.github.com/manual/gh_pr_create shows `BADINDEX` and broken markdown formatting right now.
Was very recently introduced in #8080
2023-10-03 17:20:02 +00:00
Andy Feller
8d53e246f2
Merge pull request #8080 from peterramaldes/3888-document-explicitly-fill-flag
docs: update the flag `--fill` docs
2023-10-03 08:30:30 -04:00
Peter A. Ramaldes
c10371605c
Update pkg/cmd/pr/create/create.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2023-10-02 14:46:02 -03:00
Peter Admilson Ramaldes
d4668c599e docs: update the details of fill and fill-first 2023-09-28 06:00:54 -03:00
Peter Admilson Ramaldes
756d9a07d0 docs: update the flag --fill docs
The `--title` and/or `--body` could be overwritten when use `--fill`
togheter, so, this change makes this behavior more evident
2023-09-25 07:26:33 -03:00
Raj Hawaldar
decbbd2165
Show cancelled checks (#7960) 2023-09-24 18:27:01 +02:00
Raj Hawaldar
9fc571499f
pr checks return distinct exit code for PENDING checks (#7866) 2023-08-25 10:30:45 -07:00
Nate Smith
bff4727331 linter appeasement 2023-08-17 17:17:26 -05:00
Nate Smith
4382efdf69 prompter for milestone 2023-08-17 15:58:38 -05:00
Nate Smith
6a4dbf9db3 prompter for projects 2023-08-17 15:54:46 -05:00
Nate Smith
abf49d1322 use prompter for labels 2023-08-17 15:50:55 -05:00
Nate Smith
542c154d07 prompter for assignees 2023-08-17 15:45:04 -05:00
Nate Smith
f867eff04d prompter for reviewers 2023-08-17 15:41:12 -05:00
Nate Smith
a3539d4f24 use MultiSelect for metadata survey in pr, issue create 2023-08-17 15:29:47 -05:00
Nate Smith
f04e3398ed use prompter in shared editable code 2023-08-17 11:28:01 -05:00