Commit graph

7338 commits

Author SHA1 Message Date
Nate Smith
c1e5934b21
Merge pull request #5272 from meiji163/pin-ext 2022-03-29 09:21:20 -05:00
Mislav Marohnić
52576c2039
Merge pull request #5367 from cli/dependabot/go_modules/github.com/creack/pty-1.1.18
Bump github.com/creack/pty from 1.1.17 to 1.1.18
2022-03-29 16:17:31 +02:00
Mislav Marohnić
07cd7496c5
Merge pull request #5225 from cli/extract-to-root
run download: fix extracting to root path
2022-03-29 16:16:34 +02:00
Mislav Marohnić
3f5311ea1c
Merge pull request #5345 from znull/znull/ssh-config-example
ssh.go: use setup example that should work with any ssh config
2022-03-29 16:15:56 +02:00
Jimmy Keith
ce8f66b421
Have extension upgrade --all be non-fatal when no extensions installed (#5356) 2022-03-29 16:15:25 +02:00
Mislav Marohnić
91c450ec60
Merge pull request #5357 from callumacrae/force-tty-pr-view
fix: respect `GH_FORCE_TTY` when running `gh pr view`
2022-03-29 16:12:45 +02:00
Jeff Hubbard
9554e522af Change the way we parse list-devcontainers response 2022-03-28 14:24:57 -07:00
Jeff Hubbard
03b8b16585 Merge branch 'trunk' of ssh://github.com/cli/cli into multi-devcontainer 2022-03-28 13:59:01 -07:00
nate smith
058c2b4fe3 redundant 2022-03-28 11:55:07 -05:00
nate smith
f22c325ea4 gh status 2022-03-28 11:53:13 -05:00
dependabot[bot]
66abe7c115
Bump github.com/creack/pty from 1.1.17 to 1.1.18
Bumps [github.com/creack/pty](https://github.com/creack/pty) from 1.1.17 to 1.1.18.
- [Release notes](https://github.com/creack/pty/releases)
- [Commits](https://github.com/creack/pty/compare/v1.1.17...v1.1.18)

---
updated-dependencies:
- dependency-name: github.com/creack/pty
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-28 14:29:18 +00:00
Sam Coe
ee6fc0f9b7
Add search issues and search pull requests commands (#5334) 2022-03-27 19:53:03 +00:00
Callum Macrae
f7ef503051 fix: respect GH_FORCE_TTY when running gh pr view
`GH_FORCE_TTY` only affects stdout, not stderr, so this check was
failing and the flag was being ignored.

I also checked for similar problem in other files but everything else
seemed stderr or stdin related.

closes #5354
2022-03-25 15:07:47 +00:00
Gabe D
3a949203c4
Update Codespace permissions opt out param (#5344) 2022-03-25 12:12:14 +01:00
dependabot[bot]
ad313f77f7
Bump github.com/AlecAivazis/survey/v2 from 2.3.2 to 2.3.4 (#5337)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-03-24 15:54:40 +01:00
Caleb Brose
1b01733ce5
Merge pull request #5340 from cli/cmbrose/scp-args
`gh cs cp` parses additional scp args
2022-03-24 09:53:54 -05:00
Jason Lunz
17cb6346a5
ssh.go: use setup example that should work with any ssh config
The `gh cs ssh` command suggests an example recipe for setting up
openssh integration. The last step appends an `Include` statement to the
user's `~/.ssh/config`.

Unfortunately, this won't always work as intended. If the existing
configuration ends with a `Host` block, the added `Include` statement
will be conditional on whether that block matches.

By preceding the `Include` statement with `Match all`, we can ensure
that it is always evaluated.
2022-03-23 17:00:36 -06:00
Caleb Brose
623e67f6b1 Update comments/usage and remove -- 2022-03-23 16:09:07 +00:00
Oleg Solomka
783f316df1 [codespaces]: add hidden select command 2022-03-23 00:26:50 +00:00
meiji163
45845bc999 cant pin local 2022-03-22 11:02:16 -07:00
Meijke Balay
348bb70fa5 Merge remote-tracking branch 'upstream/trunk' into pin-ext 2022-03-22 08:13:53 -07:00
Caleb Brose
a03051f295 Refactoring and comments 2022-03-22 14:49:58 +00:00
Caleb Brose
f22320a478 Parse scp args 2022-03-22 01:57:37 +00:00
Mislav Marohnić
65d90aa24d
Merge pull request #5336 from cli/dependabot/github_actions/actions/cache-3
Bump actions/cache from 2 to 3
2022-03-21 17:57:59 +01:00
Jose Garcia
c7bd3f8626
Merge pull request #5339 from cli/jg/fix-flakey-test
liveshare test: only sleep if conn is nil
2022-03-21 12:22:05 -04:00
Jose Garcia
b5a7a36ece Document why we have a loop retrying 2022-03-21 12:11:00 -04:00
Jose Garcia
cd6176d911 Rename to tries and clean up loop condition 2022-03-21 11:42:32 -04:00
Jose Garcia
74c8b2217e Increment retries 2022-03-21 11:36:12 -04:00
Jose Garcia
107ea6c440 Only sleep if conn is nil 2022-03-21 11:09:52 -04:00
dependabot[bot]
b090ef0578
Bump actions/cache from 2 to 3
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](https://github.com/actions/cache/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-21 14:27:30 +00:00
Mislav Marohnić
b7bdb369f1
Merge pull request #5327 from sgray/patch-1
Remove unwanted trailing quote
2022-03-21 14:50:08 +01:00
chemotaxis
e25c36a7b1 Stub out files for lock command
Lock will lock and unlock both issues and pull requests
2022-03-19 16:58:51 -04:00
Jeff Hubbard
125a7b00a2 Fix tests 2022-03-18 14:44:15 -07:00
Steve Gray
b48a93cddf
Remove unwanted trailing quote
Removes a stray quote from the codespace ssh example.
2022-03-18 14:06:27 -06:00
Jeff Hubbard
8abf50be1d Change some copy per product's suggestions 2022-03-18 10:10:57 -07:00
Matthew Gabeler-Lee
be07983a62
Only write UTF-8 BOM on Windows where it is needed
Fixes #5239
2022-03-17 11:40:49 -04:00
Josh Gross
31c6ba3807
Support listing and removing Dependabot secrets (#5160)
* Support listing and removing Dependabot secrets

* Remove duplicated tests
2022-03-17 11:42:12 +02:00
Bernardo
652c88769b
Merge pull request #5270 from cli/jg/event-handling
Codespaces: Listen to agent port-forwarding events when forwarding ports
2022-03-16 15:03:31 -07:00
Bernardo
2e3400a8af Merge branch 'trunk' into jg/event-handling 2022-03-16 20:51:47 +00:00
Bernardo
c70e2a345e allow 2 go routines to send 2022-03-16 20:34:51 +00:00
Jeff Hubbard
ce3d0791c3
Merge branch 'trunk' into multi-devcontainer 2022-03-16 12:51:03 -07:00
Charlie Andrews
bb4fc52199
Merge pull request #5319 from cwndrws/cwndrws/codespaces/handle-codespaces-with-pending-operations
[Codespaces] Disallow some operations on codespaces that have a pending operation
2022-03-16 11:29:06 -04:00
Mislav Marohnić
f3f14555f8
Merge pull request #5323 from cli/dependabot/go_modules/github.com/stretchr/testify-1.7.1
Bump github.com/stretchr/testify from 1.7.0 to 1.7.1
2022-03-16 15:39:58 +01:00
dependabot[bot]
311b9bd380
Bump github.com/stretchr/testify from 1.7.0 to 1.7.1
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-16 14:25:15 +00:00
Charlie Andrews
4eedfc05c1 Add docs link comment to Codespaces struct definition 2022-03-16 10:20:13 -04:00
Charlie Andrews
7ca31e02b4 Disallow editing a codespace that has a pending operation
This is already prevented by the API, but this will make the error
message cleaner and easier to understand for the user.

Example of old error message:

```
$ gh cs edit -c cwndrws-redacted -d "some silly name"
error editing codespace: HTTP 422: your codespace has an operation pending: updating to a sku with a different amount of storage; please wait until this operation is complete (https://api.github.com/user/codespaces/cwndrws-redacted)
exit status 1

```

Example of new error message:

```
$ gh cs edit -c cwndrws-redacted -d "some silly name"
error editing codespace: codespace is disabled while it has a pending operation: Changing machine types...
exit status 1
```
2022-03-16 10:13:46 -04:00
Charlie Andrews
64eecef176 Remove unhelpful error wrapper 2022-03-16 09:36:14 -04:00
Charlie Andrews
a2f76fdfe0 Fix copy pasta error to appease the linter 2022-03-16 09:10:54 -04:00
Charlie Andrews
8bf0cb8f13 Refactor the getOrChooseCodespace to always check for pending ops 2022-03-16 08:56:17 -04:00
Charlie Andrews
10e43b5136 Use color variable instead of literal for disabled reason 2022-03-16 08:43:34 -04:00