STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
6356 commits 87 branches 0 tags 160 MiB
Commit graph

380 commits

Author SHA1 Message Date
Robin Neatherway
78fb90956c
Teach gh cs create to use current repo as default (#6596) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2023-02-07 20:05:38 +00:00
Luan Vieira
d4c9890c5a
Default to authenticated user on codespace delete (#6944) 
When a username option is not provided for the `gh codespace delete`
command, we will use the authenticated user's login as the default to
avoid deleting anyone else's codespace by mistake.

Prior to this change, running `gh codespace delete --org MYORG --all`
would fetch all of the codespacese associated with the org regardless of
user and then only delete the ones associated with the authenticated
user, which would lead to 404 errors when MYORG had codespaces owned by
members other than the authenticated member.

Co-authored-by: Victoria Dye <vdye@github.com>
Co-authored-by: Lessley Dennington <ldennington@github.com>
 2023-02-07 20:46:08 +01:00
Caleb Brose
90ae71b2ba
Merge pull request #6888 from cli/cmbrose/pf-half-close 
Half close port forwarding connections to fix hangs
 2023-01-23 14:26:19 -06:00
Ryan Caldwell
71ec2c4e23
Codespaces create: Fix missing billable owner notice for individuals (#6891) 2023-01-23 13:15:44 +01:00
Caleb Brose
2b95cbc5a6 Close port forward writer on reader 2023-01-19 20:22:24 -06:00
David Gardiner
ce6b7d8762 Start SSH server with gRPC 2023-01-10 11:59:56 -08:00
David Gardiner
839378d5cb
Merge pull request #6657 from dmgardiner25/codespaces-rpc-invoker 
Create centralized Codespaces RPC invoker
 2023-01-06 12:58:44 -08:00
David Gardiner
814fcf8c74 Remove unused token field 2023-01-06 09:56:16 -08:00
John Keech
791c7db632
Fix typo in has_uncommitted_changes for codespaces (#6812) 
The REST API for codespaces returns the following schema:
```
"git_status": {
    "ahead": 0,
    "behind": 0,
    "has_unpushed_changes": false,
    "has_uncommitted_changes": false,
    "ref": "main"
  },
  ```

  The CLI was looking for `has_uncommited_changes` in the response instead of `has_uncommitted_changes`, leading to it always reporting a `false` value which could be different than the API response.
 2023-01-05 22:02:32 +00:00
David Gardiner
000a84d49b Address comments 2023-01-04 15:33:33 -08:00
David Gardiner
731ba682f2 Create Invoker object 2023-01-04 14:41:25 -08:00
David Gardiner
1e75a74d18 Create centralized Codespaces RPC invoker 2023-01-04 14:41:25 -08:00
Des Preston
4ade907ae8
Allow setting codespace display name during create (#6739) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2022-12-19 17:10:34 +01:00
Caleb Brose
56006eefa6 Flags instead of PersistentFlag 2022-12-13 01:20:49 +00:00
Caleb Brose
57c53e6268 linter 2022-12-12 21:21:23 +00:00
Caleb Brose
8e0b4ef21b Use -R for --repo shorthand and deprecate -r 2022-12-12 19:44:59 +00:00
Mislav Marohnić
e4f5545e86
Go 1.19: fix comment formatting for moq-generated mocks 2022-12-12 16:58:25 +01:00
Sam Coe
6dbe7e6342
Linter fixes (#6722) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2022-12-12 15:27:32 +00:00
Jake Shorty
1cb62b182c Use new domain for forwarded ports 2022-12-08 18:36:26 +00:00
JP Ungaretti
925edf3892 Add long description 2022-11-01 22:35:39 +00:00
JP Ungaretti
a29820ebe3 Use incremental rebuild by default 2022-11-01 21:00:14 +00:00
Ashwin Jeyaseelan
a756ffb1e8
Fix Codespace Creation Devcontainer bug (#6389) 2022-10-18 11:11:28 +03:00
Mislav Marohnić
3fe5026d39
Migrate to tableprinter from go-gh (#6346) 2022-10-17 15:15:39 +02:00
David Gardiner
f80f566ab2
Merge pull request #6358 from dmgardiner25/dmgardiner25/grpc-client 
Implement gRPC client and `GetRunningServer` method
 2022-10-11 10:45:50 -07:00
Jose Garcia
a356a1bef0 no need to ignore cancel 2022-10-11 13:15:34 -04:00
Jose Garcia
e11b43f8f6 Fixes for handling the grpc client lifecyle 2022-10-11 08:55:14 -04:00
David Gardiner
f89b1b6a45 Create timeout context in caller 2022-10-10 14:39:12 -07:00
JP Ungaretti
982aa5ba82 Rename RPC command to RebuildContainer 2022-10-10 21:01:29 +00:00
JP Ungaretti
0e963ebd4f Move codespace construction to its test 2022-10-09 01:11:04 +00:00
JP Ungaretti
d05cdf5ff3 Tidy up comments and errors 2022-10-08 06:30:42 +00:00
JP Ungaretti
4c49fd3e64 Add rebuild command 2022-10-08 06:12:36 +00:00
JP Ungaretti
da91216c31 Add new Rebuild function 2022-10-08 00:04:45 +00:00
David Gardiner
766e6a2314 Use existing context 2022-09-29 09:58:44 -07:00
Anthony Fok
f6d0f82701
Fix missing text in gh-codespace-ssh.1 man page 
Rearrange the long help text so that '--config' does not appear at the
start of a line which groff interprets as an undefined macro and skips
the content of that whole line.

To reproduce:

  $ go run cmd/gen-docs/main.go --man-page --doc-path /tmp/gh-manpages
  $ man --warnings -E UTF-8 -l -Tutf8 -Z /tmp/gh-manpages/gh-codespace-ssh.1 >/dev/null
  troff: <standard input>:26: warning: macro '--config'' not defined

Discovered by the Debian Lintian tool.
 2022-09-28 14:00:37 -06:00
David Gardiner
35d2cf30d0 Send session token 2022-09-28 11:28:35 -07:00
David Gardiner
3f34d6d95e Make suggested gRPC client changes 2022-09-28 10:39:26 -07:00
Caleb Brose
cc98ffd6fa Ensure local keys don't interfere with ssh_test 2022-09-21 19:43:31 +00:00
Caleb Brose
bb6db4b309 PR suggestions 2022-09-20 22:00:27 +00:00
Caleb Brose
4a8047ed61 Improve error handling 2022-09-20 19:36:07 +00:00
Caleb Brose
deedd35a2c Merge branch 'cmbrose/no-ssh-api-call' of https://github.com/cli/cli into cmbrose/no-ssh-api-call 2022-09-20 18:32:01 +00:00
Caleb Brose
373634ad75 Rename to generateAutomaticSSHKeys 2022-09-20 18:32:00 +00:00
Caleb Brose
045bb54157
Apply suggestions from code review 
Co-authored-by: Jose Garcia <josebalius@github.com>
 2022-09-20 13:22:38 -05:00
Caleb Brose
049a3676f4 Use filepath instead of path 2022-09-20 15:59:38 +00:00
Caleb Brose
3b52df6f99 Don't add private key for -i 2022-09-20 15:21:59 +00:00
Caleb Brose
dba1259d32 Update tests 2022-09-20 01:02:06 +00:00
Caleb Brose
0c00ca911e Clean up API interface 2022-09-16 22:25:11 +00:00
Caleb Brose
939c7c71cd Remove API call for ssh keys 2022-09-16 22:22:13 +00:00
Sam Coe
a30de8d72a
Output paid message for codespace create to stderr not stdout (#6258) 2022-09-14 11:33:55 +00:00
Sam Coe
e7102f9d84
Migrate to go-gh text package (#6236) 2022-09-14 09:23:55 +04:00
Mislav Marohnić
a6636994bf
Disable flakey ports update visibility tests (#6203) 2022-09-06 15:31:36 +00:00