Commit graph

148 commits

Author SHA1 Message Date
Tyler McGoffin
fea46c0011 Change ReadBranchConfig error message in gh pr create 2025-01-08 11:40:42 -08:00
Tyler McGoffin
bf6fdbdfd2 Remove named returns from ReadBranchConfig and surface errors 2025-01-07 13:54:43 -08:00
William Martin
c3b41e87b8 Panic mustParseTrackingRef if format is incorrect 2025-01-06 10:33:28 -06:00
William Martin
8b5073d617 Move trackingRef into pr create package 2025-01-06 10:33:28 -06:00
William Martin
62ecb1c84d Make tryDetermineTrackingRef tests more respective of reality
Though it doesn't really matter, in practice upstream is always going to come before origin.
2025-01-06 10:33:28 -06:00
William Martin
b8c167970b Avoid pointer return from determineTrackingBranch 2025-01-06 10:33:28 -06:00
William Martin
27bd4b2aec Doc determineTrackingBranch 2025-01-06 10:33:28 -06:00
William Martin
05764b8114 Don't use pointer for determineTrackingBranch branchConfig 2025-01-06 10:33:28 -06:00
William Martin
dc077dc09b Panic if tracking ref can't be reconstructed 2025-01-06 10:33:28 -06:00
William Martin
3ae4e5da20 Document and rework pr create tracking branch lookup 2025-01-06 10:33:28 -06:00
Caleb Brose
9d490547b8
Alternative: remove LocalBranch from BranchConfig 2025-01-03 20:39:12 +00:00
Heath Stewart
78836097c3
Document how to set gh-merge-base
Follow-up to PR #9712
2024-12-20 10:49:38 -08:00
William Martin
54a7f4de70 Revert "Confirm auto-detected base branch"
This reverts commit e021a07285.
2024-12-09 13:01:00 +01:00
Heath Stewart
e021a07285
Confirm auto-detected base branch
If interactive, confirm the automatically configured gh-merge-branch or, if not configured, the default branch.

Based on PR feedback.
2024-12-08 22:27:00 -08:00
Heath Stewart
5da86e07e7
Merge changes from #10004
Merges changes from @williammartin including acceptance tests and word changes.

Co-authored-by: William Martin <williammartin@github.com>
2024-12-08 20:34:21 -08:00
Heath Stewart
3d139019f8
Open PR against gh-merge-base
Partly resolves issue #8979 by checking for a `gh-merge-base` branch tag and using that as though it were passed to `gh pr create --base`.
2024-12-08 17:40:00 -08:00
nilvng
a780b488a3 fix: ignore template flag 2024-11-07 10:20:23 +11:00
Tyler McGoffin
be3b6cbd8d Make the X in the error message red and print with io writer 2024-10-08 16:03:14 -07:00
Andy Feller
a863dfdb30
Merge pull request #9433 from benebsiny/cli-9310
Add `pr create --editor`
2024-08-12 10:10:18 -04:00
Andy Feller
369a105c45 Minor grammatical fix 2024-08-12 10:00:37 -04:00
Tyler McGoffin
18d58b8d84
Replace --project.* flags' name with title in docs (#9443)
With the upcoming migration from v1 project to v2 projects, we'd like the
language in our documentation to align with v2 project language. In v2,
projects are referred to by `title` and not `name`, though they are
functionally equivalent under the hood for the CLI
2024-08-09 13:55:14 -07:00
benebsiny
e18c002283 Deduplicate the initialization of editor mode 2024-08-08 18:07:52 +08:00
benebsiny
e2275d7ef6 Add pr create --editor 2024-08-07 23:14:15 +08:00
William Martin
32e499e090 Add examples for template usage in PR and issue creation 2024-07-23 13:14:27 +02:00
William Martin
07e0ff7127 Fix repo fork to use remote protocol if none configured 2024-05-10 10:48:36 +02:00
William Martin
1d38230675
Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
Victor Martinez
c0658b7ab4
feat: support dry-run in gh pr create (#8376) 2024-03-14 16:28:53 +01:00
William Martin
658e7ac889 Ensure PRs with one commit have title and body prefilled 2024-02-16 16:30:44 +01:00
Zack Sloane
f70bcba779 switch to [] characters for default info in usage strings 2024-02-01 21:35:31 +00:00
Zack Sloane
15166f485a
Merge branch 'cli:trunk' into trunk 2024-02-01 16:27:12 -05:00
Federico Guerinoni
3409d068d4 Make commit title in bold 2024-02-01 09:12:06 +01:00
Federico Guerinoni
42613172bd pr: Add flag fillverbose
This is used to fill the body of PR with all commits msg + body
of every commits because there can be lot of useful information.

Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com>
2024-02-01 09:12:04 +01:00
Arun
e623f70a47
Specify refspec to push to the correct branch in the event of a conflicting tag 2024-01-24 11:14:35 -08:00
Zack Sloane
b6dadfa7fb test update, more consistent default value display 2024-01-08 23:23:24 -05:00
Yukai Chou
b14da6c63f Wrap scopes 2023-11-23 07:22:57 +08:00
Yukai Chou
896101678f Wrap cli commands in backticks uniformly 2023-11-17 01:32:00 +08:00
Sam Coe
7924878315
Fix git protocol and refactor Config interface (#8246) 2023-10-27 15:42:05 +02:00
William Martin
6dc04bb1e2 Remove GetOrDefault uses in favour of GitProtocol 2023-10-19 12:57:19 +02:00
Carl Walsh
3443a752a9
docs: fix typo in pr create (#8115)
https://cli.github.com/manual/gh_pr_create shows `BADINDEX` and broken markdown formatting right now.
Was very recently introduced in #8080
2023-10-03 17:20:02 +00:00
Peter A. Ramaldes
c10371605c
Update pkg/cmd/pr/create/create.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2023-10-02 14:46:02 -03:00
Peter Admilson Ramaldes
d4668c599e docs: update the details of fill and fill-first 2023-09-28 06:00:54 -03:00
Peter Admilson Ramaldes
756d9a07d0 docs: update the flag --fill docs
The `--title` and/or `--body` could be overwritten when use `--fill`
togheter, so, this change makes this behavior more evident
2023-09-25 07:26:33 -03:00
Nate Smith
a3539d4f24 use MultiSelect for metadata survey in pr, issue create 2023-08-17 15:29:47 -05:00
Sam Coe
1b79e95311
Clean up style nits and simplify some logic 2023-07-11 13:34:22 +09:00
Nate Smith
4c918e90a6
Merge pull request #7398 from kousikmitra/feature/pr-fill-first
Feature: Add `fill-first` flag to `pr create`  command
2023-07-10 16:20:15 -07:00
nate smith
557127c7ca remove stray print 2023-07-10 15:16:51 -07:00
leavesster
d871da679b
Change how remotes are treated during pr create when repo is forked (#7330) 2023-06-28 04:07:42 +00:00
Kousik Mitra
38e6287fe8 Fix commit order 2023-06-23 17:47:03 +05:30
Kousik Mitra
1b9906268f Add test for fill first flag 2023-06-23 17:47:03 +05:30
Kousik Mitra
a7fdc37b5d Add fill-first option to create pr
This will add an flag --fill-first to pr create sub-command.
Which will allow users to create pr with details from first commit.
2023-06-23 17:47:03 +05:30