STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2272 commits 87 branches 0 tags 160 MiB
Commit graph

186 commits

Author SHA1 Message Date
Mislav Marohnić
ece17c4ce2 Add GITHUB_ENTERPRISE_TOKEN mention to api help 2020-09-07 21:37:55 +02:00
Mislav Marohnić
c80292c2e8 Extend Config object with GITHUB_TOKEN support 
Adding GITHUB_TOKEN & GITHUB_ENTERPRISE_TOKEN support orthogonal to
Config was getting out of hand, especially in `auth` commands that
adjust their messaging and error status based on the presence of these
environment variables.

The new approach builds in support for tokens from environment straight
into Config object by composition. Thus, commands need not ever be
concerned with any specific environment variables.
 2020-09-07 21:33:26 +02:00
Mislav Marohnić
feadf684fb Merge remote-tracking branch 'origin' into ghe-auth-tweaks 2020-09-07 17:37:16 +02:00
Mislav Marohnić
9109b68344
Merge pull request #1625 from cli/api-no-accept 
Avoid setting a default `Accept` header in `hub api`
 2020-09-07 17:30:12 +02:00
Mislav Marohnić
5e11fe8fa0
Merge pull request #1623 from bdougie/bdougie-filter-credit-bots 
Filter gh credits for humans
 2020-09-07 11:44:59 +02:00
Brian 'bdougie' Douglas
d83c99f87f filter by contributor type 2020-09-06 22:02:02 -07:00
Mislav Marohnić
995828abf8 Avoid setting a default Accept header in hub api 
Due to our HTTP client default behavior, an `Accept` header is added to
all API requests. This is fine for all commands except `gh api`, where
the user should ideally have fine-grained control over most aspects of
HTTP requests and where there should be little to no defaults in general.
 2020-09-04 17:42:57 +02:00
Mislav Marohnić
2bb5e052d8 Send GITHUB_TOKEN to github.com and GITHUB_ENTERPRISE_TOKEN to GHES 2020-09-04 17:25:37 +02:00
Mislav Marohnić
abf83c02c0
Merge pull request #1606 from cli/ghe-oauth-422-response 
Handle HTTP 422 response to OAuth Device flow detection
 2020-09-02 13:12:11 +02:00
Nate Smith
734959c39d
Merge pull request #1603 from cli/create-pr-metadata-failure 
Be transparent about which part of `pr create` flow failed
 2020-09-01 10:51:55 -05:00
Mislav Marohnić
48a827ee34 Tweak gh config set -h output format on auth login 2020-09-01 13:19:30 +02:00
Mislav Marohnić
0de3f678bc Only validate --hostname when flag was provided 2020-09-01 13:19:19 +02:00
Mislav Marohnić
b029397d32 Validate the --hostname flag value 2020-09-01 13:06:13 +02:00
Mislav Marohnić
1a051e9c44 Validate hostname as entered in the auth prompt 2020-09-01 12:59:58 +02:00
Mislav Marohnić
766e4950d9 Be transparent about which part of pr create flow failed 
When applying metadata to the new PR such as assignees or reviewers, if
the operation fails, an error message would get printed:

    failed to create pull request: <API error text>

This was misleading, because the PR did get created; it's just that
updating it failed. The new error message is:

    https://github.com/OWNER/REPO/pull/123
    pull request update failed: <API error text>

The PR URL is printed on stdout and the error message is printed on
stderr. In case of any errors, the exit code is still non-zero.
 2020-08-31 16:46:22 +02:00
Nate Smith
fd31007075
Merge pull request #1590 from colinshum/colinshum/template-repo 
[Feature] Create repositories from a template repo
 2020-08-28 14:09:12 -05:00
Colin Shum
99372f0dbc [Refactor] Add variadic argument to repoCreate to support templates 2020-08-28 15:02:08 -04:00
Sam Coe
41f42d4057 Remove reference to feedback form 2020-08-28 09:06:31 +02:00
Colin Shum
2886dd913f [Refactor] toView -> toClone 2020-08-27 19:13:06 -04:00
Colin Shum
263e3a6a35 Update create_test.go 2020-08-27 17:57:55 -04:00
Colin Shum
32e5d05328 [Fix] Warn user when --template is passed with incompatible flags 2020-08-27 15:00:57 -04:00
Colin Shum
58f62a4a15 [Feature] Create repository from template 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2020-08-27 14:46:16 -04:00
Mislav Marohnić
c21caf5b2b Disallow pr -R flag for commands that operate on the current branch 
If the `--repo` flag is specified, then the user intends to select a
repository other than the current one. In that case, it doesn't make
sense to fall back to detecting the PR belonging to the current branch,
so throw a descriptive error instead.
 2020-08-27 16:30:34 +02:00
Dan Hughes
7b8d052f0e
Add new output to existing test 2020-08-26 17:31:13 +01:00
Dan Hughes
a3aea11e5b
Include URL and number in non-TTY output 2020-08-26 17:28:17 +01:00
Nate Smith
27c49279b3
Merge pull request #1567 from ganboonhong/view-without-username 
View repositories without username
 2020-08-25 13:57:42 -05:00
Nate Smith
fc1c800042
Merge pull request #1492 from ShubhankarKG/newConfirmations 
New confirmations
 2020-08-25 13:31:47 -05:00
Nate Smith
82c6830849
Merge pull request #1548 from cli/auth-check 
new auth flow UX
 2020-08-25 10:16:23 -05:00
vilmibm
451ece198b missed a disable auth check 2020-08-25 10:10:16 -05:00
boonhong
931fee566e shorthand of view without username 2020-08-23 23:33:50 +08:00
ShubhankarKG
7955c4f2ed doSetup wasn't getting called in cases where required. 
The problem was that opts.confirmSubmit was mutated before reaching doSetup. This commit creates a copy of the initial confirmSubmit value. So the doSetup receives the initial data passed from the command, not the mutated one.
 2020-08-20 14:20:55 +05:30
ShubhankarKG
00b2777a14 Change visibility strings to Sentence case 2020-08-20 14:10:18 +05:30
Nate Smith
b9292f582f
Merge pull request #1476 from rimazk123/prclose-delete 
Add delete branch flag to pr close
 2020-08-19 21:11:48 -05:00
vilmibm
e44eb665a1 Merge remote-tracking branch 'origin/trunk' into prclose-delete 2020-08-19 21:06:04 -05:00
Nate Smith
ddfa1714d2
Merge pull request #1479 from wilso199/pr-checkout-submodules 
PR Checkout - Recurse Submodules
 2020-08-19 16:46:21 -05:00
vilmibm
16f69e9c12 fix tests 2020-08-19 16:40:13 -05:00
vilmibm
5c4f93ad0a Merge remote-tracking branch 'origin/trunk' into pr-checkout-submodules 2020-08-19 16:37:01 -05:00
Nate Smith
88b5a3b2f4
Merge pull request #1534 from mmontes11/pr-diff-use-default-pager 
Using default pager in gh pr diff
 2020-08-19 12:40:33 -05:00
vilmibm
2753f6fa48 Merge remote-tracking branch 'origin/trunk' into fix-milestone 2020-08-19 12:31:32 -05:00
vilmibm
b08255a720 bonus: GitHub Enterprise Server wording 2020-08-19 10:32:00 -05:00
vilmibm
cba401deb0 check parent annotatiosn for auth skip 2020-08-19 10:21:19 -05:00
vilmibm
621f6a262b minor 2020-08-19 10:11:16 -05:00
vilmibm
b1a6346e07 take out auto browser flow 2020-08-18 17:57:52 -05:00
vilmibm
ff9ecd2944 CTA for ghes remote auth case 2020-08-18 17:57:52 -05:00
vilmibm
850a7ef243 print nice login message when no auth detected 2020-08-18 17:57:52 -05:00
ShubhankarKG
130c5262b2 Refactor changes 2020-08-18 16:23:16 +05:30
ShubhankarKG
2b6535f951 Merge branch 'trunk' of https://github.com/cli/cli into newConfirmations 2020-08-18 11:25:43 +05:30
Martín Montes
df66a8f131 Using default pager in gh pr diff 2020-08-17 22:31:30 +02:00
Mislav Marohnić
d8c5b7bfc0
Merge pull request #1517 from cli/select-host 
Allow explicitly setting hostname for gh operations
 2020-08-14 19:08:13 +02:00
Mislav Marohnić
85f0f3aad7 Enable repo create for GHE 2020-08-14 19:02:17 +02:00