Commit graph

2695 commits

Author SHA1 Message Date
Mislav Marohnić
3e7a2585c5 Tighten git remote URL parsing
We now only support git URLs that have one of the explicitly supported protocols.
2020-09-04 16:18:26 +02:00
Mislav Marohnić
6ceea6e531
Merge pull request #1616 from cli/display-width-punctuation
Fix detecting display width of common punctuation characters
2020-09-04 16:04:43 +02:00
ShubhankarKG
05a39b732a Fix tests 2020-09-04 18:58:15 +05:30
ShubhankarKG
147cdcdbb4 Add extra confirm step and a flag 2020-09-04 18:24:31 +05:30
vilmibm
deb92f93a6 update linux installation docs 2020-09-03 14:54:35 -05:00
vilmibm
eb132a1ae6 Merge remote-tracking branch 'origin/trunk' into checks 2020-09-03 14:48:32 -05:00
vilmibm
894be03923 linux repo creation 2020-09-03 13:47:48 -05:00
Mislav Marohnić
a470d49c64 Fix reporting release URL when creating with assets 2020-09-03 16:06:28 +02:00
Mislav Marohnić
1ad9b0b14e Have FindDraftRelease be truer to its name 2020-09-03 15:35:07 +02:00
Mislav Marohnić
d4b45c68e2 Allow downloading assets from the latest release 2020-09-03 15:34:10 +02:00
Mislav Marohnić
151a7340a6 Fix .zip and .js overrides for Windows 2020-09-03 11:44:54 +02:00
Mislav Marohnić
02a057a709 Try fixing Windows tests 2020-09-02 22:11:46 +02:00
Mislav Marohnić
b93c896561 Upgrade text/width package 2020-09-02 21:01:39 +02:00
Mislav Marohnić
1f86e7cd04 Fix display width of common punctuation characters
These characters get classified as "East Asian Mixed" by Go's
`text/width` package, and thus assumed that their printed version
occupies a width of 2 characters, whereas they each only occupy one.

I'm not sure why they are classified as East Asian, but I did not have
the energy to dive into Go's Unicode tables, so here is a workaround
based on an exclusion list.
2020-09-02 20:59:11 +02:00
Sam
00836079dd
Merge pull request #1600 from cli/update-readme
Remove feedback survey from README
2020-09-02 19:42:40 +02:00
vilmibm
2961c655fb review feedback 2020-09-02 11:33:39 -05:00
Mislav Marohnić
abf83c02c0
Merge pull request #1606 from cli/ghe-oauth-422-response
Handle HTTP 422 response to OAuth Device flow detection
2020-09-02 13:12:11 +02:00
AliabbasMerchant
9e7279604d Fix failing tests for Windows (due to line-ending issues) 2020-09-02 10:03:56 +05:30
AliabbasMerchant
51c5595cad Interactive template selection test for PR create 2020-09-02 09:56:28 +05:30
Nate Smith
bf9d3ab12f
Merge pull request #1607 from cli/pwsh-tty
properly check for tty when in powershell
2020-09-01 16:16:31 -05:00
Mislav Marohnić
6933c381bf Restore Go 1.13 compatibility 2020-09-01 19:12:02 +02:00
Mislav Marohnić
4976bd75e1 Fix date-based release output and tests 2020-09-01 19:09:10 +02:00
Mislav Marohnić
0f42c7af4d Add tests for release create, delete, download, view 2020-09-01 18:56:30 +02:00
nate smith
49ab3ec5bf check for tty before creating colorables 2020-09-01 11:18:34 -05:00
Nate Smith
734959c39d
Merge pull request #1603 from cli/create-pr-metadata-failure
Be transparent about which part of `pr create` flow failed
2020-09-01 10:51:55 -05:00
Sam Coe
b4956006be Fix up feature request issues url 2020-09-01 15:52:58 +02:00
Mislav Marohnić
9ef1791fdb Provide machine-readable release view output 2020-09-01 15:23:43 +02:00
Mislav Marohnić
d0d9cc2f9b View latest release if no tag provided 2020-09-01 14:16:59 +02:00
Mislav Marohnić
48a827ee34 Tweak gh config set -h output format on auth login 2020-09-01 13:19:30 +02:00
Mislav Marohnić
0de3f678bc Only validate --hostname when flag was provided 2020-09-01 13:19:19 +02:00
Mislav Marohnić
b029397d32 Validate the --hostname flag value 2020-09-01 13:06:13 +02:00
Mislav Marohnić
1a051e9c44 Validate hostname as entered in the auth prompt 2020-09-01 12:59:58 +02:00
Mislav Marohnić
a8b06c329b Ensure correct ANSI color output during OAuth flow on Windows
We used to write directly to `os.Stderr`, but we first need to convert
that into a colorable stream.
2020-09-01 12:31:36 +02:00
Sam Coe
35e739dfbd Link to bugs and feature requests 2020-09-01 10:25:16 +02:00
Sam Coe
022d29ce79 Further cleanup up README links and update contributing doc 2020-09-01 09:40:27 +02:00
Mislav Marohnić
cb4cc72e50 Handle HTTP 422 response to OAuth Device flow detection
If HTTP 422 is encountered, assume that OAuth Device Flow is unavailable
and fall back to OAuth app authorization flow.
2020-08-31 22:26:04 +02:00
Mislav Marohnić
766e4950d9 Be transparent about which part of pr create flow failed
When applying metadata to the new PR such as assignees or reviewers, if
the operation fails, an error message would get printed:

    failed to create pull request: <API error text>

This was misleading, because the PR did get created; it's just that
updating it failed. The new error message is:

    https://github.com/OWNER/REPO/pull/123
    pull request update failed: <API error text>

The PR URL is printed on stdout and the error message is printed on
stderr. In case of any errors, the exit code is still non-zero.
2020-08-31 16:46:22 +02:00
Sam Coe
a8add832b5 Address PR feedback and link cleanup 2020-08-31 16:27:27 +02:00
Sam Coe
a3eb099c14 Remove feedback survey from README 2020-08-31 08:44:04 +02:00
Nate Smith
fd31007075
Merge pull request #1590 from colinshum/colinshum/template-repo
[Feature] Create repositories from a template repo
2020-08-28 14:09:12 -05:00
Colin Shum
99372f0dbc [Refactor] Add variadic argument to repoCreate to support templates 2020-08-28 15:02:08 -04:00
vilmibm
8dd93e1748 gh pr checks
A basic first pass on gh pr checks that shows all check runs for a given
PR's latest commit.
2020-08-28 13:18:59 -05:00
Nate Smith
bb65ca0635
Merge pull request #1596 from cli/go-version-requirements
Clarify our Go version requirements
2020-08-28 13:14:12 -05:00
Mislav Marohnić
9b45112e69 Add tests for release list/delete 2020-08-28 19:26:16 +02:00
Mislav Marohnić
9a4a5d86cb Merge remote-tracking branch 'origin' into release-cmd 2020-08-28 17:47:53 +02:00
Mislav Marohnić
d43d5e0bc9 Add release delete 2020-08-28 17:41:00 +02:00
Mislav Marohnić
176dd29c05 Clarify our Go version requirements
* We are trying to keep the binary building on Go 1.13 to support building the project on Ubuntu 20.04 LTS
* Go 1.14+ is required to run the test suite
* We build our releases on Go 1.15

This adds a CI check that verifies that the project compiles on 1.13
2020-08-28 14:05:50 +02:00
Mislav Marohnić
987e95f0c8
Merge pull request #1593 from wilso199/docs/brew-installation
Updating Brew Installation Instructions
2020-08-28 12:24:49 +02:00
Mislav Marohnić
9e5b7aa371
Merge pull request #1594 from cli/remove-feedback-form
Remove reference to feedback form
2020-08-28 12:24:18 +02:00
Sam Coe
41f42d4057 Remove reference to feedback form 2020-08-28 09:06:31 +02:00