Toshiya Doi
f14459c451
Clean up unnecessary fmt.Sprintf
2020-04-04 15:11:57 +09:00
Toshiya Doi
d5bff70259
Clean up unnecessary fmt.Sprintf
2020-04-04 15:09:22 +09:00
Toshiya Doi
92dea433e4
An attempt of collecting reviewers metadata
2020-04-04 13:28:47 +09:00
Toshiya Doi
85d8f808f2
Test pr metadata in CLI preview
2020-04-04 13:14:34 +09:00
Toshiya Doi
0cb6890c74
Print pr metadata in CLI preview
2020-04-04 13:09:34 +09:00
Toshiya Doi
d538f7a1be
Query pr metadata by number and branch
2020-04-04 13:08:22 +09:00
Toshiya Doi
125ff06b2c
Add metadata to PullRequest struct
2020-04-04 13:07:44 +09:00
Toshiya Doi
5a17962188
Add a new line to test a dynamic string of metadata
2020-04-04 12:53:22 +09:00
Toshiya Doi
13864131c0
Rename issue metadata list functions to avoid naming conflicts with pr
2020-04-04 11:28:52 +09:00
Toshiya Doi
1279131f0f
Simplify issue struct avoiding to sue edges
2020-04-04 11:28:52 +09:00
Toshiya Doi
97cad74d75
Add a new line even an issue Body content is empty
2020-04-04 11:28:52 +09:00
Toshiya Doi
8c697a0d99
Test issue metadata in CLI preview
2020-04-04 11:28:52 +09:00
Toshiya Doi
bfb3501cf9
Print issue metadata in CLI preview
2020-04-04 11:28:52 +09:00
Toshiya Doi
6dbf821198
Query issue metadata by number
2020-04-04 11:28:52 +09:00
Toshiya Doi
013481c0d6
Add metadata to issue struct
2020-04-04 11:28:52 +09:00
Mislav Marohnić
e10ccefaf5
Merge pull request #667 from doi-t/view-the-current-state
...
Show the state (open, closed, merged) in issue view and pr view
2020-04-03 19:41:29 +02:00
Mislav Marohnić
43b28f769b
Merge pull request #727 from thefotios/respect-clone-target
...
Respect clone target
Closes #721
2020-04-03 19:18:05 +02:00
Mislav Marohnić
250114e2c0
Merge pull request #742 from brettbuddin/no-color
...
Support NO_COLOR environment variable to disable color
2020-04-03 19:10:16 +02:00
Mislav Marohnić
baeb86a401
Merge pull request #734 from cli/golangci-lint
...
Check code with golangci-lint on push
2020-04-03 17:35:40 +02:00
Mislav Marohnić
ee2456f3c0
Don't build during linting
...
Building is already covered in CI workflows that run tests
2020-04-03 16:51:47 +02:00
Mislav Marohnić
7ba9773e68
Make golangci-lint failures fatal ☠️
2020-04-03 16:51:43 +02:00
Mislav Marohnić
c3923785da
Merge pull request #730 from cli/installation-link
...
Bring back `#installation` anchor in README
2020-04-03 16:34:56 +02:00
Mislav Marohnić
734497a8d8
Code fixes informed by golangci-lint failures ( #738 )
2020-04-03 16:33:34 +02:00
Fotios Lindiakos
6428e3da10
Rename parseExtraArgs
2020-04-03 10:10:46 -04:00
Fotios Lindiakos
199021d55d
Cleanup clone description
2020-04-03 10:10:32 -04:00
Mislav Marohnić
8bea97810f
Merge pull request #744 from rainersigwald/patch-1
...
Clarify error in powershell completion test
2020-04-03 14:31:40 +02:00
Rainer Sigwald
ad7b4b0130
Clarify error in powershell completion test
2020-04-03 07:18:19 -05:00
Brett Buddin
0cc41b4912
Provide notty style to glamour when colors are disabled.
2020-04-02 21:09:29 -04:00
Brett Buddin
48e7df2337
Any non-empty value should be a disabling intent.
...
Conforms to the informal standard proposed in https://no-color.org
2020-04-02 20:31:04 -04:00
Brett Buddin
21e445beab
Support NO_COLOR environment variable to disable color.
2020-04-02 20:22:55 -04:00
Toshiya Doi
7eabbf5881
Simplify expected output definitions with new line testing helper
2020-04-03 00:35:48 +09:00
Toshiya Doi
4c2f15fe37
Roll back the place of colorFuncForState
2020-04-02 23:58:28 +09:00
Toshiya Doi
0095fe9a13
Merge branch 'master' into view-the-current-state
2020-04-02 23:52:41 +09:00
Mislav Marohnić
876e825e64
Check code with golangci-lint on push
...
Right now linting failures don't fail the CI job, but they might in the
future.
2020-04-02 14:55:13 +02:00
Michael Dickens
efefe5a849
add MacPorts usage info
2020-04-02 08:49:43 -04:00
Mislav Marohnić
f5aa2bb5ac
Bring back #installation anchor in README
...
This is linked to from GitHub.com call-to-action to install CLI
2020-04-02 12:52:01 +02:00
Fotios Lindiakos
59f239bddc
Parse args to find an explicit directory name
2020-04-01 16:43:27 -04:00
Fotios Lindiakos
ed62b7bbd5
Consolidate 'git clone' commands
2020-04-01 15:05:18 -04:00
Mislav Marohnić
e066e98a9a
Merge pull request #726 from cli/pr-create-crash
...
Fix auto-forking scenario in `pr create`
2020-04-01 19:46:39 +02:00
Mislav Marohnić
f0e6c98bf0
Fix auto-forking scenario in pr create
...
When an existing `headRepo` couldn't be detected, it's time to auto-fork
one. Unfortunately, an obscure Go behavior made it seem like `headRepo`
was a non-nil value, where in fact it did contain a nil pointer which
would crash the process.
This avoids ever assigning nil pointers to `var headRepo ghrepo.Interface`.
2020-04-01 19:37:56 +02:00
Nate Smith
44a37cbba3
Merge pull request #723 from cli/go-ci-checks
...
Assert that running `go fmt` or `go mod tidy` produces no changes in CI
2020-04-01 10:58:14 -05:00
Mislav Marohnić
ad190519c6
Simplify ANSI coloring
2020-04-01 15:09:24 +02:00
Mislav Marohnić
228312a30d
Have git diff produce colored output in CI
2020-04-01 14:48:47 +02:00
Mislav Marohnić
7dbc5e99e4
go: download dependencies before running tests in CI
2020-04-01 14:48:43 +02:00
Mislav Marohnić
a8894a0745
Assert that running go fmt or go mod tidy produces no changes in CI
...
This will help avoid introducing code changes that are not properly
formatted, or `go mod` dependency changes that are untidy.
Ref. 0680bb5c6c
2020-04-01 14:30:52 +02:00
vilmibm
0680bb5c6c
go mod tidy
2020-03-31 14:47:27 -05:00
Nate Smith
742a194b7e
Merge pull request #720 from cli/fork-rename-remotes
...
Add "upstream" remote after `repo fork`
2020-03-31 13:47:30 -05:00
Mislav Marohnić
fa3d65b2b6
Add "upstream" remote after repo fork
2020-03-31 18:36:41 +02:00
Mislav Marohnić
0e9b48d876
Merge pull request #719 from cli/upstream-remote
...
Automatically set up "upstream" remote for forks
2020-03-31 17:10:50 +02:00
Mislav Marohnić
e0ba3fd614
Merge pull request #717 from cli/improve-finding-commits
...
Use remote tracking branch for base when detecting commits for `pr create`
2020-03-31 17:08:10 +02:00
