Andrew Hsu
e13398f6b4
fix browse of markdown files with line ranges ( #4310 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-09-14 16:08:19 +02:00
Mislav Marohnić
e0fa56dc29
Merge remote-tracking branch 'origin' into go-module-v2
2021-09-02 20:02:16 +02:00
Des Preston
dafd0bfbd1
feat(4248): add support for line range w/ browse
...
Allow using a range of lines when browsing files. For example:
`gh browse test.go:10-20`
Closes #4248
2021-08-31 16:32:37 -04:00
Mislav Marohnić
11fbb60ae7
Rename the module to "github.com/cli/cli/v2"
2021-08-25 12:41:30 +02:00
nate smith
98d3b7cc79
don't check Fprintf error
...
we don't ever check the return of Fprintf anywhere else in the codebase
so doing it here suggests that it's a special case. if it's something we
should be doing we can circle back and do it more consistently.
2021-07-12 13:05:49 -05:00
Evan Silberman
49ff0c6530
Add a no-browser mode to gh browse
...
For when you just want the destination URL on stdout.
2021-07-02 17:12:16 -07:00
jlsestak
93118c65df
Merge pull request #52 from bchadwic/trunk
...
Update browse.go removed trailing newlines on errors
2021-06-16 20:53:06 -07:00
jlsestak
876b61af7b
Update browse.go
2021-06-16 20:50:08 -07:00
jlsestak
0a801c1ed5
Merge pull request #51 from bchadwic/trunk
...
Fixed parseFileArgs, reformatted tests
2021-06-15 20:14:44 -07:00
Jessica Sestak
b64488fe5c
Changed parsefileArg to return a string, reformatted testing, polished up browse.go
2021-06-15 20:10:48 -07:00
Benjamin Chadwick
3d97aaf7f4
Merge pull request #49 from bchadwic/trunk
...
Fixed pr issues
2021-06-14 22:37:21 -07:00
bchadwic
679d396c8d
reformatted spacing and final touches
2021-06-14 22:31:29 -07:00
ravocean
21691c8d2e
Reorganized tests
2021-06-14 22:16:58 -07:00
ravocean
79da79fb68
We added new tests to bring the coverage to 90%+
2021-06-14 21:40:52 -07:00
jlsestak
707897ffb6
Deleted extra space
2021-06-14 08:29:22 -07:00
bchadwic
9c7a788193
created more tests, and removed repoFlag
2021-06-13 21:05:50 -07:00
Jessica Sestak
7ea9d9164a
Fixed TestNewCmdBrowse and added more tests
2021-06-13 20:16:19 -07:00
Jessica Sestak
edef757c6c
Made more runBrowse tests
2021-06-12 22:36:03 -07:00
bchadwic
2b42ab92c3
refactored browse.go
2021-06-12 21:58:29 -07:00
Mislav Marohnić
7999a457ad
Separate out NewCmdBrowse tests from runBrowse tests
...
Co-authored-by: Benjamin Chadwick <benchadwick87@gmail.com>
Co-authored-by: Jessica Sestak <jlsestak@gmail.com>
2021-06-11 18:53:34 +02:00
bchadwic
88ec5ad3b2
Fixing issues in the pr
2021-06-10 21:14:10 -07:00
Jessica Sestak
e5b81fb6a5
Started working on testing for parseFileArgs
2021-06-08 22:09:11 -07:00
Jessica Sestak
1657cf46c1
Fixed parsefileargs to throw errors with incorrect line numbers
2021-06-08 21:23:50 -07:00
Jessica Sestak
a96612c5e9
Fixed --repo to open with Args
2021-06-08 20:54:56 -07:00
bchadwic
98a5541d15
Started to fix the flags and the restrictions using them
2021-06-08 20:35:38 -07:00
bchadwic
95afca882b
Finished refactoring now
2021-06-08 16:35:53 -07:00
bchadwic
506bd4b2de
working on refactoring the output, the tests and how opts is structured
2021-06-08 15:36:11 -07:00
Benjamin Chadwick
698ca014c7
Merge pull request #38 from bchadwic/trunk
...
Redefined browse output, and added in more test cases
2021-06-08 13:12:48 -07:00
Benjamin Chadwick
9fe986a480
Update pkg/cmd/browse/browse.go
...
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:48:17 -07:00
Benjamin Chadwick
891f4af69c
Update pkg/cmd/browse/browse.go
...
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:47:56 -07:00
Benjamin Chadwick
94002bf0cc
Update pkg/cmd/browse/browse.go
...
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:47:44 -07:00
ravocean
898d585e6a
A small change in code
2021-06-07 22:00:05 -07:00
bchadwic
569d2fd58a
Got tests objects to fully work! Currently working on making more test cases
2021-06-07 21:47:08 -07:00
ravocean
449858158d
Continued to work on the output of test file
2021-06-07 12:57:36 -07:00
Jessica Sestak
f792704003
Worked on browse_test.go, still not getting errors
2021-06-07 11:04:29 -07:00
bchadwic
6ed9900084
working on the test file for the browse.go
2021-06-06 01:09:43 -07:00
ttran112
e425e897a6
create new test file for first browse branch
2021-06-05 23:31:19 -07:00
ttran112
1a9704dbfb
fix the route
2021-06-05 22:46:46 -07:00
Benjamin Chadwick
bc3a341479
Update browse.go
2021-06-05 21:56:06 -07:00
Jessica Sestak
6f09e4f51a
Fixed print error messages and returning error from openInBrowser
2021-06-05 21:47:03 -07:00
bchadwic
6fc36cf01f
Fixed long message
2021-06-05 17:48:52 -07:00
bchadwic
e28000b5d2
Worked on help section
2021-06-05 17:46:07 -07:00
Benjamin Chadwick
95ceb85ee5
Delete helpful-resources.txt
2021-06-02 12:42:09 -07:00
Benjamin Chadwick
5aeca61fd0
Delete browse_test.go
2021-06-02 12:42:03 -07:00
ravocean
6391bf5801
Starter code for testing
2021-05-31 16:39:10 -07:00
bchadwic
798e03cf15
working on testing browse.go
2021-05-31 15:21:15 -07:00
ttran112
52e7b7cc86
added the message to help the user navigate github
2021-05-31 14:08:15 -07:00
Jessica Sestak
0bfeb8926a
Fixed error messages, added repo override
2021-05-31 13:02:05 -07:00
ravocean
a8a01badf1
Finished refactoring (addCombined)
2021-05-31 11:42:48 -07:00
bchadwic
c162a28099
started to refactor the code base
2021-05-31 10:57:16 -07:00
