Commit graph

5081 commits

Author SHA1 Message Date
Des Preston
bdc5b55f55 pr comments
Only add discussion category to request if there is one. This eliminates
the need to update old tests.

Renaming the variable to something shorter.
2021-08-10 09:47:49 -04:00
Mislav Marohnić
f4bded30f8 Mark test helper 2021-08-10 14:30:55 +02:00
Mislav Marohnić
6136a39ed6 Use remotes.FindByRepo() 2021-08-10 14:30:36 +02:00
Mislav Marohnić
0f1ab13b9e Only check if working copy is dirty when syncing current branch
In other cases, we don't have to abort the operation since it can
proceed without being affected by the working copy at all.
2021-08-10 14:29:23 +02:00
Mislav Marohnić
66ad6ad7d0 Avoid git checkout during gh repo sync
- If the local branch already exists, use `git update-ref`
- If it needs to be created, use `git branch <newbranch>`, but don't
  switch to the new branch

Bonus fixes
- Enables operation while on detached HEAD
- Enables operation even when the current remote doesn't track all
  branches in the remote repo (uses FETCH_HEAD instead of the
  `<remote>/<branch>` syntax)
2021-08-09 22:10:52 +02:00
Jose Garcia
eb2a176450 remove err print 2021-08-07 17:54:43 +00:00
Sam
c5371d5303
Merge pull request #3813 from cli/repo-sync
Add repo sync command
2021-08-05 19:39:40 -07:00
Jose Garcia
fbf0d28672 port forwarding err handling and test refactors 2021-08-06 01:03:03 +00:00
Mislav Marohnić
ac13fc807c
Merge pull request #4005 from despreston/835-rename-checkout
add --branch flag to pr checkout
2021-08-05 21:02:27 +02:00
Mislav Marohnić
9a485ddfa2 💅 Cleanup local branch handling during pr checkout 2021-08-05 20:44:34 +02:00
Des Preston
294a029e70 add --branch flag to pr checkout
Allows renaming the checked out branch.
2021-08-05 20:44:20 +02:00
Jose Garcia
619862a46b initial spike for multiple port support 2021-08-05 15:21:26 +00:00
Issy Long
2f1543a2d7 Merge pull request #62 from github/interactive-menu-for-deleting-a-codespace
cmd/ghcs/delete: Display the interactive menu when there are no args
2021-08-05 15:12:09 +01:00
Issy Long
4362b0b241 cmd/ghcs/delete: Display the interactive menu when there are no args
- Currently the flow to delete a single Codespace is `gh cs list`, copy
  and paste the Codespace name onto the end of `gh cs delete`.
- This improves consistency with other commands by letting the user
  choose which Codespace they want to delete, interactively. A Codespace
  name on the command-line still works too.
2021-08-05 15:00:18 +01:00
Jose Garcia
7b079d9855 Merge pull request #56 from github/jg/logs-cmd
ghcs logs
2021-08-05 08:09:48 -04:00
bchadwic
1f2ab7fbe4 pr and run check symbols revision 2021-08-05 02:13:55 -07:00
Sam Coe
174e26ecac
Fix tests 2021-08-04 18:26:30 -07:00
Sam Coe
2c4a662660
Rework git client interface 2021-08-04 18:13:58 -07:00
Sam Coe
00d67e3e5a
Remove unnecessary + 2021-08-04 17:10:50 -07:00
Sam Coe
86f16dbaf5
Use more idiomatic pattern 2021-08-04 17:00:20 -07:00
Sam Coe
c0756c2d1c
Clean up UX 2021-08-04 16:42:27 -07:00
bchadwic
5993018679 NEW functionality:
current folder '.', from current folder '.(pathsep)', parent folder '..(path sep)', absolute 'folder | filename'
2021-08-04 15:20:45 -07:00
bchadwic
7ef919d713 NEW functionality: current folder '.', from current folder '.(path sep)', parent folder '..(path sep)', absolute 'folder | filename' 2021-08-04 15:03:30 -07:00
Jose Garcia
76aca39f5b Create status support 2021-08-04 17:35:11 +00:00
Mislav Marohnić
140a54a009 Add machine-readable output formats
- Default table output (when stdout is attached to a terminal) stays the same;
- When stdout is redirected, output tab-separated values and no header line;
- With `--json` flag, output structured JSON data.

Example:

    $ ghcs list --json
    [
      {
        "Branch": "main",
        "Created At": "2021-06-10T15:04:46+02:00",
        "Name": "mislav-playground-jvqj",
        "Repository": "mislav/playground",
        "State": "Shutdown"
      },
      {
        "Branch": "master",
        "Created At": "2021-07-15T15:51:08+02:00",
        "Name": "mislav-github-github-pwgg365xv",
        "Repository": "github/github",
        "State": "Shutdown"
      }
    ]
2021-08-04 15:58:27 +02:00
Mislav Marohnić
95a515ecf0
Merge pull request #4087 from cli/graphql-error-fix
Fix unmarshalling GraphQL error type
2021-08-04 15:43:00 +02:00
Mislav Marohnić
90b7886142 Fix unmarshalling GraphQL error type
The "path" field of a GraphQL error object contains a mix of strings and
numbers and cannot be deserialized into `[]string`. Fortunately, we
don't need to rely on the "path" field and instead have the final error
message be constructed by aggregating human-readable "message" fields.
2021-08-04 15:34:53 +02:00
Mislav Marohnić
1007c1a3ae
Merge pull request #4079 from cli/no-label-colors
Disable colorizing labels in `issue list` output
2021-08-04 15:23:36 +02:00
Jose Garcia
70f4a7b4b5 Re-introduce secrets export 2021-08-04 13:19:00 +00:00
Mislav Marohnić
fddca21815
Merge pull request #4085 from marckhouzam/feat/compPowershell
Fixes #4084: Enable completion descriptions for powershell
2021-08-04 15:10:15 +02:00
Marc Khouzam
549caf29b5 Enable completion descriptions for powershell
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
2021-08-04 07:45:30 -04:00
Mislav Marohnić
65d1124799 Close file after resolving faux symlinks on Windows
https://github.com/cli/cli/pull/4051/checks?check_run_id=3186063173
2021-08-03 16:46:04 +02:00
Mislav Marohnić
930ee60ac5 Disable colorizing labels in issue list output
- Labels with dark color are not visible on a dark background
- "Raw" `issue view` output should never output color, not even with
  CLICOLOR_FORCE=1
2021-08-03 16:02:16 +02:00
Mislav Marohnić
fbdebe8e4e
Merge pull request #4071 from rsteube/gh-merge-admin
pr merge: added `--admin` flag
2021-08-03 15:56:25 +02:00
Mislav Marohnić
5d1d967c43 💅 Clean up pr merge admin logic 2021-08-03 15:49:55 +02:00
Jose Garcia
d5003334e3 Remove secrets export 2021-08-03 13:43:09 +00:00
Jose Garcia
e57b390d4a dotfiles status spike 2021-08-03 13:42:34 +00:00
rsteube
baa18c164d pr merge: added --admin flag 2021-08-02 13:02:32 +02:00
Jose Garcia
be794f1579 creation log support for cat and tail 2021-07-29 17:09:50 +00:00
Jose Garcia
58a055609d logs cmd spike and refactor of ssh tunnel methods 2021-07-29 10:57:51 -04:00
Ben Chadwick
1efc07b183 made tests non os dependant 2021-07-28 22:09:37 -07:00
Mislav Marohnić
bbd74f004f Go 1.14 compat 2021-07-28 23:00:34 +02:00
Mislav Marohnić
0d999ddaa1 Rework local extensions for Windows
Replace the implementation that relied on symlinks with the one that
create regular files that act like symlinks: they contain a reference to
the local directory where to find the extension.
2021-07-28 22:47:54 +02:00
Mislav Marohnić
5a46c1cab6
Merge pull request #4043 from cli/upgrade-goreleaser
This reverts commit 85d0447.
2021-07-28 21:07:29 +02:00
Mislav Marohnić
4b499be96b
Merge pull request #3942 from dscho/complete--repo-flag
Allow auto-completing the `--repo` values
2021-07-28 17:27:56 +02:00
Mislav Marohnić
d6b70beeaa List repos from non-default hostnames in completions for -R 2021-07-28 17:18:56 +02:00
Jose Garcia
ebc8ce5adb Merge pull request #53 from github/jg/perf-improvements
Liveshare client upgrade to v0.6.0
2021-07-28 10:13:06 -04:00
Jose Garcia
cd99399290 Merge pull request #3 from github/jg/ignore-eof-terminal
Ignore EOF on terminal close
2021-07-28 09:56:07 -04:00
Jose Garcia
ae29c3c1ea Ignore EOF on terminal close 2021-07-28 13:55:33 +00:00
Jose Garcia
4fc27b3ed9 Merge pull request #2 from github/jg/connection-test
Connection test
2021-07-28 09:52:58 -04:00