Commit graph

1155 commits

Author SHA1 Message Date
Amanda Pinsker
ef17aa520d Add unicode to pr status 2020-03-19 10:33:34 -07:00
Mislav Marohnić
d75faab85a Creating a PR now always prioritizes an existing fork as a push target
Before: the default push target for the current branch in `pr create`
was the first repository found among git remotes that has write access.

Now: the default push target is the fork the base repo, if said fork
exists and has write access, falling back to old behavior otherwise.

This change in the default is to facilitate contributions to projects
that have a hard requirement that all pull requests (even those opened
by people with write access to that project) come from forks.
2020-03-19 16:04:23 +01:00
Nate Smith
51eb2cb345
Merge branch 'master' into pr-count 2020-03-18 09:26:05 -07:00
Nate Smith
3334bdd9b7
Merge pull request #668 from cli/mislav/check-if-pr-exists
Check for existing pull request on `pr create`
2020-03-18 08:37:28 -07:00
Nate Smith
75ebf1694f
Merge pull request #670 from cli/pr-status-branch-err
Allow `pr status` in cases where there is no current git branch
2020-03-18 08:34:41 -07:00
Mislav Marohnić
206844681b
Merge pull request #669 from doi-t/add-pr-status-tests
Add unit tests for Closed and Merged states of the current branch
2020-03-18 14:21:42 +01:00
Mislav Marohnić
a40fb04fc3 Allow pr status use when on detached HEAD 2020-03-18 14:14:45 +01:00
Mislav Marohnić
bec667964c Allow pr status -R <repo> usage from outside of a git repo 2020-03-18 14:13:17 +01:00
Mislav Marohnić
e80c2f852d
Merge pull request #656 from sh7dm/fix-repo-not-found
Don't list remotes when --repo flag is set
2020-03-18 13:53:57 +01:00
Toshiya Doi
a2d3923d21 Add unit tests for Closed and Merged states of the current branch 2020-03-18 21:35:06 +09:00
Mislav Marohnić
5b76881624 Improve detecting existing PR on pr create
- Only check for existing PRs if `--web` wasn't given
- Fix detecting PRs from forks
- Improve order of error handling: local validation errors are handled
  earlier than the ones that have to consult the API
2020-03-18 13:09:02 +01:00
Mislav Marohnić
23dfeff84f Merge remote-tracking branch 'origin/master' into check-if-pr-exists 2020-03-18 12:04:08 +01:00
Mislav Marohnić
cb06812d19
Merge pull request #532 from mingrammer/consistent-printing
fix: inconsistent format between issue list and status
2020-03-18 11:59:17 +01:00
Toshiya Doi
a5bd3130c4 Cleanup 2020-03-18 10:03:04 +09:00
Toshiya Doi
327a804959 Fix tests to support the "Draft" state badge 2020-03-18 09:57:46 +09:00
Toshiya Doi
e50ba549d8 Rename OPEN state to Draft for a Draft PR 2020-03-18 09:55:47 +09:00
Toshiya Doi
7ceffd0827 Merge branch 'master' into view-the-current-state 2020-03-18 08:51:04 +09:00
Toshiya Doi
762e806c9e Add tests for viewing a Draft PR in CLI 2020-03-18 08:23:29 +09:00
Toshiya Doi
0cfa4be86a Add tests for utilities of PR/issue state format 2020-03-18 07:30:28 +09:00
vilmibm
e4b43b08b9 update usage text 2020-03-17 17:13:48 -05:00
vilmibm
00de6b9c09 switch defaults for issue view 2020-03-17 17:06:42 -05:00
vilmibm
c30b482bf0 switch defaults for pr view 2020-03-17 17:06:42 -05:00
vilmibm
0344e9543a humanize branch name for title 2020-03-17 16:18:32 -05:00
vilmibm
98a2281f45 more nuanced error handling 2020-03-17 16:09:40 -05:00
Toshiya Doi
46a632c8f6 Fix utility function scopes 2020-03-18 04:52:03 +09:00
Toshiya Doi
e85259d84f Remove labels from the issue preview header
See https://github.com/cli/cli/issues/652#issuecomment-598940740
2020-03-18 04:42:50 +09:00
Dmitry Sharshakov
d755288cdf Implement review comments 2020-03-17 20:05:53 +03:00
vilmibm
af46fcb1ff --fill for pr create 2020-03-16 15:32:47 -05:00
vilmibm
2d90c09f48 review feedback 2020-03-16 15:32:35 -05:00
Tarasovych
d0c32e7a3d changed error message and pr check 2020-03-16 16:01:03 +02:00
Toshiya Doi
9a6026e9fc Format PR/Issue states with color 2020-03-16 04:32:41 +09:00
Toshiya Doi
c8a72c3bcb Add a test for viewing an issue without labels in CLI 2020-03-16 04:26:32 +09:00
Toshiya Doi
5a23113b5b Add tests for the Closed/Merged PR preview 2020-03-16 04:21:35 +09:00
Toshiya Doi
8cd6932f9e Add a test for the closed issue preview 2020-03-16 04:12:26 +09:00
Toshiya Doi
0475cf0112 Extract test fixtures for 'issue view --preview' 2020-03-16 03:21:03 +09:00
Toshiya Doi
e0bfd67c69 Fix tests for preview messages with a issue/PR state 2020-03-16 03:13:05 +09:00
Toshiya Doi
b8edb9f62d Show the PR state for viewing PRs in CLI 2020-03-16 02:41:02 +09:00
Toshiya Doi
caf26e4093 Show the issue state for viewing issues in CLI 2020-03-16 02:40:49 +09:00
Toshiya Doi
faa4bed67a Move colorFuncForState for a PR/issue state to the utils package 2020-03-16 02:32:11 +09:00
Dmitry Sharshakov
45c2a16d49 Don't list remotes when --repo flag is set 2020-03-14 23:14:38 +03:00
UmairShahzad
f51669e228 Merge remote-tracking branch 'origin/master' into pr-count 2020-03-14 19:02:51 +05:00
vilmibm
a23549001e cleanup 2020-03-13 15:14:32 -05:00
vilmibm
1b7840326c actually add tests for computing defaults 2020-03-13 15:14:03 -05:00
vilmibm
fba4f4d19e InitCmdStubber 2020-03-13 15:12:23 -05:00
vilmibm
c4c967fa0f add AskStubber 2020-03-13 15:12:17 -05:00
vilmibm
ed8aaa83e3 add CmdStubber 2020-03-13 15:12:09 -05:00
vilmibm
8769299731 titlebody prepopulation 2020-03-13 15:12:03 -05:00
Toshiya Doi
102cfdb1a2 Rearrange the order of command initialization 2020-03-13 23:59:18 +09:00
Toshiya Doi
5e3aa31cf1 Fix 'gh issue view' usage description 2020-03-13 23:58:41 +09:00
Tarasovych
f3c9406e76 fixed repo argument 2020-03-13 16:01:37 +02:00