Commit graph

1946 commits

Author SHA1 Message Date
Jose Garcia
f6b8bbe982
Merge pull request #5390 from legomushroom/legomushroom/codespaces-add-hidden-select-command
[codespaces]: add hidden select command
2022-04-05 13:37:45 -04:00
Oleg Solomka
e7fb9c0c4d fix linter issues 2022-04-05 10:08:34 -07:00
Oleg Solomka
78573442eb address more PR feedback 2022-04-04 17:13:52 -07:00
Amanda Lin
371f128871 remove idle timeout flag 2022-04-04 15:15:00 -05:00
Oleg Solomka
d6edc6f8a6 address more PR feedback 2022-04-04 10:53:52 -07:00
Oleg Solomka
b4d29a8b7b address PR feedback 2022-04-04 10:34:04 -07:00
Oleg Solomka
9a0b208200 [select codespace]: cleanup description 2022-04-01 12:30:55 -07:00
Oleg Solomka
07e18ea3d4 [codespace select]: add unit tests for filePath flag, add command description 2022-04-01 11:35:40 -07:00
Gil Raphaelli
a6f6ad74ae
release list: correctly label the Latest release (#4921)
since https://docs.github.com/en/graphql/overview/changelog#schema-changes-for-2021-01-19

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-03-30 17:08:21 +00:00
Daniel Le
24ba3540b7 generateCompareURL uses url.PathEscape instead of url.QueryEscape
For ctx.{BaseBranch,HeadBranchLabel}.
2022-03-30 13:01:24 +08:00
Sam Coe
6fbe6d9c20
Add ability to filter issue and pr searches by app (#5370) 2022-03-29 21:58:29 +02:00
xiaotong
4a5864708c
Add label list and label create commands (#5316) 2022-03-29 17:38:59 +00:00
Nate Smith
e2fd7ceff0
Merge pull request #5369 from cli/gh-status 2022-03-29 11:32:28 -05:00
lylecantcode
56fda0f8c6
Support GH_DEBUG to control verbosity, deprecate DEBUG (#5306)
The GH_DEBUG environment variable is a new gh-specific verbosity control.

For backwards-compatibility, DEBUG will still be respected if it has values
"1", "true", "yes", and "api", but any other values will be ignored.

Finally, support for "oauth" debug value has been dropped in favor of "api".
The "oauth" value only had limited, internal use.

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-03-29 18:05:35 +02:00
nate smith
5b060a272d nvm 2022-03-29 11:01:54 -05:00
nate smith
2712ef05df fix tests to account for padding 2022-03-29 10:44:48 -05:00
nate smith
dc03417042 PR->Pull Request 2022-03-29 10:35:28 -05:00
nate smith
fead25b56c some lipgloss tweaks 2022-03-29 10:34:20 -05:00
nate smith
5569c0e94d oops 2022-03-29 10:29:05 -05:00
nate smith
0e941dca0a words 2022-03-29 10:26:34 -05:00
nate smith
893f833673 use errgroup 2022-03-29 10:25:14 -05:00
nate smith
a3fba669bd add and use RESTWithNext 2022-03-29 10:15:33 -05:00
nate smith
659a8ed1b9 use a StringSliceVar 2022-03-29 09:47:59 -05:00
Nate Smith
c1e5934b21
Merge pull request #5272 from meiji163/pin-ext 2022-03-29 09:21:20 -05:00
Mislav Marohnić
07cd7496c5
Merge pull request #5225 from cli/extract-to-root
run download: fix extracting to root path
2022-03-29 16:16:34 +02:00
Mislav Marohnić
3f5311ea1c
Merge pull request #5345 from znull/znull/ssh-config-example
ssh.go: use setup example that should work with any ssh config
2022-03-29 16:15:56 +02:00
Jimmy Keith
ce8f66b421
Have extension upgrade --all be non-fatal when no extensions installed (#5356) 2022-03-29 16:15:25 +02:00
Mislav Marohnić
91c450ec60
Merge pull request #5357 from callumacrae/force-tty-pr-view
fix: respect `GH_FORCE_TTY` when running `gh pr view`
2022-03-29 16:12:45 +02:00
nate smith
058c2b4fe3 redundant 2022-03-28 11:55:07 -05:00
nate smith
f22c325ea4 gh status 2022-03-28 11:53:13 -05:00
Sam Coe
ee6fc0f9b7
Add search issues and search pull requests commands (#5334) 2022-03-27 19:53:03 +00:00
Callum Macrae
f7ef503051 fix: respect GH_FORCE_TTY when running gh pr view
`GH_FORCE_TTY` only affects stdout, not stderr, so this check was
failing and the flag was being ignored.

I also checked for similar problem in other files but everything else
seemed stderr or stdin related.

closes #5354
2022-03-25 15:07:47 +00:00
Jason Lunz
17cb6346a5
ssh.go: use setup example that should work with any ssh config
The `gh cs ssh` command suggests an example recipe for setting up
openssh integration. The last step appends an `Include` statement to the
user's `~/.ssh/config`.

Unfortunately, this won't always work as intended. If the existing
configuration ends with a `Host` block, the added `Include` statement
will be conditional on whether that block matches.

By preceding the `Include` statement with `Match all`, we can ensure
that it is always evaluated.
2022-03-23 17:00:36 -06:00
Caleb Brose
623e67f6b1 Update comments/usage and remove -- 2022-03-23 16:09:07 +00:00
Oleg Solomka
783f316df1 [codespaces]: add hidden select command 2022-03-23 00:26:50 +00:00
meiji163
45845bc999 cant pin local 2022-03-22 11:02:16 -07:00
Meijke Balay
348bb70fa5 Merge remote-tracking branch 'upstream/trunk' into pin-ext 2022-03-22 08:13:53 -07:00
Caleb Brose
f22320a478 Parse scp args 2022-03-22 01:57:37 +00:00
Steve Gray
b48a93cddf
Remove unwanted trailing quote
Removes a stray quote from the codespace ssh example.
2022-03-18 14:06:27 -06:00
Josh Gross
31c6ba3807
Support listing and removing Dependabot secrets (#5160)
* Support listing and removing Dependabot secrets

* Remove duplicated tests
2022-03-17 11:42:12 +02:00
Bernardo
2e3400a8af Merge branch 'trunk' into jg/event-handling 2022-03-16 20:51:47 +00:00
Charlie Andrews
64eecef176 Remove unhelpful error wrapper 2022-03-16 09:36:14 -04:00
Charlie Andrews
a2f76fdfe0 Fix copy pasta error to appease the linter 2022-03-16 09:10:54 -04:00
Charlie Andrews
8bf0cb8f13 Refactor the getOrChooseCodespace to always check for pending ops 2022-03-16 08:56:17 -04:00
Charlie Andrews
10e43b5136 Use color variable instead of literal for disabled reason 2022-03-16 08:43:34 -04:00
Charlie Andrews
3ed2e49bd9 Add tests for disallowing all port commands for codespace w/ pending op 2022-03-15 17:27:38 -04:00
Charlie Andrews
f94a1a2bd4 Add test for disallowing opening vs code for codespace with pending op
I also refactored the existing vs code test a bit to work with the new
use of `getOrChooseCodespace`.
2022-03-15 17:27:38 -04:00
Charlie Andrews
6346779f35 Add test for disallowing logs when codespace has a pending op 2022-03-15 17:27:38 -04:00
Charlie Andrews
27a5512b41 Add test for disallowing ssh when codespace has a pending op 2022-03-15 17:27:38 -04:00
Charlie Andrews
5ffe838dce Disallow any port operations when codespace has pending operation
Since all of the port operations require the codespace to be running, we
need to disallow these operations when there's a pending op since we
can't start the codespace in this state.

Since the API already disallows this, this is basically cleaning up the
error messages that the user sees in this state

Old error message:

```
$ gh cs ports forward 80:80
? Choose codespace: redacted
Starting codespace ⣻error connecting to codespace: error starting codespace: HTTP 422: your codespace has an operation pending: updating to a sku with a different amount of storage; please wait until this operation is complete (https://api.github.com/user/codespaces/cwndrws-redacted/start)
```

New error message:

```
$ gh cs ports forward 80:80
? Choose codespace: redacted
codespace is disabled while it has a pending operation: Changing machine types...
exit status 1
```
2022-03-15 17:27:38 -04:00