Commit graph

47 commits

Author SHA1 Message Date
Mislav Marohnić
f6fcdf114e Use SetPrepareCmd hook to spy on OpenInBrowser
We are now able to assert that the browse command was called with the correct URL
2019-11-01 22:18:12 +01:00
Mislav Marohnić
2939924124 Merge branch 'master' into version-flag 2019-10-31 23:13:07 +01:00
Mislav Marohnić
c3d70bd8cd Clarify where Version and BuildDate are set 2019-10-31 23:10:42 +01:00
Mislav Marohnić
e87775845d Also print cmd usage string on "unknown command" 2019-10-31 22:44:43 +01:00
Mislav Marohnić
a6e61a3a8d Silence Cobra usage on errors
When an error occurs anywhere in a command, Cobra used to print the
error itself and command usage help.

We already print error in `main()`, and we don't want to use command
usage string on anything other than flag-parsing errors.

This also fixes the double output of each error.
2019-10-31 13:47:10 +01:00
Mislav Marohnić
0bf3e7500c Add --version flag support 2019-10-31 12:14:55 +01:00
Mislav Marohnić
f786802e9e Customizable API client 2019-10-29 21:07:03 +01:00
Mislav Marohnić
8370602f49 WIP eliminate package-level state in commands, context 2019-10-25 21:49:08 +02:00
Mislav Marohnić
641de86427 Eliminate package-level state in git remote parsing 2019-10-25 21:48:25 +02:00
Mislav Marohnić
c82e38353f Fix global --repo, --current-branch functionality
Turns out I've tried to use the flags' value too early: they are not yet
parsed out at package `init()` time.
2019-10-18 19:24:16 +02:00
Corey Johnson
a25fa5d66b Merge remote-tracking branch 'origin/master' into pr-view-tests 2019-10-17 10:39:49 -07:00
Mislav Marohnić
183db99535 Ensure remote URL parsing tests don't read user SSH config files 2019-10-17 15:58:26 +02:00
Mislav Marohnić
344906bf03 Test SSH config parser 2019-10-17 15:50:17 +02:00
Mislav Marohnić
8016d80884 Create overridable Context interface 2019-10-17 02:25:59 +02:00
Corey Johnson
32c9cb9892 Great work corey 2019-10-16 16:28:56 -07:00
Corey Johnson
5a10f2350f Don't treat no active PR as an error 2019-10-16 16:26:05 -07:00
Corey Johnson
19d02404cd Add PRView test 2019-10-16 16:25:51 -07:00
Corey Johnson
a8b7e4c5f3 Add PRView tests 2019-10-16 14:47:47 -07:00
Corey Johnson
9fe04dc033 Merge remote-tracking branch 'origin/master' into add-pr-show 2019-10-16 12:48:12 -07:00
Corey Johnson
354529b2df Add some output 2019-10-16 12:39:51 -07:00
Corey Johnson
7e2f1c7d77 Merge pull request #22 from github/style-pr-list
Style `gh pr list`
2019-10-16 12:16:14 -07:00
Corey Johnson
b31f42180c Use the entire fixture path 2019-10-16 10:59:28 -07:00
Corey Johnson
8ad1afe224 Update command/pr.go
Co-Authored-By: Mislav Marohnić <mislav@github.com>
2019-10-16 09:38:33 -07:00
Corey Johnson
f16d95e8cd small tweaks 2019-10-15 15:31:32 -07:00
Corey Johnson
ef61b49575 A nice error 2019-10-15 15:01:01 -07:00
Corey Johnson
cff76fbc22 Use gookit for colors 2019-10-15 14:51:33 -07:00
Corey Johnson
bb2876cf37 Merge branch 'master' into test 2019-10-15 14:21:34 -07:00
Corey Johnson
8d719999a1 Color brackets 2019-10-15 10:53:35 -07:00
Corey Johnson
2df7c2d86f Make show work 2019-10-14 20:08:57 -07:00
Corey Johnson
1ab5644d6d Add pr show command 2019-10-14 19:58:34 -07:00
Corey Johnson
b4d28f11b0 Style gh pr list 2019-10-14 14:21:15 -07:00
Corey Johnson
2a3315097c rename to helpers 2019-10-14 11:25:59 -07:00
Corey Johnson
f88b3bb7c5 Use fixture directory 2019-10-14 11:02:56 -07:00
Corey Johnson
ef1a8a80f1 Tests use temp git repo 2019-10-14 10:18:27 -07:00
Corey Johnson
994e9eee10 Use RunE instead of panicking 2019-10-11 14:28:26 -07:00
Corey Johnson
1303204b80 Clean some things up 2019-10-11 10:43:06 -07:00
Corey Johnson
5b28291762 Clean up tests 2019-10-11 10:07:40 -07:00
Corey Johnson
8a0e6f5d1d Add test for gh pr list 2019-10-11 09:50:18 -07:00
Corey Johnson
9cb1230857 Trying to test the gh pr list 2019-10-10 16:36:36 -07:00
Corey Johnson
ddb49557d8 Use the correct variable name :) 2019-10-09 15:42:57 -07:00
Corey Johnson
0f6daa0310 Don't panic 2019-10-09 15:32:41 -07:00
Corey Johnson
80dc17778e Use correct package name 2019-10-09 11:54:37 -07:00
Corey Johnson
8b69ca3919 Rename package to api 2019-10-09 11:34:35 -07:00
Corey Johnson
bcf3eb75c8 Add debug output 2019-10-09 10:23:47 -07:00
Corey Johnson
212df1725d Pull out queries 2019-10-08 16:40:10 -07:00
Mislav Marohnić
adf5a832fe Rename to "github/gh-cli" 2019-10-04 10:50:12 +02:00
nate smith
8dd03144ff initial commit 2019-10-03 22:20:31 -05:00