Phill MV
9c9b158d12
added minor caveat
2025-03-27 09:55:14 -04:00
Phill MV
33ab0b8f3b
Tweaked language a bit, improved error message.
2025-03-27 09:47:11 -04:00
Phill MV
321e5687a6
Rewrote the gh at verify --help text to a) clarify and b) document the verificationResult object.
2025-03-26 17:40:35 -04:00
Kynan Ware
229216e830
doc(run shared): clarify 404 handling
2025-03-26 15:29:20 -06:00
Kynan Ware
49588555c3
Merge branch 'trunk' into kw/update-go-gh-and-document-sprig-funcs
2025-03-26 12:38:10 -06:00
Andy Feller
ce4f5c5970
Merge pull request #10683 from cli/andyfeller/10590-alias-delete-test-safeguard
...
Implement safeguard for `gh alias delete` test, prevent wiping out GitHub CLI configuration
2025-03-26 14:08:48 -04:00
Andy Feller
86ad62a62d
Fixes #10590
...
Implement missing safeguard causing `gh alias delete` tests to wipe out tester's GitHub CLI configuration.
2025-03-26 13:42:39 -04:00
Kynan Ware
ffd42ea256
docs: add Sprig library functions to help topics
2025-03-26 10:21:41 -06:00
Kynan Ware
efa1825eff
chore: update go-gh to v2.12.0
2025-03-26 10:21:22 -06:00
Andy Feller
79f1b07fb1
Implement and fix tests for table headers
2025-03-25 15:29:05 -04:00
Meredith Lancaster
166e211e2b
clean up test fixtures
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-25 08:28:33 -06:00
Meredith Lancaster
e3fbe9008f
reduce test duplication
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-25 08:25:00 -06:00
Meredith Lancaster
d1c4bf7dd9
comment
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-25 08:24:52 -06:00
Meredith Lancaster
baeaf66011
restructure api client methods
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 19:13:27 -06:00
Meredith Lancaster
0d0654738b
simplify client methods
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:58:35 -06:00
Meredith Lancaster
a856a796f0
remove duplicate predicate filtering code
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:34:54 -06:00
Meredith Lancaster
a9cc7b481e
create single fetch by digest client method
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:28:27 -06:00
Meredith Lancaster
5a895b9d72
dedpulicate if else logic
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:12:41 -06:00
Meredith Lancaster
95a61974bf
pass params object to api client methods
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:01:57 -06:00
Meredith Lancaster
ad20ef35d9
move local and oci registry attestation filtering
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 17:35:52 -06:00
Meredith Lancaster
cbe80fd169
Merge branch 'trunk' into move-predicate-type-filtering
2025-03-24 17:29:24 -06:00
Meredith Lancaster
faef81f4bc
reorganize getAttestations func to check for remote gh api fetching first
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 17:28:50 -06:00
Meredith Lancaster
a78c06970a
pass predicate type to get attestation api methods
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 17:28:00 -06:00
Kynan Ware
c6f574ccb1
test(run list): update rulesets test name
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-03-24 14:14:50 -06:00
Kynan Ware
30960d59bc
doc(run list): add enterprise ruleset notes
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-03-24 14:04:16 -06:00
Kynan Ware
a35ae3b8bb
refactor(tests): update test name for org workflows
2025-03-24 12:54:47 -06:00
Kynan Ware
d3ad4f410b
docs(run list): doc runs without workflow names
2025-03-24 12:45:03 -06:00
Kynan Ware
5817f6fce9
fix(run list): do not fail on org workflows
2025-03-24 12:34:50 -06:00
William Martin
b78734068d
Merge pull request #10657 from rylwin/fix-typos
...
Fix typos in CONTRIBUTING.md
2025-03-24 10:16:38 +01:00
Ryan Winograd
c7cd041a40
Fix typos in CONTRIBUTING.md
2025-03-22 15:21:24 -05:00
Andy Feller
736ce69f66
Underline table headers if colors enabled but no theme
...
This enhances the table header stylizing logic to ensure they are underlined if color is enabled but no theme is desired.
2025-03-21 12:27:09 -04:00
Andy Feller
6355e54e3c
Ensure table headers are thematically contrasting
...
This commit refactors the color format around table headers to ensure the GitHub CLI uses thematically appropriate colors based on dark background, light background, or no color at all.
In order to do so, `ColorScheme` needs information from the terminal about the background appearance (dark, light, none) to determine appropriate muted color.
2025-03-21 11:51:03 -04:00
Andy Feller
cf3f0ee6b8
Merge pull request #10599 from iamazeem/10559-win-sign-tech-debt
...
`./script/sign` cleanup
2025-03-19 13:32:59 -04:00
Andy Feller
45ffa3c668
Merge pull request #10625 from cli/andyfeller/10580-edit-last-regression
...
Editing last comment on issue or pull request only creates comment if --create-if-none flag is set
2025-03-19 08:24:42 -04:00
Andy Feller
c2ba5c0199
Curly bracket wrapping acceptance tests
2025-03-19 08:05:51 -04:00
Andy Feller
bbb8213e9c
Refactor commentable logic
2025-03-19 07:56:53 -04:00
Andy Feller
bec527d49e
Clean up pr/issue comment test names
2025-03-18 16:14:14 -04:00
Andy Feller
a47651df43
Bring issue/PR comment tests up to par, correct
...
This commit brings the `gh issue comment` and `gh pr comment` tests in line with one another while also addressing some corner cases that weren't previously tested.
2025-03-18 15:56:25 -04:00
William Martin
8f0a465252
Merge pull request #10630 from cli/wm/revert-api-encoding
...
Revert "Merge pull request #10384 from iamazeem/9798-gh-api-encode-package-name"
2025-03-18 13:28:10 +01:00
William Martin
f4382d1345
Revert "Merge pull request #10384 from iamazeem/9798-gh-api-encode-package-name"
...
This reverts commit ed2c322a73 , reversing
changes made to f019cf7cea .
2025-03-18 13:13:06 +01:00
Andy Feller
018b6d6d07
Initial pass fixing gh issue and gh pr comment
...
There is still a bit of work to get the gh pr comment tests in order, however this goes a way towards fixing the issue along with acceptance tests.
Also, it turns out some of the issue acceptance tests were really running `pr` tests.
2025-03-17 23:18:36 -04:00
Azeem Sajid
e02ee18ed2
[gh ext] Fix GitKind extension directory path
2025-03-15 17:55:29 +05:00
Azeem Sajid
342e3cd70c
More cleanup
2025-03-14 12:17:24 +05:00
Azeem Sajid
f3e4976da3
./script/sign cleanup
2025-03-14 11:51:09 +05:00
William Martin
234d2effd5
Merge pull request #10593 from cli/dependabot/go_modules/golang.org/x/net-0.36.0
...
Bump golang.org/x/net from 0.34.0 to 0.36.0
2025-03-13 11:37:06 +01:00
dependabot[bot]
7901f2364c
Bump golang.org/x/net from 0.34.0 to 0.36.0
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.34.0 to 0.36.0.
- [Commits](https://github.com/golang/net/compare/v0.34.0...v0.36.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-03-13 01:52:40 +00:00
Tyler McGoffin
66e51c723e
Merge pull request #10574 from wata727/make_missing_workflow_scope_regexp_aware_of_github_app
...
[gh repo sync] Make missing workflow regexp aware of GitHub App
2025-03-12 11:08:01 -07:00
Tyler McGoffin
5c6a80588b
Merge branch 'trunk' into make_missing_workflow_scope_regexp_aware_of_github_app
2025-03-12 10:55:21 -07:00
Tyler McGoffin
4a8ecee3b8
Merge pull request #10413 from iamazeem/5099-gh-release-create-upload-expand-glob-patterns-on-windows
...
[gh release create/upload] Expand glob patterns for all platforms
2025-03-12 08:50:00 -07:00
William Martin
7924274ef9
Merge pull request #10586 from kevincatty/trunk
...
chore: remove redundant word in comment
2025-03-12 11:35:03 +01:00