Commit graph

10563 commits

Author SHA1 Message Date
William Martin
f952311b15 Error if go-licenses is not on the PATH 2025-12-01 16:29:06 +01:00
dependabot[bot]
13d9ab631d chore(deps): bump actions/checkout from 5 to 6
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-12-01 16:24:05 +01:00
William Martin
20d32fc742 Update licenses for crypto-0.45.0 bump 2025-12-01 16:10:50 +01:00
dependabot[bot]
b3ff7c5367 chore(deps): bump golang.org/x/crypto from 0.43.0 to 0.45.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0.
- [Commits](https://github.com/golang/crypto/compare/v0.43.0...v0.45.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.45.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-12-01 16:10:50 +01:00
Andy Feller
e437b83773
Merge pull request #12191 from cli/af/12182-debian-ubuntu-community-install-docs
Add Debian/Ubuntu to unofficial packages
2025-11-24 16:59:30 -05:00
Andy Feller
f28eaa7c69 Alphabetize Ubuntu section 2025-11-24 16:34:18 -05:00
Andy Feller
6902ae8d92 Add Debian/Ubuntu to unofficial packages
Fixes #12182
2025-11-24 16:27:39 -05:00
Babak K. Shandiz
4be79a31e7
Add PGP key rotation PoC (#12176)
* chore: add initial impl of `debian-devel` script

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* temp: create archive-keyring package in progress

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* fix: add archive-keyring package to apt repo

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* fix: add `newkey` and `deprecate` steps

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* fix: remove redundant assignment

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* fix: make archive-keyring arch neutral

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Polish Debian devel experience

These changes are focused on polishing the user experience around the new Debian development script:

1. Make important details of the process easier to see with spacing and formatting
2. Remove artifact directory prompting for default directory
3. Start within /root directory of container
4. Display message of the day instructing user on commands
5. Prompt users during docker setup when container is running
6. Update help usage with more details of targets

* Remove unnecessary docblock

Now that the help usage, docker setup, and other targets guide users to the next step, the docblock explaining how to run the script are unnecessary.

* fix: improve docs and handling of variables

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-11-21 13:00:01 +00:00
Babak K. Shandiz
b5e24d5dbc
Merge pull request #12170 from cli/babakks/isolate-user-query-from-base-qualifiers
Isolate user-provided search query from contextual qualifiers
2025-11-20 17:03:20 +00:00
Babak K. Shandiz
56cdc36013
refactor(pkg/search): rename KeywordsVerbatim to ImmutableKeywords
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 16:53:16 +00:00
Babak K. Shandiz
1533d8177c
refactor(pkg/search): rewrite returns in a more verbose way
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 16:26:27 +00:00
Babak K. Shandiz
1cd4840199
fix(pr/shared): delegate query compilation to search package
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 13:35:24 +00:00
Babak K. Shandiz
76b2de8a18
test(pkg/search): assert verbatim keywords are respected
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 13:08:27 +00:00
Babak K. Shandiz
d8486ccf10
fix(pkg/search): add KeywordsVerbatim field to Query type
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 13:07:27 +00:00
Babak K. Shandiz
d3fb77f096
Merge pull request #12154 from cli/af/12153-agent-list-default
Remove extra flag default from help usage
2025-11-17 15:23:43 +00:00
Andy Feller
e85877dd75 Remove extra flag default from help usage
Fixes #12153
2025-11-17 10:09:17 -05:00
William Martin
8a4154cfe7 Refactor cfg out of CAPI Client 2025-11-14 20:21:54 +01:00
dependabot[bot]
680a8c4c4f
Merge pull request #12134 from cli/dependabot/github_actions/golangci/golangci-lint-action-9.0.0 2025-11-13 12:07:43 +00:00
dependabot[bot]
1a06438f91
chore(deps): bump golangci/golangci-lint-action from 8.0.0 to 9.0.0
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 8.0.0 to 9.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](4afd733a84...0a35821d5c)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-version: 9.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-11-13 11:57:15 +00:00
Kynan Ware
85d6766c62
Merge pull request #12122 from cli/kw/fix-always-send-reviewer-array
`gh pr edit`: Ensure empty arrays for reviewers in PR API calls
2025-11-10 11:25:58 -07:00
Kynan Ware
273fccd908 Check user and teams nil state instead of length 2025-11-10 11:09:14 -07:00
Babak K. Shandiz
eb30e67236
Merge branch 'trunk' into kw/fix-always-send-reviewer-array 2025-11-10 09:33:13 +00:00
Babak K. Shandiz
55ab926f8e
Merge pull request #12123 from cli/kw/update-third-party-licenses
Update third-party licenses and dependencies
2025-11-10 09:32:54 +00:00
Kynan Ware
d91480aba9 Update third-party licenses and dependencies 2025-11-07 14:35:46 -07:00
Kynan Ware
e154601f7d Ensure empty arrays for reviewers in PR API calls
Updated AddPullRequestReviews and RemovePullRequestReviews to send empty arrays instead of null values for reviewers and team_reviewers when no users or teams are specified, as required by the API.
2025-11-07 14:00:28 -07:00
Kynan Ware
44df793d56
Merge pull request #12112 from cli/kw/revert-11370
Integrate license checks back into lint workflow
2025-11-07 09:41:56 -07:00
Kynan Ware
cc178cf5e4
Update .github/workflows/lint.yml
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-07 09:31:36 -07:00
Kynan Ware
b917c4cd50 Annotate go-licenses install with version tag
Added a comment specifying the installed go-licenses commit corresponds to v2.0.1 for clarity in the lint workflow.
2025-11-07 09:27:40 -07:00
Kynan Ware
9eb019ae56 Integrate license checks back into lint workflow
Reverts https://github.com/cli/cli/pull/11370
2025-11-06 11:57:51 -07:00
Kynan Ware
152d328db8
Merge pull request #12084 from cli/babakks/add-basic-linters
chore: add basic linters
2025-11-04 10:46:40 -07:00
Kynan Ware
bb9641a78a
Merge pull request #12095 from cli/dependabot/go_modules/github.com/cli/go-gh/v2-2.13.0
chore(deps): bump github.com/cli/go-gh/v2 from 2.12.2 to 2.13.0
2025-11-04 10:24:54 -07:00
dependabot[bot]
f2d0f9e955
chore(deps): bump github.com/cli/go-gh/v2 from 2.12.2 to 2.13.0
Bumps [github.com/cli/go-gh/v2](https://github.com/cli/go-gh) from 2.12.2 to 2.13.0.
- [Release notes](https://github.com/cli/go-gh/releases)
- [Commits](https://github.com/cli/go-gh/compare/v2.12.2...v2.13.0)

---
updated-dependencies:
- dependency-name: github.com/cli/go-gh/v2
  dependency-version: 2.13.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-11-04 17:15:12 +00:00
Babak K. Shandiz
895c314c5c
Merge pull request #12064 from cli/babakks/add-isimmutable-to-release-list
Add `isImmutable` to `release list` JSON output
2025-11-04 12:43:36 +00:00
Babak K. Shandiz
408f9e0de1
Merge branch 'trunk' into babakks/add-basic-linters
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:24:12 +00:00
Kynan Ware
c0d5f164f2
Merge pull request #12089 from cli/kw/use-source-govulncheck-scan-lint
CI: Update lint govulncheck to use source mode
2025-11-03 13:18:27 -07:00
Kynan Ware
52391ff0f8
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-03 13:08:16 -07:00
Kynan Ware
b151f53d02 Add note on govulncheck source mode for Go 1.25 2025-11-03 13:05:33 -07:00
Babak K. Shandiz
917e365c5c
docs(pkg/search): fix typo
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:28 +00:00
Babak K. Shandiz
0e53651bb2
docs(repo garden): improve func godoc
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:27 +00:00
Babak K. Shandiz
d3b333e5be
fix: ignore nilerr on intentionally swallowed error
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:27 +00:00
Babak K. Shandiz
d002d30327
fix: resolve nilerr issues
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:26 +00:00
Babak K. Shandiz
f498f2e882
fix: resolve copyloopvar issues
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:26 +00:00
Babak K. Shandiz
3ad3fcdce9
fix: resolve gocritic issue
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:26 +00:00
Babak K. Shandiz
0eb5640edb
test(pkg/httpmock): ignore bodyclose on mock response value
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:25 +00:00
Babak K. Shandiz
2709c39179
refactor(repo garden): return pagination link instead of resp
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:25 +00:00
Babak K. Shandiz
9f65e89760
fix: close resp body (bodyclose)
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:25 +00:00
Babak K. Shandiz
d129b94fc5
refactor: remove returned resp from api.EndpointNeedsScopes
The returned response from `api.EndpointNeedsScopes` causes `bodyclose`
linter to raise a false positive error, assuming it's a new response that
its body needs to be closed.

Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:24 +00:00
Babak K. Shandiz
dde7fce602
refactor(pkg/search): remove passing resp for pagination
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:24 +00:00
Babak K. Shandiz
c6c97b32d5
ci: enable basic linters
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:20 +00:00
Kynan Ware
6c1d1c4f49 Update lint govulncheck to use source mode
Replaces binary mode scan of 'bin/gh' with source mode scan of all packages using govulncheck.
2025-11-03 12:55:13 -07:00