Michael Hoffman
fa254ba205
Complete get -> list renaming
2024-12-28 07:51:47 -05:00
Michael Hoffman
da826db342
Better error testing for autolink TestListRun
2024-12-27 22:58:12 -05:00
Michael Hoffman
20f086549a
Decode instead of unmarshal
2024-12-27 22:03:25 -05:00
Michael Hoffman
63488a1a06
Use 'list' instead of 'get' for autolink list type and method
2024-12-27 22:02:19 -05:00
Michael Hoffman
dc6320f7f7
Remove NewAutolinkClient
2024-12-27 21:47:27 -05:00
Michael Hoffman
cc24289832
Break out autolink list json fields test
2024-12-27 21:43:47 -05:00
Michael Hoffman
67266e9cb8
PR nits
2024-12-27 21:40:52 -05:00
Michael Hoffman
e98ff2ea38
Refactor autolink subcommands into their own packages
2024-12-27 21:36:16 -05:00
Michael Hoffman
ea04d2da30
Whitespace
2024-12-27 21:36:16 -05:00
Michael Hoffman
869d25193a
Refactor out early return in test code
...
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-12-27 21:36:16 -05:00
Tyler McGoffin
4a74cc8856
Add testing for AutoLinkGetter
...
This adds the missing mocked http tests to the http_test.go file. These
tests were previously bundled with the tests in list_test.go, creating a
testing pattern that was difficult to understand and maintain. The
refactor in the previous commit replaced these tests with the
AutolinkClient interface, allowing for the httpmocks to be isolated to the
AutolinkGetter that implements that interface.
2024-12-27 21:36:16 -05:00
Tyler McGoffin
a390ce4f10
Refactor autolink list and test to use http interface for simpler testing
...
This defines an AutolinkClient interface with a Get method used for
fetching the autolinks lists from the api. Then, the http client for
autolinks implements this interface with the AutolinkGetter struct.
This allows for dependency injection of the AutolinkGetter struct into the
listOptions, enabling mocking of the AutolinkGetter for testing. The
result of this is simpler tests that are easier to maintain, because the
interface for the table tests now allow for defining autolink structs as
the response instead of large mocked api calls.
This also allows for bespoke testing of the http file, which I'll follow
up with in the next commit.
2024-12-27 21:36:16 -05:00
Tyler McGoffin
5fb98524e0
Apply PR comment changes
2024-12-27 21:36:16 -05:00
Michael Hoffman
23c16c9c4c
Introduce repo autolinks list commands
2024-12-27 21:36:16 -05:00
Tyler McGoffin
6c51451660
Merge pull request #10145 from shauryatiwari1/remove-discussions
...
Remove release discussion posts and clean up related block in deployment yml
2024-12-27 08:59:35 -08:00
Tyler McGoffin
c968e5c60c
Merge pull request #10143 from dziamidchyk/add-pending-status-for-workflows
...
add pending status for workflow runs
2024-12-27 08:38:26 -08:00
shauryatiwari1
eed3626521
Remove release discussion posts and clean up related block in deployment yml
2024-12-27 15:15:21 +05:30
Arseni Dziamidchyk
f9767d0a9a
add pending status for workflow runs
2024-12-26 19:10:06 +03:00
William Martin
48bc3cabab
Merge pull request #10135 from cli/jtmcg/update-go-net
...
Upgrade golang.org/x/net to v0.33.0
2024-12-24 12:38:37 +01:00
Tyler McGoffin
7357bad2d3
Merge pull request #10112 from heaths/gh-merge-base-docs
...
Document how to set gh-merge-base
2024-12-23 11:51:10 -08:00
Tyler McGoffin
939e183cd6
Upgrade golang.org/x/net to v0.33.0
2024-12-23 11:43:51 -08:00
William Martin
b476849331
Merge pull request #10116 from cli/andyfeller/10113-update-release-docs
...
Update releasing.md
2024-12-23 19:48:31 +01:00
William Martin
0a280ff145
Merge pull request #10110 from cli/10109-document-the-base-repo-resolution-functions
...
Document the base repo resolution functions
2024-12-23 19:47:38 +01:00
William Martin
b9c597458b
Document SmartBaseRepoFunc
2024-12-23 19:07:17 +01:00
William Martin
7a954cde82
Document BaseRepoFunc
2024-12-23 19:07:17 +01:00
Andy Feller
0e191ef0f2
Update releasing.md
2024-12-20 15:34:26 -05:00
Heath Stewart
78836097c3
Document how to set gh-merge-base
...
Follow-up to PR #9712
2024-12-20 10:49:38 -08:00
Meredith Lancaster
5402e207ee
Merge pull request #10012 from malancas/consolidate-verify-policy-options-config
...
Perform all `gh attestation verify` policy options configuration in the `newEnforcementCriteria()` function
2024-12-18 09:21:34 -07:00
Meredith Lancaster
2992d7abf2
Merge branch 'consolidate-verify-policy-options-config' of github.com:malancas/cli into consolidate-verify-policy-options-config
2024-12-18 07:25:04 -07:00
Meredith Lancaster
3542b3566a
add test for different SAN and SourceRepositoryURI values
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-18 07:24:44 -07:00
Meredith Lancaster
c27fabe446
Merge branch 'trunk' into consolidate-verify-policy-options-config
2024-12-18 07:05:29 -07:00
Meredith Lancaster
4431fa9d8f
add test for signerRepo and tenant
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-18 06:55:00 -07:00
Meredith Lancaster
86b815e9bf
add some more fields to test that san, sanregex are set properly
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-18 06:49:08 -07:00
William Martin
d3f6ad491e
Merge pull request #10094 from cli/dependabot/go_modules/github.com/cpuguy83/go-md2man/v2-2.0.6
...
Bump github.com/cpuguy83/go-md2man/v2 from 2.0.5 to 2.0.6
2024-12-17 18:02:52 +01:00
dependabot[bot]
ede6c4de1a
Bump github.com/cpuguy83/go-md2man/v2 from 2.0.5 to 2.0.6
...
Bumps [github.com/cpuguy83/go-md2man/v2](https://github.com/cpuguy83/go-md2man ) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/cpuguy83/go-md2man/releases )
- [Commits](https://github.com/cpuguy83/go-md2man/compare/v2.0.5...v2.0.6 )
---
updated-dependencies:
- dependency-name: github.com/cpuguy83/go-md2man/v2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-12-17 14:41:05 +00:00
Meredith Lancaster
83770d8e55
update san and sanregex configuration for readability
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 18:42:29 -07:00
Meredith Lancaster
9acd0c7e06
Merge branch 'consolidate-verify-policy-options-config' of github.com:malancas/cli into consolidate-verify-policy-options-config
2024-12-16 17:06:41 -07:00
Meredith Lancaster
1df2976e81
reduce duplication when creating policy content
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 17:06:36 -07:00
Meredith Lancaster
08f6e2f943
Merge branch 'trunk' into consolidate-verify-policy-options-config
2024-12-16 08:08:09 -07:00
Meredith Lancaster
64bf37e31c
Merge pull request #10051 from malancas/gh-attestation-download-windows-bug
...
Use Windows compatible file name for downloaded attestations when running `gh attestation download`
2024-12-16 08:01:36 -07:00
Tyler McGoffin
a50fc7079e
Merge pull request #10055 from jobegrabber/improve-apt-setup-script
...
Improve error handling in apt setup script
2024-12-13 15:16:37 -08:00
Meredith Lancaster
90f5dae82b
Merge branch 'trunk' into consolidate-verify-policy-options-config
2024-12-13 15:23:01 -07:00
Meredith Lancaster
9b905d9f18
Merge pull request #9891 from malancas/print-policy-info
2024-12-13 15:14:05 -07:00
Phill MV
dd95e5a863
tweak output of build policy info
2024-12-13 15:55:49 -05:00
Kynan Ware
b3f74900f2
Merge pull request #10078 from cli/10077-gh-pr-view-cannot-find-pr-from-branch-when-fork-is-in-the-same-org-as-upstream
...
Support `pr view` for intra-org forks
2024-12-13 11:44:43 -07:00
Phill MV
c789b56da4
Merge pull request #9954 from cli/phillmv/improve-gh-at-inspect
2024-12-13 09:50:52 -05:00
William Martin
d662226ae4
Name conditionals in PR finder
2024-12-13 14:33:33 +01:00
William Martin
96ac8d6a2f
Support pr view for intra-org forks
2024-12-13 14:27:41 +01:00
Kynan Ware
c35d725b0b
Merge pull request #10074 from cli/kw/cli-7011-fix-delete-branch-with-merge-queue-v2
...
`gh pr merge --delete-branch` exits with error when merge requested via merge queue
2024-12-12 16:05:06 -07:00
Kynan Ware
253b082600
Return err instead of silentError in merge queue check
2024-12-12 15:54:01 -07:00
