Commit graph

7577 commits

Author SHA1 Message Date
Andy Feller
faef2ddd81
Merge pull request #9140 from cli/andyfeller/cli-9139-sign-pkg-predocs
Clarify Mac OS Installer packages are unsigned
2024-05-29 10:43:36 -04:00
Andy Feller
2bb99001cd Clarify Mac OS Installer packages are unsigned
Relates #9139

This commit clarifies Mac OS Installer packages are unsigned due to additional work to obtain an Apple Developer ID Installer-signing identity.
2024-05-29 10:31:39 -04:00
William Martin
3620e791dc
Merge pull request #9136 from cli/wm/fix-pkgmacos-completions
Build completions during release on macos
2024-05-29 10:55:51 +02:00
William Martin
f3f93c6f74 Build completions during release on macos 2024-05-28 19:08:05 +02:00
William Martin
f1dedc9abb
Merge pull request #9124 from cli/dependabot/go_modules/github.com/gabriel-vasile/mimetype-1.4.4
build(deps): bump github.com/gabriel-vasile/mimetype from 1.4.3 to 1.4.4
2024-05-28 18:11:55 +02:00
Meredith Lancaster
e55093347c
Add build provenance for gh CLI releases (#9087)
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-05-28 18:10:50 +02:00
Meredith Lancaster
8d0518645f
Add integration tests for gh attestation verify shared workflow use case (#9107)
* add initial shared workflow use case tests and test data

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add more shared workflow tests

Signed-off-by: Meredith Lancaster <malancas@github.com>

* cleanup tests

Signed-off-by: Meredith Lancaster <malancas@github.com>

* pr feedback, replace shared with reusable

Signed-off-by: Meredith Lancaster <malancas@github.com>

* use demo repository with reusable workflow tests

Signed-off-by: Meredith Lancaster <malancas@github.com>

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-05-28 07:13:34 -06:00
Andy Feller
1bc3cfa460
Merge pull request #7555 from paulober/feature-macos-pkg-installer
Add macOS pkg installer to deployment (#7554)
2024-05-24 15:35:52 -04:00
Andy Feller
bdc40a00d4 Update readme about MacOS pkg 2024-05-24 15:26:37 -04:00
Andy Feller
279d53af98 Remove v prefix when pkgmacos is called
Existing Mac OS release artifacts use the tag name / version in the file name but drop the `v` prefix.  This does the same for the Mac OS installer.
2024-05-24 15:09:40 -04:00
Paul
4db87793cd
Merge branch 'trunk' into feature-macos-pkg-installer 2024-05-24 19:25:58 +02:00
paulober
f66367d342
Integrate argument array to remove duplicate code
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-24 19:20:39 +02:00
dependabot[bot]
b2fead7dff
build(deps): bump github.com/gabriel-vasile/mimetype from 1.4.3 to 1.4.4
Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/gabriel-vasile/mimetype/releases)
- [Commits](https://github.com/gabriel-vasile/mimetype/compare/v1.4.3...v1.4.4)

---
updated-dependencies:
- dependency-name: github.com/gabriel-vasile/mimetype
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-24 14:47:29 +00:00
paulober
27262ff5ae
Added native min os version blocking
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-24 16:15:04 +02:00
paulober
1990952a62
Fix distribution.xml + min macos version requirements
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-24 16:08:22 +02:00
paulober
74392ff654
Added make macospkg target
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-24 15:25:02 +02:00
paulober
85f424bb08
Fix directory already exists
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-24 15:19:54 +02:00
Arne Jørgensen
08a5589abe
Add a gh variable get FOO command (#9106)
Closes #9103.

---------

Co-authored-by: William Martin <williammartin@github.com>
2024-05-23 17:11:53 +02:00
William Martin
99568e6345
Merge pull request #9115 from anda3/feature/nonascii-path-regex-improvement 2024-05-23 12:14:01 +02:00
William Martin
a66a646ca5 Add comment to pr diff regex 2024-05-23 11:59:56 +02:00
Katsuhiko Anda
e5e5c4fc43 Update regex in changedFilesNames to handle quoted paths 2024-05-23 03:13:16 +00:00
cawfeecake
105bafd2ec
fix: rename the Attempts field to Attempt; expose in gh run view and gh run ls (#8905)
Co-authored-by: William Martin <williammartin@github.com>
2024-05-22 14:39:13 +02:00
paulober
9454d5e71c
Change minimum build script macOS version
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-22 01:47:48 +02:00
paulober
3830c3356c
Cleanup pkgmacos build script
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-22 01:43:16 +02:00
paulober
18f41db31a
Removed redundant specifications
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-22 00:27:29 +02:00
paulober
6e58a2a216
Fix indentation
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-21 22:57:01 +02:00
paulober
d2d599daf5
Undo goreleaser change
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
2024-05-21 20:00:59 +02:00
nobe4
140edf7327
feat: add support for stateReason in gh pr view (#9080) 2024-05-21 19:54:56 +02:00
Paul
80830d769e
Fix indentation
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-05-21 19:46:51 +02:00
Paul
f9d6b1d99b
Fix indentation
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-05-21 19:43:31 +02:00
Paul
eb23e0723e
Indentation fix
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-05-21 19:39:25 +02:00
Paul
aeb0ac74ec
Update choice title
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-05-21 18:26:03 +02:00
Paul
b1a6ce3e75
Update pkg title
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-05-21 18:23:01 +02:00
William Martin
7dc7b9838d
Merge pull request #9052 from jasonodonnell/trunk
Fix doc bug for gh run watch
2024-05-21 18:04:24 +02:00
Paul
630ab13461
Merge branch 'trunk' into feature-macos-pkg-installer 2024-05-20 17:05:23 +02:00
Andy Feller
ff3a59802d
Merge pull request #9088 from leevic31/8535-remove-message-when-checking-for-extension-upgrades
Removed tty message when checking for extension upgrades
2024-05-20 08:55:52 -04:00
Andy Feller
f9722d8df4
Merge pull request #8824 from gabemontero/ggm-issue-8677-tinker
list the various alias permutations for the command and subcommands, via '--help' and 'gh reference'
2024-05-17 10:23:32 -04:00
gabemontero
39e4cbd973 update generated content for man pages and website 2024-05-17 09:30:53 -04:00
gabemontero
77f964aa12 williammartin simplifications 2024-05-17 09:30:53 -04:00
gabemontero
c265753275 remove no-op if clause that returns 'No Aliases' 2024-05-17 09:30:53 -04:00
Andy Feller
7dd35e7470 Conditionalize references, remove redundant alias
This commit adds conditional logic in `gh reference` to only show aliases if
there are aliases to see.  Additionally, this removes the unaliased command
name from being shown under aliases.
2024-05-17 09:30:53 -04:00
gabemontero
dd7ea5adff list the various alias permutations for the command and subcommands
this occurs from either utlizing the help function for a specific command/subcommand
combination or when 'gh reference' lists the command tree
2024-05-17 09:30:53 -04:00
William Martin
3b9f9a8f59
Merge pull request #9095 from cli/wm/rework-auth-tests-with-new-credential-abstractions
Rework first auth tests with new gitcredential abstractions
2024-05-17 15:26:49 +02:00
William Martin
a37253746e Remove TODO and add comment on LoginFlow tests 2024-05-17 14:51:02 +02:00
William Martin
3fe555b0bb Comment the purpose of the helper config contract 2024-05-17 14:33:19 +02:00
William Martin
540bda1a6b Test git credentials are configured in LoginFlow 2024-05-17 14:31:21 +02:00
William Martin
ba1afa2c5d Add HelperConfig contract test and FakeHelperConfig 2024-05-17 14:16:14 +02:00
William Martin
3ea937d903 Inject GitCredentialFlow to LoginFlow as test seam 2024-05-17 13:26:23 +02:00
Victor Lee
6c3a461aa5
Merge branch 'trunk' into 8535-remove-message-when-checking-for-extension-upgrades 2024-05-16 15:54:46 -04:00
leevic31
222d6c8e65 Removed unused param flagDryRun from upgradeFunc 2024-05-16 15:41:47 -04:00