Commit graph

440 commits

Author SHA1 Message Date
Jake Shorty
832f35e000 PreFlight => BillableOwner for less confusion 2022-06-20 17:12:07 +00:00
Jake Shorty
ddbf8590e8 Fix error message and JSON keys 2022-06-19 18:28:33 +00:00
Jake Shorty
cad9a050be Get basics working with codespaces pre-flight during creation 2022-06-16 15:42:29 +00:00
Jake Shorty
edf83af07a Add Codespaces pre-flight request to API client 2022-06-15 21:17:04 +00:00
Mislav Marohnić
9351f272dc pr merge: fix merge queue API access for PAT consumers
The github.com API right now doesn't seem to make merge queue APIs
available to people who use PAT to authenticate gh requests. This
switches the conditional request strategy to also do feature-detection
for dotcom (instead of just for Enterprise).
2022-06-09 14:38:58 +02:00
Sam Coe
39dd3e66e8
Use go-gh repository.ParseWithHost (#5655) 2022-06-08 21:21:59 +00:00
Mislav Marohnić
4b488a7f6a
Merge pull request #5762 from cli/codespace-start-progress
Clean up progress indicator if codespace fails to start
2022-06-08 17:48:57 +02:00
Mislav Marohnić
4c6358dcbf Guard PR merge queue queries behind feature detection 2022-06-08 12:25:22 +02:00
Mislav Marohnić
80f130184c repo edit: fix interactive mode in GHES < 3.3 2022-06-07 17:54:52 +02:00
Sam Coe
33975a95e4
Allow repo list to work with GHES earlier than 3.3 2022-06-06 12:45:55 -05:00
Mislav Marohnić
8c5ae36311 Clean up progress indicator if codespace fails to start 2022-06-06 14:32:01 +02:00
Mislav Marohnić
afb69d2d31 cs edit: 💅 implementation and tests 2022-06-01 17:18:17 +02:00
Sam Coe
539b150833
Extract feature detection package (#5494) 2022-05-17 19:07:44 +00:00
Sam Coe
9454ad3769
Change int to uint64 for large fields (#5651) 2022-05-17 06:37:55 +00:00
Sam Coe
d244346960
Replace uses of strings.Title (#5623) 2022-05-12 13:52:21 +00:00
Greggory Rothmeier
06153770a9
Merge pull request #5504 from greggroth/gregg/retention-period
Add support for setting codespace retention-period
2022-05-10 18:21:55 +02:00
Mislav Marohnić
0eedef3947 auth: respect GH_BROWSER, browser config, avoid opening non-HTTP URLs 2022-05-10 17:52:16 +02:00
Heath Stewart
5ed83e2b2a
Remove Stringer from ghrepo.Interface (#5536) 2022-04-28 08:58:34 +02:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
Heath Stewart
19a852ae9f
Add label clone command (#5452) 2022-04-25 18:13:22 +00:00
Jeff Hubbard
7678274464
Merge pull request #5076 from cli/multi-devcontainer
Multi devcontainer
2022-04-20 12:06:23 -07:00
Jeff Hubbard
2b57084bd0 PR feedback 2022-04-20 11:52:32 -07:00
Jack Meyer
ce0562c5f2
Add codespace open --web flag (#5380)
Co-authored-by: Luan Vieira <luanzeba@github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-11 19:09:27 +02:00
Naïm Favier
8dbd07212c
Stop auth commands from modifying global config file (#5378) 2022-04-11 17:26:18 +02:00
Jeff Hubbard
de9b5ad8f8
Merge branch 'trunk' into multi-devcontainer 2022-04-08 15:17:33 -07:00
Jake Shorty
6783509d3b
Merge pull request #5410 from cli/codespaces-location-optional
Make location an optional flag when creating codespaces
2022-04-07 10:58:39 -06:00
Jake Shorty
41719f7624 Location is an optional flag when creating codespaces 2022-04-05 20:19:19 +00:00
Amanda Lin
6490f658de handle IdleTimeoutNotice 2022-04-05 10:27:26 -05:00
Jake Shorty
08bbf3bd30 Check paths safely for codespaces SSH and SCP commands 2022-03-31 15:59:20 +00:00
Jeff Hubbard
ef0672eac0
Merge branch 'trunk' into multi-devcontainer 2022-03-29 13:46:05 -07:00
lylecantcode
56fda0f8c6
Support GH_DEBUG to control verbosity, deprecate DEBUG (#5306)
The GH_DEBUG environment variable is a new gh-specific verbosity control.

For backwards-compatibility, DEBUG will still be respected if it has values
"1", "true", "yes", and "api", but any other values will be ignored.

Finally, support for "oauth" debug value has been dropped in favor of "api".
The "oauth" value only had limited, internal use.

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-03-29 18:05:35 +02:00
Jeff Hubbard
9554e522af Change the way we parse list-devcontainers response 2022-03-28 14:24:57 -07:00
Jeff Hubbard
03b8b16585 Merge branch 'trunk' of ssh://github.com/cli/cli into multi-devcontainer 2022-03-28 13:59:01 -07:00
Gabe D
3a949203c4
Update Codespace permissions opt out param (#5344) 2022-03-25 12:12:14 +01:00
Caleb Brose
623e67f6b1 Update comments/usage and remove -- 2022-03-23 16:09:07 +00:00
Caleb Brose
a03051f295 Refactoring and comments 2022-03-22 14:49:58 +00:00
Caleb Brose
f22320a478 Parse scp args 2022-03-22 01:57:37 +00:00
Jeff Hubbard
ce3d0791c3
Merge branch 'trunk' into multi-devcontainer 2022-03-16 12:51:03 -07:00
Charlie Andrews
4eedfc05c1 Add docs link comment to Codespaces struct definition 2022-03-16 10:20:13 -04:00
Charlie Andrews
7ca31e02b4 Disallow editing a codespace that has a pending operation
This is already prevented by the API, but this will make the error
message cleaner and easier to understand for the user.

Example of old error message:

```
$ gh cs edit -c cwndrws-redacted -d "some silly name"
error editing codespace: HTTP 422: your codespace has an operation pending: updating to a sku with a different amount of storage; please wait until this operation is complete (https://api.github.com/user/codespaces/cwndrws-redacted)
exit status 1

```

Example of new error message:

```
$ gh cs edit -c cwndrws-redacted -d "some silly name"
error editing codespace: codespace is disabled while it has a pending operation: Changing machine types...
exit status 1
```
2022-03-16 10:13:46 -04:00
Charlie Andrews
3f65e5ae24 Add pending opertion and reason to codespace response struct 2022-03-15 17:19:47 -04:00
GitHub Action
de88d9e186 Only export vscsTarget for non-prod 2022-03-11 11:13:38 -06:00
GitHub Action
94128d683c Add consts for targets and treat empty as prod 2022-03-10 19:59:24 -06:00
GitHub Action
5e62a417d8 Add emojis to name 2022-03-10 18:50:12 -06:00
GitHub Action
a3b69e8d87 Add missed file 2022-03-10 17:10:36 -06:00
Josh Spicer
4d5ce7aa56
Adds internal codespace developer flags (#5287) 2022-03-09 15:59:29 +00:00
Patrick Veverka
cd8d653285
Merge pull request #5211 from cli/edit_codspaces
Allow Editing Codespaces
2022-03-03 18:22:01 -05:00
Patrick Veverka
edfaac23da updates from review 2022-03-02 13:17:57 +00:00
Patrick Veverka
86feaff6a9 little bit of testing 2022-02-24 20:21:06 +00:00
Mark Phelps
707220a9b1 PR updates 2022-02-22 14:16:03 -05:00