Commit graph

7961 commits

Author SHA1 Message Date
William Martin
fbc72fd2be Suggest using legacy PAT for acceptance tests 2024-10-14 13:01:13 +02:00
William Martin
503659f11c Add host recommendation to Acceptance test docs 2024-10-14 12:56:27 +02:00
William Martin
0d7ec44895 Validate required env vars not-empty for Acceptance tests 2024-10-11 18:08:42 +02:00
William Martin
846a39d7be Add go to test instructions in Acceptance README 2024-10-11 17:57:08 +02:00
William Martin
fd66555510 Error if acceptance tests are targeting github or cli orgs 2024-10-11 17:51:17 +02:00
William Martin
f9b24990d6 Add codecoverage to Acceptance README 2024-10-11 16:31:23 +02:00
William Martin
9d569b3c11 Isolate acceptance env vars 2024-10-11 16:31:23 +02:00
William Martin
dc7c66c142 Add Writing Tests section to Acceptance README 2024-10-11 16:31:22 +02:00
William Martin
64f5b3c206 Add Debug and Authoring sections to Acceptance README 2024-10-11 16:31:22 +02:00
William Martin
ee5709a4b6 Acceptance test PR comment 2024-10-11 16:31:22 +02:00
William Martin
99a9b35410 Acceptance test PR merge and rebase 2024-10-11 16:31:22 +02:00
William Martin
320c5aba4a Note syntax highlighting support for txtar files 2024-10-11 16:31:22 +02:00
William Martin
502daff2a1 Refactor acceptance test environment handling 2024-10-11 16:31:22 +02:00
William Martin
5745eb1c1c Add initial acceptance test README 2024-10-11 16:31:22 +02:00
William Martin
eb9eeb10e1 Use txtar extension for testscripts 2024-10-11 16:31:22 +02:00
William Martin
99f7e048f9 Support targeting other hosts in acceptance tests 2024-10-11 16:31:22 +02:00
William Martin
464a69ae87 Use stdout2env in PR acceptance tests 2024-10-11 16:31:21 +02:00
William Martin
37171628c6 Acceptance test PR checkout 2024-10-11 16:31:21 +02:00
William Martin
5ed237c65a Add pr view test script 2024-10-11 16:31:21 +02:00
William Martin
d7465bdf3c Initial testscript introduction 2024-10-11 16:31:16 +02:00
William Martin
76ea939627
Merge pull request #9729 from cli/kw/cli-9248-handle-error-in-hostname-parsing
Handle errors when parsing hostname in auth flow
2024-10-09 13:43:46 +02:00
William Martin
f47af31c46 Bump cli/oauth to 1.1.1 2024-10-09 13:30:37 +02:00
bagtoad
ca01bb8f9c Handle errors from parsing hostname in auth flow 2024-10-08 16:12:40 -06:00
Tyler McGoffin
dfddb16ba3
Merge pull request #9626 from smemsh/markdown-maxwidth-env
configurable maxwidth for markdown WithWrap()
2024-10-07 12:35:47 -07:00
Scott Mcdermott
4aff4ebe12 Allow user to override markdown wrap width via $GH_MDWIDTH from environment 2024-10-04 17:43:06 -07:00
Kynan Ware
d645fd4f00
Merge pull request #7091 from ulfjack/patch-1
Print the login URL even when opening a browser
2024-10-03 12:37:08 -06:00
Tyler McGoffin
9bd75d23ee
Merge pull request #9650 from timrogers/timrogers/log-platform-fallback
Emit a log message when extension installation falls back to a `darwin-amd64` binary on an Apple Silicon macOS device
2024-10-03 10:19:14 -07:00
Ulf Adams
e6d39eb886 Print the login URL even when opening a browser
Fixes https://github.com/cli/cli/issues/5500.
2024-10-03 17:18:52 +02:00
Kynan Ware
dae074049a
Merge pull request #9687 from cli/kw/improve-security.md-encourage-pocs-and-investigation
Improve `SECURITY.md` with expectations for privately reported vulnerabilities
2024-10-02 12:33:43 -06:00
Kynan Ware
8ba31ddb38
Merge pull request #9683 from cli/kw/github-cli-568-unblock-community-design-work
Allow community submitted design work
2024-10-01 17:41:31 -06:00
Kynan Ware
289b9bc712
Apply suggestions from code review
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-10-01 17:24:23 -06:00
Kynan Ware
3f3acde393
Merge pull request #9688 from cli/dependabot/go_modules/github.com/theupdateframework/go-tuf/v2-2.0.1
build(deps): bump github.com/theupdateframework/go-tuf/v2 from 2.0.0 to 2.0.1
2024-10-01 14:18:20 -06:00
dependabot[bot]
29192daa23
build(deps): bump github.com/theupdateframework/go-tuf/v2
Bumps [github.com/theupdateframework/go-tuf/v2](https://github.com/theupdateframework/go-tuf) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/theupdateframework/go-tuf/releases)
- [Changelog](https://github.com/theupdateframework/go-tuf/blob/master/.goreleaser.yaml)
- [Commits](https://github.com/theupdateframework/go-tuf/compare/v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/theupdateframework/go-tuf/v2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-01 18:15:14 +00:00
Kynan Ware
023a44904a
Update SECURITY.md 2024-10-01 12:02:54 -06:00
bagtoad
efe9841caf Fix typo and wordsmithing 2024-09-30 15:14:59 -06:00
bagtoad
89628a40f9 fix typo 2024-09-30 15:13:43 -06:00
bagtoad
7b8e8be7d4 Remove trailing space from heading 2024-09-30 15:13:19 -06:00
bagtoad
aef01e22d7 Revise wording 2024-09-30 15:03:50 -06:00
bagtoad
0b29beacf4 Update docs to allow community submitted designs 2024-09-30 14:47:24 -06:00
Kynan Ware
5db26f5677
Merge pull request #9660 from its-miroma/trunk
Improve `docs/install_linux.md`
2024-09-28 09:51:54 -06:00
Miroma
4de63ac75b
Include dnf5 commands 2024-09-28 07:58:14 +02:00
Miroma
c843dddf0d
Add GPG key instructions to appropriate sections 2024-09-25 21:55:29 +02:00
Kynan Ware
5be59997d3
Merge pull request #9634 from cli/dependabot/go_modules/github.com/cpuguy83/go-md2man/v2-2.0.5
build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.4 to 2.0.5
2024-09-23 14:42:49 -06:00
Kynan Ware
be7631c7c8
Merge branch 'trunk' into dependabot/go_modules/github.com/cpuguy83/go-md2man/v2-2.0.5 2024-09-23 12:27:49 -06:00
Tyler McGoffin
9f3f91f80a
Merge pull request #9642 from cli/jtmcg/503
Replace "GitHub Enterprise Server" option with "other" in gh auth login prompting
2024-09-23 10:50:36 -07:00
Tyler McGoffin
f4af65d9df Update docs language to remove possible confusion around 'where you log in' 2024-09-23 09:35:57 -07:00
Tyler McGoffin
029dc8ffc1 Change conditional in promptForHostname to better reflect prompter changes
The old isEnterprise check no longer makes sense, given the prompter is
providing 'other', not 'GitHub Enterprise Server' as its non-GitHub.com
option. Additionally, there was an opportunity for cleaning up the code
via early returns and the removal of the default hostname lookup if we
don't need it.
2024-09-23 09:04:03 -07:00
Brian DeHamer
3bacaab73e
Merge pull request #9638 from cli/bdehamer/att-trusted-root-tenant-aware
Fix tenant-awareness for `trusted-root` command
2024-09-23 07:03:59 -07:00
Tim Rogers
1eda1b41a7
Emit a log message when extension installation falls back to a darwin-amd64 binary on an Apple Silicon macOS machine 2024-09-21 14:56:43 -05:00
Tyler McGoffin
ccb830ca36 Shorten language on Authenticate with a GitHub host.
The default authentication mode is a web-based browser flow. After completion, an
authentication token will be stored securely in the system credential store.
If a credential store is not found or there is an issue using it gh will fallback
to writing the token to a plain text file. See `gh auth status` for its
stored location.

Alternatively, use `--with-token` to pass in a token on standard input.
The minimum required scopes for the token are: `repo`, `read:org`, and `gist`.

Alternatively, gh will use the authentication token found in environment variables.
This method is most suitable for "headless" use of gh such as in automation. See
`gh help environment` for more info.

To use gh in GitHub Actions, add `GH_TOKEN: ${{ github.token }}` to `env`.

The git protocol to use for git operations on this host can be set with `--git-protocol`,
or during the interactive prompting. Although login is for a single account on a host, setting
the git protocol will take effect for all users on the host.

Specifying `ssh` for the git protocol will detect existing SSH keys to upload,
prompting to create and upload a new key if one is not found. This can be skipped with
`--skip-ssh-key` flag.

USAGE
  gh auth login [flags]

FLAGS
  -p, --git-protocol string   The protocol to use for git operations on this host: {ssh|https}
  -h, --hostname string       The hostname of the GitHub instance to authenticate with
      --insecure-storage      Save authentication credentials in plain text instead of credential store
  -s, --scopes strings        Additional authentication scopes to request
      --skip-ssh-key          Skip generate/upload SSH key prompt
  -w, --web                   Open a browser to authenticate
      --with-token            Read token from standard input

INHERITED FLAGS
  --help   Show help for command

EXAMPLES
  # Start interactive setup
  $ gh auth login

  # Authenticate against github.com by reading the token from a file
  $ gh auth login --with-token < mytoken.txt

  # Authenticate with specific host
  $ gh auth login --hostname enterprise.internal

LEARN MORE
  Use `gh <command> <subcommand> --help` for more information about a command.
  Read the manual at https://cli.github.com/manual
  Learn about exit codes using `gh help exit-codes` around Tylers-GitHub-MacBook.local
2024-09-20 15:51:07 -07:00