Commit graph

913 commits

Author SHA1 Message Date
Mislav Marohnić
1f616859fc Merge remote-tracking branch 'origin' into auth-split 2020-06-04 12:00:19 +02:00
vilmibm
7014145a81 linter appeasement 2020-06-03 15:05:44 -05:00
vilmibm
6defbbf73f finally properly handle quoted arguments to alias set 2020-06-03 15:00:49 -05:00
vilmibm
a3a6f25024 do not use string concatenation for extra args 2020-06-02 16:07:24 -05:00
vilmibm
c960e568f8 w h i t e s p a c e 2020-06-02 13:52:42 -05:00
vilmibm
51196265cc update note 2020-06-02 13:48:19 -05:00
vilmibm
4804c8bc77 odot 2020-06-02 11:26:44 -05:00
vilmibm
52a02a7a4b todo 2020-06-02 11:26:44 -05:00
vilmibm
3b4b244ab0 test for empty aliases key 2020-06-02 11:26:44 -05:00
vilmibm
37761c97fa partial cleanup 2020-06-02 11:26:44 -05:00
vilmibm
9c4bf00703 todo 2020-06-02 11:26:44 -05:00
vilmibm
2627c5bb74 only process aliases when non-existent command passed 2020-06-02 11:26:44 -05:00
vilmibm
db741a0284 oops 2020-06-02 11:26:44 -05:00
vilmibm
ad7c484243 TODO 2020-06-02 11:26:44 -05:00
vilmibm
24e97a460f prevent overriding gh commands 2020-06-02 11:26:44 -05:00
vilmibm
3552e72f7c allow overwriting aliases 2020-06-02 11:26:44 -05:00
vilmibm
e37b517211 better placeholder handling 2020-06-02 11:26:44 -05:00
vilmibm
bace327634 pass rest of args through 2020-06-02 11:26:44 -05:00
vilmibm
5fde67110e 0 args tst 2020-06-02 11:26:44 -05:00
vilmibm
f84707b5b1 args length check; needs test 2020-06-02 11:26:44 -05:00
vilmibm
125f338686 doc 2020-06-02 11:26:44 -05:00
vilmibm
7ed2e4774f docs 2020-06-02 11:26:44 -05:00
vilmibm
09fa75e141 implement gh alias set 2020-06-02 11:26:44 -05:00
Mislav Marohnić
c08d4f0697 Write all per-host config entries to hosts.yml
Read from and write to the `hosts.yml` file every time `config.yml` is
accessed. Everything that before went under the `hosts:` map now belongs
to `hosts.yml`.
2020-06-02 15:35:13 +02:00
Mislav Marohnić
77227a6c50 Trigger OAuth flow only when requesting auth token
Previously we would trigger OAuth flow when the config file did not
exist. Now we will let an empty Config object be initialized in that
case, but trigger OAuth flow when the Context caller requests an
AuthToken.
2020-06-02 13:24:39 +02:00
Mislav Marohnić
f42c9d4b2d Allow stubbing multiple config files 2020-06-02 13:19:21 +02:00
Mislav Marohnić
bfc3e4e43d
Merge pull request #916 from cli/cobra1.0
Upgrade to Cobra 1.0
2020-06-02 10:34:04 +02:00
Oscar Dominguez
dfdb5ee75d 📚 docs(typo): fix typo in gh pr review command 2020-05-31 12:10:47 +02:00
Mislav Marohnić
eab5af9449 Merge remote-tracking branch 'origin' into cobra1.0 2020-05-28 15:15:20 +02:00
Mislav Marohnić
13ba0aa56e Respect GITHUB_TOKEN in api command 2020-05-27 13:09:05 +02:00
Mislav Marohnić
2e93a065b1 Merge remote-tracking branch 'origin/master' into api-command 2020-05-27 12:56:06 +02:00
Mislav Marohnić
c6643821dc Don't offer to reauthenticate for gist if GITHUB_TOKEN is used 2020-05-27 11:57:03 +02:00
Mislav Marohnić
ab0e43c6c8 Merge remote-tracking branch 'origin/master' into auth-from-env 2020-05-27 11:44:19 +02:00
Amanda Pinsker
93dab323fa
Fix typo 2020-05-26 09:50:03 -07:00
Corey Johnson
3122696140
Merge pull request #982 from cli/remote-delete
Remote delete
2020-05-26 09:10:12 -07:00
Corey Johnson
6c5c7cf163 fix test 2020-05-26 08:37:53 -07:00
Corey Johnson
be5fc07928
Merge pull request #899 from cli/merge-interactive-merge
Interactive merge
2020-05-26 08:33:47 -07:00
Corey Johnson
b27df3410a Don't delete remote or local branches for forks 2020-05-26 08:07:18 -07:00
Nate Smith
9ebeb5fa91
Merge pull request #981 from cli/gist-create
gh gist create
2020-05-25 14:51:32 -05:00
Corey Johnson
9c075abe93 Fix tests 2020-05-22 17:45:04 -07:00
Corey Johnson
9a290d7f43 Change interactive merge language 2020-05-22 15:30:05 -07:00
Corey Johnson
9113092f5c Delete via api 2020-05-22 15:19:39 -07:00
Corey Johnson
ff97fc138d Still delete remote branch if repo flag is used 2020-05-22 15:12:48 -07:00
Corey Johnson
e643765027 Merge remote-tracking branch 'origin/merge-interactive-merge' into remote-delete 2020-05-22 15:09:29 -07:00
Corey Johnson
858cd705ab Update name 2020-05-22 15:07:39 -07:00
Corey Johnson
b2c1b12bee Don't delete branch if the repo flag is used 2020-05-22 14:39:53 -07:00
Corey Johnson
41e67aa3e7 Fix typo 2020-05-22 10:04:02 -07:00
Mislav Marohnić
108f7bd66c Dirty workaround to display helpful error message on mistyped subcommands
When executing `gh pr re` (note the incomplete command name), Cobra
would just display the help text for `gh pr` on standard output, exit
with status 0, and not print any message that you have mistyped the
"re" subcommand. Each part of this behavior is wrong.

This workaround makes sure that the helpful error message is printed on
stderr:

    $ gh pr re
    unknown command "re" for "gh pr"

    Did you mean this?
            reopen
            ready
            review

However, the exit status is still 0, whereas it should be non-zero.
Since `HelpFunc` does not return an error argument, we cannot trigger an
error status from this workaround.
2020-05-22 19:02:34 +02:00
Mislav Marohnić
a33c00d389 Merge remote-tracking branch 'origin/master' into cobra1.0 2020-05-22 18:21:35 +02:00
Mislav Marohnić
1f3725c94d Use @me to avoid having to look up current user in pr status 2020-05-22 15:58:57 +02:00