Tyler McGoffin
e1a39d8e2b
Add ghe.com to tests describing ghec data residency
2024-10-15 12:24:41 -07:00
Tyler McGoffin
81591a09b8
Use go-gh/auth package for IsEnterprise, IsTenancy, and NormalizeHostname
2024-10-15 11:56:43 -07:00
Tyler McGoffin
3a8417f6c7
Add test coverage to places where IsEnterprise incorrectly covers Tenancy
...
IsEnterprise currently returns `true` when `IsTenancy` returns true. We
prefer that this behavior is orthogonal. This commit adds failing tests to
the instances where IsEnterprise should not behave the same as IsTenancy.
These test cases are expected to pass with the inclusion of the coming
improvements to go-gh to handle the orthogonality of IsEnterprise and
IsTenancy.
2024-10-15 11:56:43 -07:00
Andy Feller
779a1203b6
Merge pull request #9471 from heaths/issue9470
...
Always print URL scheme to stdout
2024-08-21 14:46:52 -04:00
Arun
800f99d9fa
Describe bucket and state JSON fields in pr checks command
...
While the `state` field corresponds 1:1 with different GitHub Actions
states, the `bucket` field is an abstraction of the CLI that lacked
documentation. This both adds documentation about the existence of the
`bucket` field and enumerates the possible values.
2024-08-16 15:26:27 -07:00
Prabhat Kumar Sahu
1886fb46ab
Fix pr checks exit code ( #9452 )
...
* Enhance with exit code documentation
* Add new error message for PR check
* Refine gh pr checks: Add exit code 8
* Update EXIT CODES section format in man page generation
2024-08-16 14:30:11 -07:00
Heath Stewart
81f3526740
Fix tests
2024-08-16 10:11:52 -07:00
Andy Feller
a863dfdb30
Merge pull request #9433 from benebsiny/cli-9310
...
Add `pr create --editor`
2024-08-12 10:10:18 -04:00
Andy Feller
369a105c45
Minor grammatical fix
2024-08-12 10:00:37 -04:00
Tyler McGoffin
18d58b8d84
Replace --project.* flags' name with title in docs ( #9443 )
...
With the upcoming migration from v1 project to v2 projects, we'd like the
language in our documentation to align with v2 project language. In v2,
projects are referred to by `title` and not `name`, though they are
functionally equivalent under the hood for the CLI
2024-08-09 13:55:14 -07:00
benebsiny
e18c002283
Deduplicate the initialization of editor mode
2024-08-08 18:07:52 +08:00
benebsiny
e2275d7ef6
Add pr create --editor
2024-08-07 23:14:15 +08:00
Yukai Chou
d7b8ecf33d
Unify use of tab indent in non-test source files
...
Found with
rg '(^ | \t|\t )' -g '*.go' -g '!*_test.go'
Mixed indent exceptions:
- wrapped long list items with extra 2-space indent
- code snippets using space indent
- commented code lines having "\t*// \t+" prefix
2024-08-03 00:35:30 +08:00
Babak K. Shandiz
58e6196777
Fix missing variable
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 21:41:43 +01:00
Babak K. Shandiz
842562d3db
Use closure-scoped variable to catch --remove-milestone option
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 21:40:23 +01:00
Babak K. Shandiz
c9fb4ed099
Verify --milestone and --remove-milestone are not assignable at the same time
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:44:05 +01:00
Babak K. Shandiz
605b4b19e1
Assert correct parsing of --remove-milestone option
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:43:38 +01:00
Babak K. Shandiz
6dc8cc41d0
Verify --body and --body-file are not assignable at the same time
2024-07-28 15:41:54 +01:00
Babak K. Shandiz
1520292726
Add --remove-milestone option
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:40:38 +01:00
William Martin
adc8b82d11
Merge pull request #9355 from cli/wm/9241-fulldatabaseid
...
Expose fullDatabaseId for PR json export
2024-07-24 07:45:19 +02:00
William Martin
8a0d361bac
Expose fullDatabaseId for PR json export
2024-07-23 13:23:10 +02:00
William Martin
32e499e090
Add examples for template usage in PR and issue creation
2024-07-23 13:14:27 +02:00
Babak K. Shandiz
5b918cfdf0
Rename package directory and files
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-17 18:52:23 +01:00
Babak K. Shandiz
5b71586f39
Rename package name to update_branch
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-17 18:50:59 +01:00
Babak K. Shandiz
b584895ad8
Rename gh pr update to gh pr update-branch
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-17 18:50:39 +01:00
Babak K. Shandiz
989152e64f
Add test case for merge conflict error
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-16 17:33:59 +01:00
Babak K. Shandiz
5d2378dc1d
Handle merge conflict error
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-16 17:30:48 +01:00
Babak K. Shandiz
497a915a46
Return error if PR is not mergeable
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-16 15:54:59 +01:00
Babak K. Shandiz
28c72eb5b7
Replace literals with consts for Mergeable field values
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-16 15:29:11 +01:00
Babak K. Shandiz
1a6f59820e
Remove unused flag
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-16 15:05:43 +01:00
Babak K. Shandiz
171e8d33f8
Print message on stdout instead of stderr
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-16 15:02:22 +01:00
Babak K. Shandiz
c70479ac5d
Merge branch 'trunk' into 8426-add-pr-update-cmd-no-local-update
2024-07-16 14:57:33 +01:00
Andy Feller
ae5a71bbe4
Merge branch 'trunk' into add-issue-create-editor
2024-07-15 15:21:03 -04:00
William Martin
940b54c708
Add tests for JSON field support on issue and pr view commands
2024-07-12 17:35:54 +02:00
notomo
0d37174076
Add editor hint message
2024-07-09 21:01:50 +09:00
notomo
8f77b4a23f
Add issue create --editor
2024-07-09 21:01:50 +09:00
Babak K. Shandiz
8ac5ad7244
Merge branch 'trunk' into 8426-add-pr-update-cmd-no-local-update
2024-06-07 15:40:28 +01:00
William Martin
a66a646ca5
Add comment to pr diff regex
2024-05-23 11:59:56 +02:00
Katsuhiko Anda
e5e5c4fc43
Update regex in changedFilesNames to handle quoted paths
2024-05-23 03:13:16 +00:00
Andy Feller
ac5510362b
Implement ExportData to filter json fields
...
In order to filter json fields, the `ExportData` interface needed to be implemented with logic that iterated on the selected fields.
2024-05-14 09:49:07 -04:00
nobe4
8a1995c98d
fix: rename fields list
2024-05-14 08:06:54 +02:00
nobe4
178fc2e51e
feat: add json output for PR checks
2024-05-14 07:57:38 +02:00
William Martin
07e0ff7127
Fix repo fork to use remote protocol if none configured
2024-05-10 10:48:36 +02:00
William Martin
1d38230675
Move config interfaces into gh package ( #9060 )
2024-05-10 10:39:36 +02:00
Babak K. Shandiz
859337f2e2
Merge branch 'trunk' into 8426-add-pr-update-cmd-no-local-update
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-09 21:07:05 +01:00
William Martin
5007c18f5f
Fix unused params across project
2024-05-07 17:50:43 +02:00
Babak K. Shandiz
119e58c091
Update tests to account for ref comparison step
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-07 00:19:54 +01:00
Babak K. Shandiz
81df8638cb
Check if PR branch is already up-to-date
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 23:57:53 +01:00
Babak K. Shandiz
07f954229f
Add test to verify --repo requires non-empty selector
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-14 12:25:35 +01:00
Babak K. Shandiz
f85d0ebaed
Require non-empty selector when --repo override is used
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-14 12:25:01 +01:00