Commit graph

18 commits

Author SHA1 Message Date
Junichi Sato
330a385f9e
Document that gh run download downloads the latest artifact by default
This commit addresses the documentation issue.

The discussion at #7018 has confirmed that it is undocumented that
the current behavior of `gh run download` with `-n` and no `run-id`
downloads the latest artifact.

Although the behavior has not been created intentionally, it is the one
that should be documented and the future releases should warn before
a breaking change.
2024-08-08 19:35:16 +09:00
Yukai Chou
d7b8ecf33d Unify use of tab indent in non-test source files
Found with
    rg '(^ | \t|\t )' -g '*.go' -g '!*_test.go'

Mixed indent exceptions:
- wrapped long list items with extra 2-space indent
- code snippets using space indent
- commented code lines having "\t*// \t+" prefix
2024-08-03 00:35:30 +08:00
vilmibm
5597139df3 switch to []int return for multiselect 2023-05-23 00:12:44 -07:00
nate smith
c536114de0 use new prompter in run download 2023-04-10 17:38:30 -07:00
Sam Coe
39805fa9b1
Properly handle closing files that have been writen to (#7199) 2023-03-23 01:17:47 +00:00
vilmibm
41385477c3 fix linting 2022-07-27 14:15:27 -05:00
ffalor
3fb8579419
Add --pattern field to run download (#5539) 2022-05-23 08:57:57 +00:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
Mislav Marohnić
a315e6865c run download: fix extracting to root path
Our rudimentary check for whether a file path is entirely contained
under a directory had a false negative when the parent directory is "/".
2022-02-18 20:27:40 +01:00
Mislav Marohnić
11fbb60ae7 Rename the module to "github.com/cli/cli/v2" 2021-08-25 12:41:30 +02:00
Mislav Marohnić
f8c7fd1d28 Fix extracting workflow artifact to a relative path
To prevent zipslip, we verify that each extracted file would fall
strictly under the prefix of the path to extract to. However, this
yielded a false positive when extracting to `.`, which is the default
for downloading a single archive.
2021-04-13 19:15:14 +02:00
vilmibm
878bdb8d50 add an example 2021-04-07 14:48:28 -05:00
vilmibm
9b5e92e64a make test windows friendly 2021-04-07 14:47:12 -05:00
Mislav Marohnić
6ce12c07f6 Move Artifact to the "shared" package 2021-04-07 20:26:12 +02:00
Mislav Marohnić
0e94de1ce6 Address run download feedback
- With no arguments in TTY mode, prompt which artifacts to download
- Change `--pattern` argument to be just `--name` and only do exact
  matching
- For multi-archive downloads, prefix the destination path with the name
  of the artifact
- Add tests exercising HTTP functionality
- Avoid "zipslip" path injection when extracting ZIP files
- Add tests for ZIP extraction
2021-04-07 19:56:28 +02:00
Mislav Marohnić
b41681cbb7 Restore Go < 1.16 compatibility 2021-04-02 20:54:56 +02:00
Mislav Marohnić
51a0a27a6f Add ARTIFACTS information to run view 2021-04-02 20:52:41 +02:00
Mislav Marohnić
c54e3c9ca8 Add run download command for downloading workflow artifacts 2021-04-02 20:42:18 +02:00