Other list subcommands correctly reject --limit 0 but 'release list' does not validate the limit, causing an infinite loop. Add validation consistent with other subcommands and a test. Closes #13078
148 lines
3.7 KiB
Go
148 lines
3.7 KiB
Go
package list
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/cli/cli/v2/api"
|
|
fd "github.com/cli/cli/v2/internal/featuredetection"
|
|
"github.com/cli/cli/v2/internal/ghrepo"
|
|
"github.com/cli/cli/v2/internal/tableprinter"
|
|
"github.com/cli/cli/v2/internal/text"
|
|
"github.com/cli/cli/v2/pkg/cmdutil"
|
|
"github.com/cli/cli/v2/pkg/iostreams"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
type ListOptions struct {
|
|
HttpClient func() (*http.Client, error)
|
|
IO *iostreams.IOStreams
|
|
BaseRepo func() (ghrepo.Interface, error)
|
|
|
|
Exporter cmdutil.Exporter
|
|
Detector fd.Detector
|
|
|
|
LimitResults int
|
|
ExcludeDrafts bool
|
|
ExcludePreReleases bool
|
|
Order string
|
|
}
|
|
|
|
func NewCmdList(f *cmdutil.Factory, runF func(*ListOptions) error) *cobra.Command {
|
|
opts := &ListOptions{
|
|
IO: f.IOStreams,
|
|
HttpClient: f.HttpClient,
|
|
}
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "list",
|
|
Short: "List releases in a repository",
|
|
Aliases: []string{"ls"},
|
|
Args: cobra.NoArgs,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
// support `-R, --repo` override
|
|
opts.BaseRepo = f.BaseRepo
|
|
|
|
if opts.LimitResults < 1 {
|
|
return cmdutil.FlagErrorf("invalid limit: %v", opts.LimitResults)
|
|
}
|
|
|
|
if runF != nil {
|
|
return runF(opts)
|
|
}
|
|
return listRun(opts)
|
|
},
|
|
}
|
|
|
|
cmd.Flags().IntVarP(&opts.LimitResults, "limit", "L", 30, "Maximum number of items to fetch")
|
|
cmd.Flags().BoolVar(&opts.ExcludeDrafts, "exclude-drafts", false, "Exclude draft releases")
|
|
cmd.Flags().BoolVar(&opts.ExcludePreReleases, "exclude-pre-releases", false, "Exclude pre-releases")
|
|
cmdutil.StringEnumFlag(cmd, &opts.Order, "order", "O", "desc", []string{"asc", "desc"}, "Order of releases returned")
|
|
cmdutil.AddJSONFlags(cmd, &opts.Exporter, releaseFields)
|
|
|
|
return cmd
|
|
}
|
|
|
|
func listRun(opts *ListOptions) error {
|
|
httpClient, err := opts.HttpClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
baseRepo, err := opts.BaseRepo()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// TODO: immutableReleaseFullSupport
|
|
// The detector is not needed when covered GHES versions fully support
|
|
// immutable releases (probably when 3.18 goes EOL).
|
|
if opts.Detector == nil {
|
|
cachedClient := api.NewCachedHTTPClient(httpClient, time.Hour*24)
|
|
opts.Detector = fd.NewDetector(cachedClient, baseRepo.RepoHost())
|
|
}
|
|
|
|
releaseFeatures, err := opts.Detector.ReleaseFeatures()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
releases, err := fetchReleases(httpClient, baseRepo, opts.LimitResults, opts.ExcludeDrafts, opts.ExcludePreReleases, opts.Order, releaseFeatures)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if len(releases) == 0 && opts.Exporter == nil {
|
|
return cmdutil.NewNoResultsError("no releases found")
|
|
}
|
|
|
|
if err := opts.IO.StartPager(); err == nil {
|
|
defer opts.IO.StopPager()
|
|
} else {
|
|
fmt.Fprintf(opts.IO.ErrOut, "failed to start pager: %v\n", err)
|
|
}
|
|
|
|
if opts.Exporter != nil {
|
|
return opts.Exporter.Write(opts.IO, releases)
|
|
}
|
|
|
|
table := tableprinter.New(opts.IO, tableprinter.WithHeader("Title", "Type", "Tag name", "Published"))
|
|
cs := opts.IO.ColorScheme()
|
|
for _, rel := range releases {
|
|
title := text.RemoveExcessiveWhitespace(rel.Name)
|
|
if title == "" {
|
|
title = rel.TagName
|
|
}
|
|
table.AddField(title)
|
|
|
|
badge := ""
|
|
var badgeColor func(string) string
|
|
if rel.IsLatest {
|
|
badge = "Latest"
|
|
badgeColor = cs.Green
|
|
} else if rel.IsDraft {
|
|
badge = "Draft"
|
|
badgeColor = cs.Red
|
|
} else if rel.IsPrerelease {
|
|
badge = "Pre-release"
|
|
badgeColor = cs.Yellow
|
|
}
|
|
table.AddField(badge, tableprinter.WithColor(badgeColor))
|
|
|
|
table.AddField(rel.TagName, tableprinter.WithTruncate(nil))
|
|
|
|
pubDate := rel.PublishedAt
|
|
if rel.PublishedAt.IsZero() {
|
|
pubDate = rel.CreatedAt
|
|
}
|
|
table.AddTimeField(time.Now(), pubDate, cs.Muted)
|
|
table.EndRow()
|
|
}
|
|
err = table.Render()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|