FindWorkflow had a code path that could error without handling that error that was introduced in #10328. I previously called out the lack of tests in this part of the code in my review, and punting them then bit us here: https://github.com/cli/cli/pull/10328#pullrequestreview-2597266783. As such, this fixes the panic, but also adds tests to cover the relevant code paths through FindWorkflow, including some tests for getWorkflowByID, getWorkflowsByName, and GetWorkflows. This does NOT seek to refactor the existing code, just cover the existing behavior and validate that we are resolving this panic (covered by TestFindWorkflow_nonHTTPError). |
||
|---|---|---|
| .. | ||
| disable | ||
| enable | ||
| list | ||
| run | ||
| shared | ||
| view | ||
| workflow.go | ||