cli/pkg/cmd/pr
nilvng 409e3ca08c issue #2329: simplify the UI of the prompt
This commit reverts the previous color changes in the prompt UI. While color highlighting could potentially improve the visual appealing of the prompt
using the existing color library (mguz/ansi) with the prompt library (AlecAivazis/survey) caused unintended side effects.
It reset the bold text style for the selected option. We decide to that
bold text style would have a higher priority than the color text ,for
three reasons:
1. To maintain consistency with other prompts in the UI and prioritize accessibility
2. While color can enhance the user experience, according to Primer Design Guidelines, color should not be relied upon to convey essential information.
3. visual indicator of the selected option, especially crucial when dealing with long PR titles or branch names.

As a future improvement, we may consider a separate issue or PR to address the color library issue and explore controlled color usage in prompts. This could potentially allow for more nuanced visual differentiation while avoiding unintended style resets.

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 19:59:46 +11:00
..
checkout issue #2329: simplify the UI of the prompt 2024-12-06 19:59:46 +11:00
checks Merge pull request #9471 from heaths/issue9470 2024-08-21 14:46:52 -04:00
close Apply first round of owner/repo#number consistency 2024-03-01 14:03:18 -05:00
comment Fix tests 2024-08-16 10:11:52 -07:00
create Allow client push to use insecure credential pattern 2024-11-26 22:29:58 +01:00
diff Fix tests 2024-08-16 10:11:52 -07:00
edit Replace --project.* flags' name with title in docs (#9443) 2024-08-09 13:55:14 -07:00
list issue #2329: fix the linting issue 2024-11-17 14:58:38 +11:00
merge Allow client pull to use insecure credential pattern 2024-11-26 22:29:51 +01:00
ready Apply first round of owner/repo#number consistency 2024-03-01 14:03:18 -05:00
reopen Fix breaking test for PR/issue # change 2024-03-01 16:04:24 -05:00
review Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
shared issue #2329: simplify the UI of the prompt 2024-12-06 19:59:46 +11:00
status Add ghe.com to tests describing ghec data residency 2024-10-15 12:24:41 -07:00
update-branch Rename package directory and files 2024-07-17 18:52:23 +01:00
view Adding option to return baseRefOid in pr view 2024-11-19 23:50:45 +02:00
pr.go Rename package directory and files 2024-07-17 18:52:23 +01:00