cli/pkg/cmd/pr/shared
nilvng 409e3ca08c issue #2329: simplify the UI of the prompt
This commit reverts the previous color changes in the prompt UI. While color highlighting could potentially improve the visual appealing of the prompt
using the existing color library (mguz/ansi) with the prompt library (AlecAivazis/survey) caused unintended side effects.
It reset the bold text style for the selected option. We decide to that
bold text style would have a higher priority than the color text ,for
three reasons:
1. To maintain consistency with other prompts in the UI and prioritize accessibility
2. While color can enhance the user experience, according to Primer Design Guidelines, color should not be relied upon to convey essential information.
3. visual indicator of the selected option, especially crucial when dealing with long PR titles or branch names.

As a future improvement, we may consider a separate issue or PR to address the color library issue and explore controlled color usage in prompts. This could potentially allow for more nuanced visual differentiation while avoiding unintended style resets.

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 19:59:46 +11:00
..
commentable.go issue #2329: fix the linting issue 2024-11-17 14:58:38 +11:00
comments.go Add support for editing last issue/pr comment (#6384) 2022-10-18 08:10:12 +00:00
completion.go Add --reviewer flag completion (#6873) 2023-01-25 18:02:13 +01:00
display.go issue #2329: simplify the UI of the prompt 2024-12-06 19:59:46 +11:00
display_test.go Adding no checks message when PR has no checks 2022-10-05 22:10:38 -03:00
editable.go linter appeasement 2023-08-17 17:17:26 -05:00
editable_http.go Correct some typos 2023-04-21 03:51:31 +02:00
finder.go Implement initial spike for detecting and using counts by state 2023-05-17 19:59:03 +02:00
finder_test.go Update pkg/cmd/pr/shared/finder_test.go 2023-11-27 15:18:13 +01:00
params.go chore: tidy up 2024-11-07 10:20:23 +11:00
params_test.go Replace old search utility with new search (#5366) 2022-04-06 16:44:52 +02:00
preserve.go Rename the module to "github.com/cli/cli/v2" 2021-08-25 12:41:30 +02:00
preserve_test.go Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
reaction_groups.go Rename the module to "github.com/cli/cli/v2" 2021-08-25 12:41:30 +02:00
state.go fix: ignore template flag 2024-11-07 10:20:23 +11:00
survey.go Clean up Title Survey empty title message code 2024-10-17 14:40:17 -07:00
survey_test.go Remove . from test case for TestTitleSurvey 2024-10-17 14:45:35 -07:00
templates.go Add issue create --editor 2024-07-09 21:01:50 +09:00
templates_test.go Add issue create --editor 2024-07-09 21:01:50 +09:00