7ec2b2251d
Respect the default hostname determined from `hosts.yml` or GH_HOST instead of always using `github.com`.
347 lines
16 KiB
Go
347 lines
16 KiB
Go
package status
|
|
|
|
import (
|
|
"bytes"
|
|
"net/http"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/cli/cli/v2/internal/config"
|
|
"github.com/cli/cli/v2/pkg/cmdutil"
|
|
"github.com/cli/cli/v2/pkg/httpmock"
|
|
"github.com/cli/cli/v2/pkg/iostreams"
|
|
"github.com/google/shlex"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type testHostConfig string
|
|
|
|
func (c testHostConfig) DefaultHost() (string, error) {
|
|
return string(c), nil
|
|
}
|
|
|
|
func TestNewCmdStatus(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
cli string
|
|
wants StatusOptions
|
|
}{
|
|
{
|
|
name: "defaults",
|
|
},
|
|
{
|
|
name: "org",
|
|
cli: "-o cli",
|
|
wants: StatusOptions{
|
|
Org: "cli",
|
|
},
|
|
},
|
|
{
|
|
name: "exclude",
|
|
cli: "-e cli/cli,cli/go-gh",
|
|
wants: StatusOptions{
|
|
Exclude: []string{"cli/cli", "cli/go-gh"},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
io, _, _, _ := iostreams.Test()
|
|
io.SetStdinTTY(true)
|
|
io.SetStdoutTTY(true)
|
|
|
|
if tt.wants.Exclude == nil {
|
|
tt.wants.Exclude = []string{}
|
|
}
|
|
|
|
f := &cmdutil.Factory{
|
|
IOStreams: io,
|
|
Config: func() (config.Config, error) {
|
|
return config.NewBlankConfig(), nil
|
|
},
|
|
}
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
argv, err := shlex.Split(tt.cli)
|
|
assert.NoError(t, err)
|
|
|
|
var gotOpts *StatusOptions
|
|
cmd := NewCmdStatus(f, func(opts *StatusOptions) error {
|
|
gotOpts = opts
|
|
return nil
|
|
})
|
|
cmd.SetArgs(argv)
|
|
cmd.SetIn(&bytes.Buffer{})
|
|
_, err = cmd.ExecuteC()
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, tt.wants.Org, gotOpts.Org)
|
|
assert.Equal(t, tt.wants.Exclude, gotOpts.Exclude)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStatusRun(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
httpStubs func(*httpmock.Registry)
|
|
opts *StatusOptions
|
|
wantOut string
|
|
wantErrMsg string
|
|
}{
|
|
{
|
|
name: "nothing",
|
|
httpStubs: func(reg *httpmock.Registry) {
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("AssignedSearch"),
|
|
httpmock.StringResponse(`{"data": { "assignments": {"edges": [] }, "reviewRequested": {"edges": []}}}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "notifications"),
|
|
httpmock.StringResponse(`[]`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "users/jillvalentine/received_events"),
|
|
httpmock.StringResponse(`[]`))
|
|
},
|
|
opts: &StatusOptions{},
|
|
wantOut: "Assigned Issues │ Assigned Pull Requests \nNothing here ^_^ │ Nothing here ^_^ \n │ \nReview Requests │ Mentions \nNothing here ^_^ │ Nothing here ^_^ \n │ \nRepository Activity\nNothing here ^_^\n\n",
|
|
},
|
|
{
|
|
name: "something",
|
|
httpStubs: func(reg *httpmock.Registry) {
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/rpd/todo/issues/110"),
|
|
httpmock.StringResponse(`{"body":"hello @jillvalentine how are you"}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/rpd/todo/issues/4113"),
|
|
httpmock.StringResponse(`{"body":"this is a comment"}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/cli/cli/issues/1096"),
|
|
httpmock.StringResponse(`{"body":"@jillvalentine hi"}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/rpd/todo/issues/comments/1065"),
|
|
httpmock.StringResponse(`{"body":"not a real mention"}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/vilmibm/gh-screensaver/issues/comments/10"),
|
|
httpmock.StringResponse(`{"body":"a message for @jillvalentine"}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("AssignedSearch"),
|
|
httpmock.FileResponse("./fixtures/search.json"))
|
|
reg.Register(
|
|
httpmock.REST("GET", "notifications"),
|
|
httpmock.FileResponse("./fixtures/notifications.json"))
|
|
reg.Register(
|
|
httpmock.REST("GET", "users/jillvalentine/received_events"),
|
|
httpmock.FileResponse("./fixtures/events.json"))
|
|
},
|
|
opts: &StatusOptions{},
|
|
wantOut: "Assigned Issues │ Assigned Pull Requests \nvilmibm/testing#157 yolo │ cli/cli#5272 Pin extensions \ncli/cli#3223 Repo garden...│ rpd/todo#73 Board up RPD windows \nrpd/todo#514 Reducing zo...│ cli/cli#4768 Issue Frecency \nvilmibm/testing#74 welp │ \nadreyer/arkestrator#22 complete mo...│ \n │ \nReview Requests │ Mentions \ncli/cli#5272 Pin extensions │ rpd/todo#110 hello @j...\nvilmibm/testing#1234 Foobar │ cli/cli#1096 @jillval...\nrpd/todo#50 Welcome party...│ vilmibm/gh-screensaver#15 a messag...\ncli/cli#4671 This pull req...│ \nrpd/todo#49 Haircut for Leon│ \n │ \nRepository Activity\nrpd/todo#5326 new PR Only write UTF-8 BOM on W...\nvilmibm/testing#5325 comment on Ability to sea... We are working on dedicat...\ncli/cli#5319 comment on [Codespaces] D... Wondering if we shouldn't...\ncli/cli#5300 new issue Terminal bell when a runn...\n\n",
|
|
},
|
|
{
|
|
name: "exclude a repository",
|
|
httpStubs: func(reg *httpmock.Registry) {
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/rpd/todo/issues/110"),
|
|
httpmock.StringResponse(`{"body":"hello @jillvalentine how are you"}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/rpd/todo/issues/4113"),
|
|
httpmock.StringResponse(`{"body":"this is a comment"}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/rpd/todo/issues/comments/1065"),
|
|
httpmock.StringResponse(`{"body":"not a real mention"}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/vilmibm/gh-screensaver/issues/comments/10"),
|
|
httpmock.StringResponse(`{"body":"a message for @jillvalentine"}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("AssignedSearch"),
|
|
httpmock.FileResponse("./fixtures/search.json"))
|
|
reg.Register(
|
|
httpmock.REST("GET", "notifications"),
|
|
httpmock.FileResponse("./fixtures/notifications.json"))
|
|
reg.Register(
|
|
httpmock.REST("GET", "users/jillvalentine/received_events"),
|
|
httpmock.FileResponse("./fixtures/events.json"))
|
|
},
|
|
opts: &StatusOptions{
|
|
Exclude: []string{"cli/cli"},
|
|
},
|
|
// NOTA BENE: you'll see cli/cli in search results because that happens
|
|
// server side and the fixture doesn't account for that
|
|
wantOut: "Assigned Issues │ Assigned Pull Requests \nvilmibm/testing#157 yolo │ cli/cli#5272 Pin extensions \ncli/cli#3223 Repo garden...│ rpd/todo#73 Board up RPD windows \nrpd/todo#514 Reducing zo...│ cli/cli#4768 Issue Frecency \nvilmibm/testing#74 welp │ \nadreyer/arkestrator#22 complete mo...│ \n │ \nReview Requests │ Mentions \ncli/cli#5272 Pin extensions │ rpd/todo#110 hello @j...\nvilmibm/testing#1234 Foobar │ vilmibm/gh-screensaver#15 a messag...\nrpd/todo#50 Welcome party...│ \ncli/cli#4671 This pull req...│ \nrpd/todo#49 Haircut for Leon│ \n │ \nRepository Activity\nrpd/todo#5326 new PR Only write UTF-8 BOM on W...\nvilmibm/testing#5325 comment on Ability to sea... We are working on dedicat...\n\n",
|
|
},
|
|
{
|
|
name: "exclude repositories",
|
|
httpStubs: func(reg *httpmock.Registry) {
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/vilmibm/gh-screensaver/issues/comments/10"),
|
|
httpmock.StringResponse(`{"body":"a message for @jillvalentine"}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("AssignedSearch"),
|
|
httpmock.FileResponse("./fixtures/search.json"))
|
|
reg.Register(
|
|
httpmock.REST("GET", "notifications"),
|
|
httpmock.FileResponse("./fixtures/notifications.json"))
|
|
reg.Register(
|
|
httpmock.REST("GET", "users/jillvalentine/received_events"),
|
|
httpmock.FileResponse("./fixtures/events.json"))
|
|
},
|
|
opts: &StatusOptions{
|
|
Exclude: []string{"cli/cli", "rpd/todo"},
|
|
},
|
|
// NOTA BENE: you'll see cli/cli in search results because that happens
|
|
// server side and the fixture doesn't account for that
|
|
wantOut: "Assigned Issues │ Assigned Pull Requests \nvilmibm/testing#157 yolo │ cli/cli#5272 Pin extensions \ncli/cli#3223 Repo garden...│ rpd/todo#73 Board up RPD windows \nrpd/todo#514 Reducing zo...│ cli/cli#4768 Issue Frecency \nvilmibm/testing#74 welp │ \nadreyer/arkestrator#22 complete mo...│ \n │ \nReview Requests │ Mentions \ncli/cli#5272 Pin extensions │ vilmibm/gh-screensaver#15 a messag...\nvilmibm/testing#1234 Foobar │ \nrpd/todo#50 Welcome party...│ \ncli/cli#4671 This pull req...│ \nrpd/todo#49 Haircut for Leon│ \n │ \nRepository Activity\nvilmibm/testing#5325 comment on Ability to sea... We are working on dedicat...\n\n",
|
|
},
|
|
{
|
|
name: "filter to an org",
|
|
httpStubs: func(reg *httpmock.Registry) {
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/rpd/todo/issues/110"),
|
|
httpmock.StringResponse(`{"body":"hello @jillvalentine how are you"}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/rpd/todo/issues/4113"),
|
|
httpmock.StringResponse(`{"body":"this is a comment"}`))
|
|
reg.Register(
|
|
httpmock.REST("GET", "repos/rpd/todo/issues/comments/1065"),
|
|
httpmock.StringResponse(`{"body":"not a real mention"}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("UserCurrent"),
|
|
httpmock.StringResponse(`{"data": {"viewer": {"login": "jillvalentine"}}}`))
|
|
reg.Register(
|
|
httpmock.GraphQL("AssignedSearch"),
|
|
httpmock.FileResponse("./fixtures/search.json"))
|
|
reg.Register(
|
|
httpmock.REST("GET", "notifications"),
|
|
httpmock.FileResponse("./fixtures/notifications.json"))
|
|
reg.Register(
|
|
httpmock.REST("GET", "users/jillvalentine/received_events"),
|
|
httpmock.FileResponse("./fixtures/events.json"))
|
|
},
|
|
opts: &StatusOptions{
|
|
Org: "rpd",
|
|
},
|
|
wantOut: "Assigned Issues │ Assigned Pull Requests \nvilmibm/testing#157 yolo │ cli/cli#5272 Pin extensions \ncli/cli#3223 Repo garden...│ rpd/todo#73 Board up RPD windows \nrpd/todo#514 Reducing zo...│ cli/cli#4768 Issue Frecency \nvilmibm/testing#74 welp │ \nadreyer/arkestrator#22 complete mo...│ \n │ \nReview Requests │ Mentions \ncli/cli#5272 Pin extensions │ rpd/todo#110 hello @jillvalentine ...\nvilmibm/testing#1234 Foobar │ \nrpd/todo#50 Welcome party...│ \ncli/cli#4671 This pull req...│ \nrpd/todo#49 Haircut for Leon│ \n │ \nRepository Activity\nrpd/todo#5326 new PR Only write UTF-8 BOM on Windows where it is needed\n\n",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
reg := &httpmock.Registry{}
|
|
tt.httpStubs(reg)
|
|
tt.opts.HttpClient = func() (*http.Client, error) {
|
|
return &http.Client{Transport: reg}, nil
|
|
}
|
|
tt.opts.CachedClient = func(c *http.Client, _ time.Duration) *http.Client {
|
|
return c
|
|
}
|
|
tt.opts.HostConfig = testHostConfig("github.com")
|
|
io, _, stdout, _ := iostreams.Test()
|
|
io.SetStdoutTTY(true)
|
|
tt.opts.IO = io
|
|
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
err := statusRun(tt.opts)
|
|
if tt.wantErrMsg != "" {
|
|
assert.Equal(t, tt.wantErrMsg, err.Error())
|
|
return
|
|
}
|
|
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, tt.wantOut, stdout.String())
|
|
reg.Verify(t)
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_buildSearchQuery(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
sg StatusGetter
|
|
wantReviewQ string
|
|
wantAssignedQ string
|
|
}{
|
|
{
|
|
name: "nothing",
|
|
wantReviewQ: "first: 25, type: ISSUE, query:\"state:open review-requested:@me",
|
|
wantAssignedQ: "assignee:@me state:open",
|
|
},
|
|
{
|
|
name: "exclude one",
|
|
sg: StatusGetter{
|
|
Exclude: []string{"cli/cli"},
|
|
},
|
|
wantReviewQ: "first: 25, type: ISSUE, query:\"state:open review-requested:@me -repo:cli/cli",
|
|
wantAssignedQ: "assignee:@me state:open",
|
|
},
|
|
{
|
|
name: "exclude several",
|
|
sg: StatusGetter{
|
|
Exclude: []string{"cli/cli", "vilmibm/testing"},
|
|
},
|
|
wantReviewQ: "first: 25, type: ISSUE, query:\"state:open review-requested:@me -repo:cli/cli -repo:vilmibm/testing",
|
|
wantAssignedQ: "assignee:@me state:open",
|
|
},
|
|
{
|
|
name: "org filter",
|
|
sg: StatusGetter{
|
|
Org: "cli",
|
|
},
|
|
wantReviewQ: "first: 25, type: ISSUE, query:\"state:open review-requested:@me org:cli",
|
|
wantAssignedQ: "assignee:@me state:open org:cli",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
assert.Contains(t, tt.sg.buildSearchQuery(), tt.wantReviewQ)
|
|
assert.Contains(t, tt.sg.buildSearchQuery(), tt.wantAssignedQ)
|
|
}
|
|
}
|