load test
Find a file
William Martin 998b6212b3
Add skills specific telemetry
* Add skills specific telemetry

* Remove VisibilityFuture, inline goroutine at call sites

The VisibilityFuture/FetchRepoVisibilityAsync/Wait wrapper was an
unidiomatic async abstraction built for a single pattern used in
exactly two call sites. In Go the channel is already the future;
wrapping it in a struct with a Wait(timeout) method adds no value.

Delete the abstraction and inline a local visResult struct,
buffered channel, goroutine, and select at each call site. Behavior
is preserved exactly: err -> "unknown", timeout -> "unknown",
success+public -> include skill_names.

FetchRepoVisibility (synchronous) is kept as-is.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix nonsense copilot tests

* Update telemetry tests for public-only dims and search event removal

Production telemetry emission changed:
- preview: skill_owner/skill_repo/skill_name (renamed from skill_names)
  are now emitted only when repo_visibility=public.
- install: skill_owner/skill_repo/skill_names are now emitted only
  when repo_visibility=public.
- search: the initial skill_search event was removed entirely; the
  skill_search_install event no longer carries query/owner dims.

Update tests to match: rename skill_names -> skill_name in preview,
make owner/repo assertions conditional on public visibility in both
preview and install, and reduce the search test to a single event
with explicit Empty assertions for the removed query/owner dims so a
privacy regression cannot pass silently.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Test CategorizeHost and switch telemetry to skill_host_type

Add TestCategorizeHost covering all four classification branches
(github.com, ghes, tenancy, uncategorized) with cases verified
against the real ghauth implementation rather than guessed.

Update install and preview unit tests to assert the new
skill_host_type dimension name, and fix a typo in the preview
acceptance txtar (skill_hos_type -> skill_host_type).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Shrink visibility wait and test unknown visibility

The 2s visibilityWaitTimeout was wildly overprovisioned: by the time
telemetry emission reaches the select, the command has already done
several serial GitHub REST calls (and for install, a git sparse-checkout
plus possibly interactive prompts), so the one-call visibility fetch
has almost always completed. Drop the timeout to 200ms — a short safety
net for a stalled REST call, not a wait budget for a healthy one.

Also adds a table-driven case to TestFetchRepoVisibility covering an
unknown/future visibility value from the API, addressing @babakks'
review nitpick.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-17 19:58:59 +02:00
.devcontainer chore: bump Go in devcontainer 2025-10-31 12:03:25 +00:00
.github Add @cli/code-reviewers to all CODEOWNERS rules 2026-04-16 09:47:40 -06:00
acceptance Add skills specific telemetry 2026-04-17 19:58:59 +02:00
api Disable telemetry for GHES 2026-04-17 11:50:24 +02:00
build Added native min os version blocking 2024-05-24 16:15:04 +02:00
cmd Add sampled command telemetry 2026-04-16 21:42:46 +02:00
context Align no default repo message with other uses 2025-02-10 17:24:43 -05:00
docs docs: fix SHA512 checksum for GPG key 2026-04-15 11:41:31 +08:00
git address review comments 2026-04-15 16:01:26 +02:00
internal Add skills specific telemetry 2026-04-17 19:58:59 +02:00
pkg Add skills specific telemetry 2026-04-17 19:58:59 +02:00
script chore: delete experimental script/debian-devel 2026-04-09 14:07:15 +01:00
test add test for predicate type filtering 2025-04-01 11:52:13 -06:00
utils Add headers to all tables (#8157) 2023-10-20 11:20:02 +02:00
.gitattributes Retire copy-release-to-another-repo action 2020-01-29 16:13:07 +01:00
.gitignore Add sampled command telemetry 2026-04-16 21:42:46 +02:00
.golangci.yml chore: remove redundant comment 2026-01-07 15:05:59 +00:00
.goreleaser.yml Bundle licenses at release time (#12625) 2026-02-18 17:59:27 +01:00
AGENTS.md Add no em dash rule to AGENTS.md 2026-04-16 18:09:16 +02:00
go.mod Add sampled command telemetry 2026-04-16 21:42:46 +02:00
go.sum Add sampled command telemetry 2026-04-16 21:42:46 +02:00
LICENSE Create LICENSE 2019-11-21 13:22:23 -06:00
Makefile Add sampled command telemetry 2026-04-16 21:42:46 +02:00
README.md Fix typo: remove extra space in README.md link 2026-03-25 14:31:31 +01:00

GitHub CLI

gh is GitHub on the command line. It brings pull requests, issues, and other GitHub concepts to the terminal next to where you are already working with git and your code.

screenshot of gh pr status

GitHub CLI is supported for users on GitHub.com, GitHub Enterprise Cloud, and GitHub Enterprise Server 2.20+ with support for macOS, Windows, and Linux.

Documentation

For installation options see below, for usage instructions see the manual.

Contributing

If anything feels off or if you feel that some functionality is missing, please check out the contributing page. There you will find instructions for sharing your feedback, building the tool locally, and submitting pull requests to the project.

If you are a hubber and are interested in shipping new commands for the CLI, check out our doc on internal contributions

Installation

macOS

For additional macOS packages and installers, see community-supported docs

Linux & Unix

For additional Linux & Unix packages and installers, see community-supported docs

Windows

For additional Windows packages and installers, see community-supported docs

Build from source

See here on how to build GitHub CLI from source.

GitHub Codespaces

To add GitHub CLI to your codespace, add the following to your devcontainer file:

"features": {
  "ghcr.io/devcontainers/features/github-cli:1": {}
}

GitHub Actions

GitHub-hosted runners have the GitHub CLI pre-installed, which is updated weekly.

If a specific version is needed, your GitHub Actions workflow will need to install it based on the macOS, Linux & Unix, or Windows instructions above.

For information on all pre-installed tools, see actions/runner-images

Verification of binaries

Since version 2.50.0, gh has been producing Build Provenance Attestation, enabling a cryptographically verifiable paper-trail back to the origin GitHub repository, git revision, and build instructions used. The build provenance attestations are signed and rely on Public Good Sigstore for PKI.

There are two common ways to verify a downloaded release, depending on whether gh is already installed or not. If gh is installed, it's trivial to verify a new release:

  • Option 1: Using gh if already installed:

    $ gh at verify -R cli/cli gh_2.62.0_macOS_arm64.zip
    Loaded digest sha256:fdb77f31b8a6dd23c3fd858758d692a45f7fc76383e37d475bdcae038df92afc for file://gh_2.62.0_macOS_arm64.zip
    Loaded 1 attestation from GitHub API
    ✓ Verification succeeded!
    
    sha256:fdb77f31b8a6dd23c3fd858758d692a45f7fc76383e37d475bdcae038df92afc was attested by:
    REPO     PREDICATE_TYPE                  WORKFLOW
    cli/cli  https://slsa.dev/provenance/v1  .github/workflows/deployment.yml@refs/heads/trunk
    
  • Option 2: Using Sigstore cosign:

    To perform this, download the attestation for the downloaded release and use cosign to verify the authenticity of the downloaded release:

    $ cosign verify-blob-attestation --bundle cli-cli-attestation-3120304.sigstore.json \
          --new-bundle-format \
          --certificate-oidc-issuer="https://token.actions.githubusercontent.com" \
          --certificate-identity="https://github.com/cli/cli/.github/workflows/deployment.yml@refs/heads/trunk" \
          gh_2.62.0_macOS_arm64.zip
    Verified OK
    

Comparison with hub

For many years, hub was the unofficial GitHub CLI tool. gh is a new project that helps us explore what an official GitHub CLI tool can look like with a fundamentally different design. While both tools bring GitHub to the terminal, hub behaves as a proxy to git, and gh is a standalone tool. Check out our more detailed explanation to learn more.