This completely rewrites the PR lookup mechanism so that the caller must specify the GraphQL fields to query for each PR. Additionally, this fixes some export problems with `pr view --json`. Features: - Each pr command now gets assigned a concept of a Finder. This makes it easier to stub the PR in tests without having to stub the underlying HTTP calls or git invocations. - `pr view --web` is much faster since it only fetches the "url" field. - `pr diff 123` now skips a whole API call where a whole PR was unnecessarily preloaded just to access its diff in a subsequent call. - PullRequestGraphQL query builder is now used to construct queries. - A bunch of individual commands are now freed of having to know about concepts such as BaseRepo, Branch, Config, or Remotes.
160 lines
4 KiB
Go
160 lines
4 KiB
Go
package api
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/MakeNowJust/heredoc"
|
|
"github.com/cli/cli/internal/ghrepo"
|
|
"github.com/cli/cli/pkg/httpmock"
|
|
)
|
|
|
|
func TestBranchDeleteRemote(t *testing.T) {
|
|
var tests = []struct {
|
|
name string
|
|
responseStatus int
|
|
responseBody string
|
|
expectError bool
|
|
}{
|
|
{
|
|
name: "success",
|
|
responseStatus: 204,
|
|
responseBody: "",
|
|
expectError: false,
|
|
},
|
|
{
|
|
name: "error",
|
|
responseStatus: 500,
|
|
responseBody: `{"message": "oh no"}`,
|
|
expectError: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
http := &httpmock.Registry{}
|
|
http.Register(
|
|
httpmock.REST("DELETE", "repos/OWNER/REPO/git/refs/heads/branch"),
|
|
httpmock.StatusStringResponse(tt.responseStatus, tt.responseBody))
|
|
|
|
client := NewClient(ReplaceTripper(http))
|
|
repo, _ := ghrepo.FromFullName("OWNER/REPO")
|
|
|
|
err := BranchDeleteRemote(client, repo, "branch")
|
|
if (err != nil) != tt.expectError {
|
|
t.Fatalf("unexpected result: %v", err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_determinePullRequestFeatures(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
hostname string
|
|
queryResponse map[string]string
|
|
wantPrFeatures pullRequestFeature
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "github.com",
|
|
hostname: "github.com",
|
|
wantPrFeatures: pullRequestFeature{
|
|
HasReviewDecision: true,
|
|
HasStatusCheckRollup: true,
|
|
HasBranchProtectionRule: true,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "GHE empty response",
|
|
hostname: "git.my.org",
|
|
queryResponse: map[string]string{
|
|
`query PullRequest_fields\b`: `{"data": {}}`,
|
|
`query PullRequest_fields2\b`: `{"data": {}}`,
|
|
},
|
|
wantPrFeatures: pullRequestFeature{
|
|
HasReviewDecision: false,
|
|
HasStatusCheckRollup: false,
|
|
HasBranchProtectionRule: false,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "GHE has reviewDecision",
|
|
hostname: "git.my.org",
|
|
queryResponse: map[string]string{
|
|
`query PullRequest_fields\b`: heredoc.Doc(`
|
|
{ "data": { "PullRequest": { "fields": [
|
|
{"name": "foo"},
|
|
{"name": "reviewDecision"}
|
|
] } } }
|
|
`),
|
|
`query PullRequest_fields2\b`: `{"data": {}}`,
|
|
},
|
|
wantPrFeatures: pullRequestFeature{
|
|
HasReviewDecision: true,
|
|
HasStatusCheckRollup: false,
|
|
HasBranchProtectionRule: false,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "GHE has statusCheckRollup",
|
|
hostname: "git.my.org",
|
|
queryResponse: map[string]string{
|
|
`query PullRequest_fields\b`: heredoc.Doc(`
|
|
{ "data": { "Commit": { "fields": [
|
|
{"name": "foo"},
|
|
{"name": "statusCheckRollup"}
|
|
] } } }
|
|
`),
|
|
`query PullRequest_fields2\b`: `{"data": {}}`,
|
|
},
|
|
wantPrFeatures: pullRequestFeature{
|
|
HasReviewDecision: false,
|
|
HasStatusCheckRollup: true,
|
|
HasBranchProtectionRule: false,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "GHE has branchProtectionRule",
|
|
hostname: "git.my.org",
|
|
queryResponse: map[string]string{
|
|
`query PullRequest_fields\b`: `{"data": {}}`,
|
|
`query PullRequest_fields2\b`: heredoc.Doc(`
|
|
{ "data": { "Ref": { "fields": [
|
|
{"name": "foo"},
|
|
{"name": "branchProtectionRule"}
|
|
] } } }
|
|
`),
|
|
},
|
|
wantPrFeatures: pullRequestFeature{
|
|
HasReviewDecision: false,
|
|
HasStatusCheckRollup: false,
|
|
HasBranchProtectionRule: true,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
fakeHTTP := &httpmock.Registry{}
|
|
httpClient := NewHTTPClient(ReplaceTripper(fakeHTTP))
|
|
|
|
for query, resp := range tt.queryResponse {
|
|
fakeHTTP.Register(httpmock.GraphQL(query), httpmock.StringResponse(resp))
|
|
}
|
|
|
|
gotPrFeatures, err := determinePullRequestFeatures(httpClient, tt.hostname)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("determinePullRequestFeatures() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
if !reflect.DeepEqual(gotPrFeatures, tt.wantPrFeatures) {
|
|
t.Errorf("determinePullRequestFeatures() = %v, want %v", gotPrFeatures, tt.wantPrFeatures)
|
|
}
|
|
})
|
|
}
|
|
}
|