2139e763fb
We used to do the equivalent of `rootCmd.SetOut(os.Stdout)` because we thought that Cobra's "Out" stream represents standard output. However, upon closer inspection it turns out that this is Cobra's stream for usage errors and deprecation warnings, and those we want written to stderr as well. It is not clear to me why Cobra maintains a distinction between "Out" and "Err" streams since both seem to go to sdterr by default. This change also ceases our usage of `command.Print()` functions in favor of explicitly writing to `IOStreams.Out/ErrOut`.
79 lines
1.5 KiB
Go
79 lines
1.5 KiB
Go
package root
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/cli/cli/v2/pkg/iostreams"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestNewHelpTopic(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
topic string
|
|
args []string
|
|
flags []string
|
|
wantsErr bool
|
|
}{
|
|
{
|
|
name: "valid topic",
|
|
topic: "environment",
|
|
args: []string{},
|
|
flags: []string{},
|
|
wantsErr: false,
|
|
},
|
|
{
|
|
name: "invalid topic",
|
|
topic: "invalid",
|
|
args: []string{},
|
|
flags: []string{},
|
|
wantsErr: false,
|
|
},
|
|
{
|
|
name: "more than zero args",
|
|
topic: "environment",
|
|
args: []string{"invalid"},
|
|
flags: []string{},
|
|
wantsErr: false,
|
|
},
|
|
{
|
|
name: "more than zero flags",
|
|
topic: "environment",
|
|
args: []string{},
|
|
flags: []string{"--invalid"},
|
|
wantsErr: true,
|
|
},
|
|
{
|
|
name: "help arg",
|
|
topic: "environment",
|
|
args: []string{"help"},
|
|
flags: []string{},
|
|
wantsErr: false,
|
|
},
|
|
{
|
|
name: "help flag",
|
|
topic: "environment",
|
|
args: []string{},
|
|
flags: []string{"--help"},
|
|
wantsErr: false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
ios, _, _, stderr := iostreams.Test()
|
|
|
|
cmd := NewHelpTopic(ios, tt.topic)
|
|
cmd.SetArgs(append(tt.args, tt.flags...))
|
|
cmd.SetOut(stderr)
|
|
cmd.SetErr(stderr)
|
|
|
|
_, err := cmd.ExecuteC()
|
|
if tt.wantsErr {
|
|
assert.Error(t, err)
|
|
return
|
|
}
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
}
|