ac348b0dec
GitHub REST resources typically return full URLs to fetch related resources at. We used to parse those URLs to find just the path portion and pass that in to the `REST()` function, which only accepted paths. By doing so, we are essential de-constructing a URL just to re-assemble it again. While re-assembling it for Enterprise, though, we would accidentally inject an extra `api/v3/` prefix where one was not needed. The solution is just to use raw URLs as reported by the REST API with no modifications. This extends the `REST()` function to accept full URLs in addition to just paths to resources.
131 lines
3.2 KiB
Go
131 lines
3.2 KiB
Go
package api
|
|
|
|
import (
|
|
"bytes"
|
|
"errors"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/cli/cli/pkg/httpmock"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestGraphQL(t *testing.T) {
|
|
http := &httpmock.Registry{}
|
|
client := NewClient(
|
|
ReplaceTripper(http),
|
|
AddHeader("Authorization", "token OTOKEN"),
|
|
)
|
|
|
|
vars := map[string]interface{}{"name": "Mona"}
|
|
response := struct {
|
|
Viewer struct {
|
|
Login string
|
|
}
|
|
}{}
|
|
|
|
http.Register(
|
|
httpmock.GraphQL("QUERY"),
|
|
httpmock.StringResponse(`{"data":{"viewer":{"login":"hubot"}}}`),
|
|
)
|
|
|
|
err := client.GraphQL("github.com", "QUERY", vars, &response)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "hubot", response.Viewer.Login)
|
|
|
|
req := http.Requests[0]
|
|
reqBody, _ := ioutil.ReadAll(req.Body)
|
|
assert.Equal(t, `{"query":"QUERY","variables":{"name":"Mona"}}`, string(reqBody))
|
|
assert.Equal(t, "token OTOKEN", req.Header.Get("Authorization"))
|
|
}
|
|
|
|
func TestGraphQLError(t *testing.T) {
|
|
http := &httpmock.Registry{}
|
|
client := NewClient(ReplaceTripper(http))
|
|
|
|
response := struct{}{}
|
|
|
|
http.Register(
|
|
httpmock.GraphQL(""),
|
|
httpmock.StringResponse(`
|
|
{ "errors": [
|
|
{"message":"OH NO"},
|
|
{"message":"this is fine"}
|
|
]
|
|
}
|
|
`),
|
|
)
|
|
|
|
err := client.GraphQL("github.com", "", nil, &response)
|
|
if err == nil || err.Error() != "GraphQL error: OH NO\nthis is fine" {
|
|
t.Fatalf("got %q", err.Error())
|
|
}
|
|
}
|
|
|
|
func TestRESTGetDelete(t *testing.T) {
|
|
http := &httpmock.Registry{}
|
|
|
|
client := NewClient(
|
|
ReplaceTripper(http),
|
|
)
|
|
|
|
http.Register(
|
|
httpmock.REST("DELETE", "applications/CLIENTID/grant"),
|
|
httpmock.StatusStringResponse(204, "{}"),
|
|
)
|
|
|
|
r := bytes.NewReader([]byte(`{}`))
|
|
err := client.REST("github.com", "DELETE", "applications/CLIENTID/grant", r, nil)
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestRESTWithFullURL(t *testing.T) {
|
|
http := &httpmock.Registry{}
|
|
client := NewClient(ReplaceTripper(http))
|
|
|
|
http.Register(
|
|
httpmock.REST("GET", "api/v3/user/repos"),
|
|
httpmock.StatusStringResponse(200, "{}"))
|
|
http.Register(
|
|
httpmock.REST("GET", "user/repos"),
|
|
httpmock.StatusStringResponse(200, "{}"))
|
|
|
|
err := client.REST("example.com", "GET", "user/repos", nil, nil)
|
|
assert.NoError(t, err)
|
|
err = client.REST("example.com", "GET", "https://another.net/user/repos", nil, nil)
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, "example.com", http.Requests[0].URL.Hostname())
|
|
assert.Equal(t, "another.net", http.Requests[1].URL.Hostname())
|
|
}
|
|
|
|
func TestRESTError(t *testing.T) {
|
|
fakehttp := &httpmock.Registry{}
|
|
client := NewClient(ReplaceTripper(fakehttp))
|
|
|
|
fakehttp.Register(httpmock.MatchAny, func(req *http.Request) (*http.Response, error) {
|
|
return &http.Response{
|
|
Request: req,
|
|
StatusCode: 422,
|
|
Body: ioutil.NopCloser(bytes.NewBufferString(`{"message": "OH NO"}`)),
|
|
Header: map[string][]string{
|
|
"Content-Type": {"application/json; charset=utf-8"},
|
|
},
|
|
}, nil
|
|
})
|
|
|
|
var httpErr HTTPError
|
|
err := client.REST("github.com", "DELETE", "repos/branch", nil, nil)
|
|
if err == nil || !errors.As(err, &httpErr) {
|
|
t.Fatalf("got %v", err)
|
|
}
|
|
|
|
if httpErr.StatusCode != 422 {
|
|
t.Errorf("expected status code 422, got %d", httpErr.StatusCode)
|
|
}
|
|
if httpErr.Error() != "HTTP 422: OH NO (https://api.github.com/repos/branch)" {
|
|
t.Errorf("got %q", httpErr.Error())
|
|
|
|
}
|
|
}
|